- 19 Jun, 2009 40 commits
-
-
Bill Pemberton authored
This is the serqt_usb driver rewritten to use usb-serial. Signed-off-by:
Bill Pemberton <wfp5p@virginia.edu> Signed-off-by:
Greg Kroah-Hartman <gregkh@suse.de>
-
Greg Kroah-Hartman authored
This fixes some build warnings in the asus_oled driver. Signed-off-by: -
Greg Kroah-Hartman authored
This fixes some build warnings in the slicoss driver. Signed-off-by: -
Jean Delvare authored
The remove function uses __devexit, so the .remove assignment needs __devexit_p() to fix a build error with hotplug disabled. Signed-off-by:
Jean Delvare <khali@linux-fr.org> Signed-off-by:
-
Greg Kroah-Hartman authored
This fixes some build warnings in the altpciechdma driver. Signed-off-by: -
Jean Delvare authored
The remove function uses __devexit, so the .remove assignment needs __devexit_p() to fix a build error with hotplug disabled. Signed-off-by:
-
Dongxiao Xu authored
While access file_ext->state, we should use device_lock to protect it. The original codes miss this in some places. Signed-off-by:
Dongxiao Xu <dongxiao.xu@intel.com> Signed-off-by:
-
Dongxiao Xu authored
schedule_work returns 0, if the work is already on the work_queue, else returns non-zero. Do not print error message if heci_bh_handlerwork was already on queue. Signed-off-by:
Nikanth Karthikesan <knikanth@suse.de> Signed-off-by:
-
Dongxiao Xu authored
Host software could issue interrupts to ME firmware, using H_IG bit. While Setting H_IG bit, host software should preserve all the other bits in H_CSR unchanged. In the original function which sets H_CSR register, they first read the register, then set some bits, and write the whole 32bits back to the register. And that the special behavior of H_IS (write-one-to-zero) causes problem. This patch fixes the issue in the following ways: - Modify heci_set_csr_register() function so that it doesn't change H_IS bit. - Add interface heci_csr_clear_his() to clear H_IS bit. This function is called after H_IS checking (dev->host_hw_state & H_IS == H_IS). - In original heci_csr_disable_interrupts() function, it not only clears H_IE bit, sometimes it also clears H_IS bit. This patch separates the two parts. - Avoid calling write_heci_register() function to set H_CSR register directly, and instead using heci_set_csr_register() function Signed-off-by:
-
Dongxiao Xu authored
- Fix typo for enum HECI_WRITE. - Fix timeout issue. If the time period is greater or equal 15s, it's timeout. - Add 10ms wait time after disconnect, to ensure that hardware is ready. Otherwise in the next time connection, hardware resource may be busy. Signed-off-by:
-
Dongxiao Xu authored
When spinlock is nested, and the outside one is spin_lock_bh, the inner spinlock should also be spin_lock_bh, otherwise it will bring softirq-safe to softirq-unsafe lock conversion. Signed-off-by:
-
Dongxiao Xu authored
In orginal code, the device_lock and read_io_lock is mess order when nested, which may bring dead lock. This patch unify the spinlock order of device_lock and read_io_lock. First acquire device_lock, then read_io_lock. Signed-off-by:
-
Dongxiao Xu authored
When the two locks are nested, the code should always first acquire file_lock, and then acquire device_lock in order not to generate dead-lock race. Signed-off-by:
-
Dongxiao Xu authored
Fix userspace pointer mess. - In memcmp(), dest and src pointer should be both in kernel space. - Add (void __user *) modification before userspace pointer. Signed-off-by:
-
vibi sreenivasan authored
The patch does copy_to/from_user related fixes *) __copy_from/to_user is enough for user space data buffer checked by access_ok. *) return -EFAULT if __copy_from/to_user fails. *) Do not use memcpy to copy from user space. Signed-off-by:
Vibi Sreenivasan <vibi_sreenivasan@cms.com> Signed-off-by:
-
vibi sreenivasan authored
The patch fixes the following warnings. drivers/staging/rspiusb/rspiusb.c: In function ‘pixel_data’: drivers/staging/rspiusb/rspiusb.c:267: warning: passing argument 1 of ‘SetPageDirty’ makes pointer from integer without a cast drivers/staging/rspiusb/rspiusb.c: In function ‘UnMapUserBuffer’: drivers/staging/rspiusb/rspiusb.c:500: warning: passing argument 1 of ‘put_page’ makes pointer from integer without a cast drivers/staging/rspiusb/rspiusb.c: In function ‘MapUserBuffer’: drivers/staging/rspiusb/rspiusb.c:662: warning: assignment makes integer from pointer without a cast drivers/staging/rspiusb/rspiusb.c:670: warning: assignment makes integer from pointer without a cast Signed-off-by:
-
Richard Genoud authored
It seems that pixis_io and pixis_io2 should do the same thing. Signed-off-by:
Richard Genoud <richard.genoud@gmail.com> Signed-off-by:
-
Richard Genoud authored
This makes the code more readable, makes checkpatch really happy and factorize some code. Signed-off-by:
-
Richard Genoud authored
This first patch makes checkpatch happier Signed-off-by:
-
J.R. Mauro authored
Convert undefined info() function calls to dev_err, making rspiusb compile Signed-off-by:
J.R. Mauro <jrm8005@gmail.com> Signed-off-by:
-
Serge E. Hallyn authored
Before all testcases, do: mknod /dev/caphash c 253 0 mknod /dev/capuse c 253 1 This patch does the following: 1. caphash write of > CAP_NODE_SIZE bytes overruns node_ptr->data (test: cat /etc/mime.types > /dev/caphash) 2. make sure we don't dereference a NULL cap_devices[0].head (test: cat serge@root@abab > /dev/capuse) 3. don't let strlen dereference a NULL target_user etc (test: echo ab > /dev/capuse) 4. Don't leak a bunch of memory in cap_write(). Note that technically node_ptr is not needed for the capuse write case. As a result I have a much more extensive patch splitting up cap_write(), but I thought a smaller patch that is easier to test and verify would be a better start. To test: cnt=0 while [ 1 ]; do echo /etc/mime.types > /dev/capuse if [ $((cnt%25)) -eq 0 ]; then head -2 /proc/meminfo fi cnt=$((cnt+1)) sleep 0.3 done Without this patch, it MemFree steadily drops. With the patch, it does not. I have *not* tested this driver (with or without these patches) with factotum or anything - only using the tests described above. Signed-off-by:
Serge E. Hallyn <serue@us.ibm.com> Signed-off-by:
-
David Rowe authored
I have just had a bug fix submitted for Oslec which I have applied to Oslec SVN. The bug can potentially stops the echo canceller adapting after a few seconds, although it hasn't caused many problems in practice. Signed-off-by:
David Rowe <david@rowetel.com> Signed-off-by:
-
Andre Lopes authored
Remove incorrect MODULE_PARM_DESC newline. Signed-off-by:
Andrew Morton <akpm@linux-foundation.org> Signed-off-by:
-
Roel Kluin authored
Fix &&/|| typo Signed-off-by:
Roel Kluin <roel.kluin@gmail.com> Signed-off-by:
-
Julia Lawall authored
Correct priority problem in the use of ! and &. The semantic patch that makes this change is as follows: (http://www.emn.fr/x-info/coccinelle/) // <smpl> @@ expression E; constant C; @@ - !E & C + !(E & C) // </smpl> Signed-off-by:
Julia Lawall <julia@diku.dk> Signed-off-by:
-
Greg Kroah-Hartman authored
This fixes some build warnings in the rtl8192su driver. Signed-off-by: -
Jerry Chuang authored
Driver from Realtek for the Realtek RTL8192 USB wifi device Based on the r8187 driver from Andrea Merello <andreamrl@tiscali.it> and others. Signed-off-by: -
Greg Kroah-Hartman authored
This fixes some build warnings in the cpc-usb driver. Signed-off-by: -
Alexander Beregalov authored
Fix this warnings: cpc-usb_drv.c:478: warning: format '%d' expects type 'int', but argument 4 has type 'size_t' cpc-usb_drv.c:1034: warning: format '%d' expects type 'int', but argument 3 has type 'long unsigned int' Signed-off-by:
Alexander Beregalov <a.beregalov@gmail.com> Signed-off-by:
-
Alexander Beregalov authored
Fix this build error when PROC_FS is not enabled: cpc-usb_drv.c:61:2: error: #error "PROCFS needed" cpc-usb_drv.c:1159: error: implicit declaration of function 'proc_mkdir' Signed-off-by:
-
Julia Lawall authored
Since card must already be non-NULL, it seems that what was intended was to test the result of kmalloc. The semantic patch that makes this change is as follows: (http://www.emn.fr/x-info/coccinelle/) // <smpl> @@ expression E,E1; identifier f,fld,fld1; statement S1,S2; @@ E->fld = f(...); ... when != E = E1 when != E->fld1 = E1 if ( - E + E->fld == NULL) S1 else S2 // </smpl> Signed-off-by:
-
Greg Kroah-Hartman authored
List what needs to be done to get this driver merged into the main part of the kernel tree. Cc: Sebastian Haas <haas@ems-wuensche.com> Signed-off-by: -
Greg Kroah-Hartman authored
This fixes most of the coding style issues in sja2m16c.h Cc: Sebastian Haas <haas@ems-wuensche.com> Signed-off-by: -
Greg Kroah-Hartman authored
This resolves the checkpatch errors in cpc-usb_drv.c Cc: Sebastian Haas <haas@ems-wuensche.com> Signed-off-by: -
Greg Kroah-Hartman authored
This adds the cpc-usb driver to the kernel build Cc: Sebastian Haas <haas@ems-wuensche.com> Signed-off-by: -
Greg Kroah-Hartman authored
It will now build properly on the latest kernel tree. Cc: Sebastian Haas <haas@ems-wuensche.com> Signed-off-by: -
Sebastian Haas authored
This is a CPC CAN USB driver. Just some comments: cpcusb.h and cpc-usb_drv.c: Essential driver source code sja2m16c_2.c: Helper for converting bitrate timings cpc.h: Structures and definition needed to communicate with the device From: Sebastian Haas <haas@ems-wuensche.com> Signed-off-by: -
Oleg Nesterov authored
Not sure this patch is really needed since kernel_thread() is deprecated (and checkpatch.pl complains). But we should not use kernel_thread(CLONE_SIGHAND) if we are going to play with signals. Signed-off-by:
Oleg Nesterov <oleg@redhat.com> Signed-off-by:
-
Greg Kroah-Hartman authored
Wrap all ANDROID config items with a #if to keep from asking if you want specific Android drivers even if you say N to CONFIG_ANDROID Signed-off-by: -
Greg Kroah-Hartman authored
This cleans up the majority of the checkpatch warnings in the android binder driver. All that is left now is a bunch of too-long-line stuff. Cc: San Mehat <san@android.com> Cc: Arve Hjønnevåg <arve@android.com> Cc: David Rientjes <rientjes@google.com> Signed-off-by:
-
