- 17 Nov, 2005 40 commits
-
-
James Bottomley authored
Fix our interrupts not to use smp_call_function On K and D class smp, the generic code calls this under an irq spinlock, which causes the WARN_ON() message in smp_call_function() (and is also illegal because it could deadlock). The fix is to use a new scheme based on the IPI_NOP. Signed-off-by:
James Bottomley <jejb@parisc-linux.org> Signed-off-by:
Kyle McMartin <kyle@parisc-linux.org>
-
Grant Grundler authored
Disable nesting of interrupts - still has holes The offending sequence starts out like this: 1) take external interrupt 2) set_eiem() to only allow TIMER_IRQ; local interrupts still disabled 3) read the EIRR to get a "list" of pending interrupts 4) clear EIRR of pending interrupts we intend to handle 5) call __do_IRQ() to handle IRQ. 6) handle_IRQ_event() enables local interrupts (I-Bit) 7) take a timer interrupt 8) read EIRR to get a new list of pending interrupts 9) clear EIRR of pending interrupts we just read 10) handle pending interrupts found in (8) 11) set_eiem(cpu_eiem) and return [ TROUBLE! all enabled CPU IRQs are unmasked. } 12) handle remaining interrupts pending from (3) e.g. call __do_IRQ() -> handle_IRQ_event()..etc [ TROUBLE! call to handle_IRQ_event() can now enable *any* IRQ. } 13) set_eiem(cpu_eiem) and return The problem is we now get into ugly race conditions with Timer and IPI interrupts at this point. I'm not exactly sure what happens when things go wrong (perhaps nest calls to IPI or timer interrupt?). But I'm certain it's not good. This sequence will break sooner if (10) would accidentally leave interrupts enabled. I'm pretty sure the right answer is now to make cpu_eiem a per CPU variable since all external interrupts on parisc are per CPU. This means we will NOT need to send an IPI to every CPU in the system when enabling or disabling an IRQ since only one CPU needs to change it's EIEM. Thanks to James Bottomley for (once again) pointing out the problem. Signed-off-by:Grant Grundler <grundler@parisc-linux.org> Signed-off-by:
-
James Bottomley authored
Fix a longstanding smp bug The problem is that both the timer and ipi interrupts are being called with interrupts enabled, which isn't what anyone is expecting. The IPI issue has just started to show up by causing a BUG_ON in the slab debugging code. The timer issue never shows up because there's an eiem work around in our irq.c The fix is to label both these as SA_INTERRUPT which causes the generic irq code not to enable interrupts. I also suspect the smp_call_function timeouts we're seeing might be connected with the fact that we disable IPIs when handling any other type of interrupt. I've put a WARN_ON in the code for executing smp_call_function() with IPIs disabled. Signed-off-by:
-
Jens Axboe authored
We must reassign z before looping through the zones kicking kswapd, since it will be NULL if we hit an OOM condition and jump back to the beginning again. 'z' is initially assigned before the restart: label. So move the restart label up a little. Signed-off-by:Jens Axboe <axboe@suse.de>
-
Greg Kroah-Hartman authored
Signed-off-by:
Greg Kroah-Hartman <gregkh@suse.de> Signed-off-by:
Linus Torvalds <torvalds@osdl.org>
-
Greg Kroah-Hartman authored
It was causing too many problems, and this is not the proper type of driver for this device. Signed-off-by:
-
Greg Kroah-Hartman authored
This lets us remove a lot of code in the drivers that were all checking the same thing. It also found some bugs in a few of the drivers, which has been fixed up. Signed-off-by:
-
Richard Purdie authored
Fix an error in the OHCI lh7a404 driver after the platform device conversion. Signed-off-by:
Richard Purdie <rpurdie@rpsys.net> Signed-off-by:
-
Antti Andreimann authored
This small patch adds a device ID used by older Maxtor OneTouch drives (the ones with blue face-plate instead of the fancy silver one used in newer models). The button on those drives works well with the current driver. From: Antti Andreimann <Antti.Andreimann@mail.ee> Signed-off-by:
-
Andrew Morton authored
drivers/usb/core/devio.c: In function `proc_ioctl_compat': drivers/usb/core/devio.c:1401: warning: passing arg 1 of `compat_ptr' makes integer from pointer without a cast Signed-off-by:
Andrew Morton <akpm@osdl.org> Signed-off-by:
-
Herbert Xu authored
this patch from Herbert Xu fixes a race by moving termination of the URBs into close() exclusively. Signed-off-by:
Herbert Xu <herbert@gondor.apana.org.au> Signed-off-by:
Oliver Neukum <oliver@neukum.name> Signed-off-by:
-
Daniel Drake authored
Peter Favrholdt reported that his Kodak flash device was getting detected as a CDROM, and he helped me track this down to the fact that the device takes a long time (approx 440ms!) to reset. This patch increases the delay to 500ms, which solves the problem. Signed-off-by:
Daniel Drake <dsd@gentoo.org> Signed-off-by:
-
Oliver Neukum authored
the scsi layer now uses very short sg lists. This breaks the microtek driver. Here is a patch fixes this and some other issues. Signed-off-by:
-
Luiz Fernando Capitulino authored
Updates pl2303_update_line_status() to handle X75 and SX1 Siemens mobiles Signed-off-by:
Luiz Capitulino <lcapitulino@mandriva.com.br> Signed-off-by:
-
Luiz Fernando Capitulino authored
This patch adds two new Siemens mobiles IDs for the pl2303 driver. Signed-off-by:
-
David Brownell authored
The onetouch support doesn't suspend correctly (leaves an interrupt URB posted, instead of unlinking it) so for now just disable it when PM is in the air. Signed-off-by:
David Brownell <dbrownell@users.sourceforge.net> Signed-off-by:
-
Josef Balatka authored
Jablotron usb serial interface identification Signed-off-by:
Josef Balatka <balatka@email.cz> Signed-off-by:
-
Pavel Machek authored
I actually have this device, and kernel reports blacklist entry is no longer neccessary. Signed-off-by:
Pavel Machek <pavel@suse.cz> Signed-off-by:
-
Andrew Morton authored
drivers/usb/core/devio.c: In function `proc_ioctl_compat': drivers/usb/core/devio.c:1401: warning: passing arg 1 of `compat_ptr' makes integer from pointer without a cast NFI if this is correct... Cc: Pete Zaitcev <zaitcev@redhat.com> Signed-off-by:
-
OGAWA Hirofumi authored
Signed-off-by:
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp> Signed-off-by:
-
Marcel Holtmann authored
This patch deletes the bluetooth.txt help file of the bluetty driver and hands over its major device nodes for character devices to the RFCOMM TTY implementation of the Bluetooth subsystem. Signed-off-by:
Marcel Holtmann <marcel@holtmann.org> Signed-off-by:
-
Dmitry Torokhov authored
USB: fix 'unused variable' warning Signed-off-by:
Dmitry Torokhov <dtor@mail.ru> Signed-off-by:
-
Ping Cheng authored
This patch adds support for Graphire4, Cintiq 710, Intuos3 6x11, etc. and report Device IDs. Signed-off-by:
Ping Cheng <pingc@wacom.com> Signed-off-by:
-
Ping Cheng authored
This patch adds support for Graphire4, Cintiq 710, Intuos3 6x11, etc. Signed-off-by:
-
Greg Kroah-Hartman authored
People are complaining about a .old file in the tree. So rename drivers/usb/serial/ChangeLog.old to ChangeLog.history. Signed-off-by:
-
Greg Kroah-Hartman authored
Signed-off-by:
-
Deepak Saxena authored
Platform device conversion missed a couple of spots. Signed-off-by:
Deepak Saxena <dsaxena@plexity.net> Signed-off-by:
-
-
Linus Torvalds authored
The second __const_sigaddset() should have been a sigdelset.. Compile trouble noted by Greg K-H. Signed-off-by: -
Linus Torvalds authored
-
Linus Torvalds authored
-
Linus Torvalds authored
-
Constantine Gavrilov authored
Due to incomplete memory constraints, gcc would miscompile code with sigaddset on i386 if sig arg was const. A quote form Jakub to make the issue clear: "You need either __asm__("btsl %1,%0" : "+m"(*set) : "Ir"(_sig-1) : "cc"); or __asm__("btsl %1,%0" : "=m"(*set) : "Ir"(_sig-1), "m"(*set) : "cc"); because the btsl instruction doesn't just set the memory to some value, but needs to read its previous content as well. If you don't tell that fact to GCC, GCC is of course free to optimize as if the asm was just setting the value and not depended on the previous value." Signed-off-by: -
Zhu Yi authored
This fixes a slab corruption issue in the ipw2200 driver: it essentially multiplied the error log number _twice_ by the size of the error element entry (once explicitly in the code, and once implicitly as part of the regular pointer arithmetic). Cc: Henrik Brix Andersen <brix@gentoo.org> Cc: Bernard Blackham <bernard@blackham.com.au> Cc: Zilvinas Valinskas <zilvinas@gemtek.lt> Cc: Pekka Enberg <penberg@cs.helsinki.fi> Signed-off-by:
Zhu Yi <yi.zhu@intel.com> Signed-off-by:
-
Pekka Enberg authored
The function ipw_request_direct_scan() should bail out when the device is down. This fixes a lockup caused by wpa_supplicant triggering ipw_request_direct_scan() while the driver was in a middle of a reset due to firmware errors. Thanks to Zilvinas Valinskas for reporting the bug and helping me debug it. Signed-off-by:
Pekka Enberg <penberg@cs.helsinki.fi> Acked-by:
-
Ralf Baechle authored
Signed-off-by:Ralf Baechle <ralf@linux-mips.org>
-
Ralf Baechle authored
Signed-off-by: -
Ralf Baechle authored
Signed-off-by: -
Ralf Baechle authored
There is no definition for seadint_init() and the unprotected prototype breaks compilation of assembler files. Signed-off-by: -
Ralf Baechle authored
Signed-off-by:
-
