1. 18 Feb, 2013 7 commits
    • Ilan Peer's avatar
      iwlwifi: mvm: Set the scan type according to the vif type · d91b06d2
      Ilan Peer authored
      The FW can differentiate between scans, according to the interface
      type on which the scan was issues. Supply the interfaces type
      information to the FW.
      Signed-off-by: default avatarIlan Peer <ilan.peer@intel.com>
      Signed-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
      d91b06d2
    • Johannes Berg's avatar
      iwlwifi: mvm: fix time event command handling race · e3722822
      Johannes Berg authored
      Occasionally, we would run into this warning:
      
        iwlwifi 0000:02:00.0: U iwl_mvm_protect_session extend 0x2601: only 200 ms left
        iwlwifi 0000:02:00.0: U iwl_mvm_remove_time_event Removing TE 0x2601
        iwlwifi 0000:02:00.0: I iwl_pcie_enqueue_hcmd Sending command TIME_EVENT_CMD (#29), seq: 0x0925, 60 bytes at 37[5]:9
        iwlwifi 0000:02:00.0: U iwl_pcie_send_hcmd_sync Attempting to send sync command TIME_EVENT_CMD
        iwlwifi 0000:02:00.0: U iwl_pcie_send_hcmd_sync Setting HCMD_ACTIVE for command TIME_EVENT_CMD
        iwlwifi 0000:02:00.0: I iwl_pcie_enqueue_hcmd Sending command TIME_EVENT_CMD (#29), seq: 0x0926, 60 bytes at 38[6]:9
        iwlwifi 0000:02:00.0: U iwl_mvm_time_event_response TIME_EVENT_CMD response - UID = 0x2601
        iwlwifi 0000:02:00.0: I iwl_pcie_hcmd_complete Clearing HCMD_ACTIVE for command TIME_EVENT_CMD
        iwlwifi 0000:02:00.0: U iwl_mvm_rx_time_event_notif Time event notification - UID = 0x2701 action 1
        wlan0: associate with 00:0a:b8:55:a8:30 (try 2/3)
        ------------[ cut here ]------------
        WARNING: at drivers/net/wireless/iwlwifi/mvm/time-event.c:269 iwl_mvm_time_event_send_add+0x163/0x1a0 [iwlmvm]()
        Modules linked in: [...]
        Call Trace:
         [<c1046e42>] warn_slowpath_common+0x72/0xa0
         [<c1046e92>] warn_slowpath_null+0x22/0x30
         [<f8cad913>] iwl_mvm_time_event_send_add+0x163/0x1a0 [iwlmvm]
         [<f8cadead>] iwl_mvm_protect_session+0xcd/0x1c0 [iwlmvm]
         [<f8ca2087>] iwl_mvm_mac_mgd_prepare_tx+0x67/0xa0 [iwlmvm]
         [<f882a130>] ieee80211_sta_work+0x8f0/0x1070 [mac80211]
      
      The reason is a problem with asynchronous vs. synchronous
      commands, what happens here is the following:
       * TE 0x2601 is removed, the TIME_EVENT_CMD for that is async
       * a new TE (will be 0x2701) is created, the TIME_EVENT_CMD
         for that is sync and also uses a notification wait for the
         response (to avoid another race condition)
       * the response for the TE 0x2601 removal comes from the
         firmware, and is handled by the notification wait handler
         that's really waiting for the second response, but can't
         tell the difference, we therefore see the message
         "TIME_EVENT_CMD response - UID = 0x2601" instead of
         "TIME_EVENT_CMD response - UID = 0x2701".
      
      Fix this issue by making the TE removal synchronous as well,
      this means that we wait for the response to that command
      first, before there's any chance of sending a new one.
      
      Also, to detect such issues more easily in the future, add
      a warning to the notification handler that detects them.
      Reviewed-by: default avatarEmmanuel Grumbach <emmanuel.grumbach@intel.com>
      Signed-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
      e3722822
    • Johannes Berg's avatar
      iwlwifi: mvm: add debug statement to time event add · 93630dc3
      Johannes Berg authored
      This is helpful for debugging the time event warning,
      but also in general to see what's going on.
      Reviewed-by: default avatarEmmanuel Grumbach <emmanuel.grumbach@intel.com>
      Signed-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
      93630dc3
    • Johannes Berg's avatar
      iwlwifi: mvm: fix GO powersave client manipulation · 9cc40712
      Johannes Berg authored
      All station commands must include a valid MAC ID,
      the ID 0 is randomly valid in some cases, but we
      must set the ID properly. Do that by passing the
      right station and using its mac_id_n_color.
      Reviewed-by: default avatarEmmanuel Grumbach <emmanuel.grumbach@intel.com>
      Signed-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
      9cc40712
    • Johannes Berg's avatar
      iwlwifi: mvm: program DTIM timings properly · d2931bbd
      Johannes Berg authored
      For the firmware to know when DTIM beacons arrive
      we have to program the DTIM time in TSF and system
      time in the MAC context. Since mac80211 now tracks
      the different times (on demand), this becomes easy.
      Reviewed-by: default avatarEmmanuel Grumbach <emmanuel.grumbach@intel.com>
      Signed-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
      d2931bbd
    • Johannes Berg's avatar
      iwlwifi: mvm: fix merge error · b18bf973
      Johannes Berg authored
      The iwlwifi-next tree removed IEEE80211_HW_NEED_DTIM_BEFORE_ASSOC
      while the mac80211-next tree removed
      Signed-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
      b18bf973
    • Johannes Berg's avatar
  2. 15 Feb, 2013 33 commits