1. 06 Feb, 2012 1 commit
  2. 01 Feb, 2012 3 commits
  3. 31 Jan, 2012 3 commits
  4. 30 Jan, 2012 1 commit
  5. 27 Jan, 2012 1 commit
  6. 26 Jan, 2012 1 commit
  7. 25 Jan, 2012 5 commits
  8. 24 Jan, 2012 1 commit
    • Jesper Juhl's avatar
      ASoC: wm2000: Fix use-after-free - don't release_firmware() twice on error · c83f1d7e
      Jesper Juhl authored
      In wm2000_i2c_probe(), if we take the true branch in
      
      "
        ret = snd_soc_register_codec(&i2c->dev, &soc_codec_dev_wm2000,
                                     NULL, 0);
        if (ret != 0)
                goto err_fw;
      "
      
      then we'll release_firmware(fw) at the 'err_fw' label. But we've already
      done that just a few lines above. That's a use-after-free bug.
      
      This patch restructures the code so that we always call
      release_firmware(fw) before leaving the function, but only ever call
      it once.
      This means that we have to initialize 'fw' to NULL since some paths
      may now end up calling it without having called request_firmware(),
      but since request_firmware() deals gracefully with NULL pointers, we
      are fine if we just NULL initialize it.
      Signed-off-by: default avatarJesper Juhl <jj@chaosbits.net>
      Signed-off-by: default avatarMark Brown <broonie@opensource.wolfsonmicro.com>
      c83f1d7e
  9. 23 Jan, 2012 1 commit
  10. 22 Jan, 2012 1 commit
  11. 20 Jan, 2012 7 commits
  12. 19 Jan, 2012 15 commits