- 23 Apr, 2018 40 commits
-
-
Christian Lütke-Stetzkamp authored
Fix checkpatch errors, warnings, checks about braces: BRACES, ELSE_AFTER_BRACE, OPEN_BRACE Signed-off-by:
Christian Lütke-Stetzkamp <christian@lkamp.de> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Christian Lütke-Stetzkamp authored
Fix checkpatch error: GLOBAL_INITIALISERS Signed-off-by:
-
Christian Lütke-Stetzkamp authored
Fix checkpatch error: TRAILING_STATEMENTS Signed-off-by:
NeilBrown <neil@brown.name> Signed-off-by:
-
Christian Lütke-Stetzkamp authored
Fixes checkpatch warning: NEW_TYPEDEFS Signed-off-by:
-
Christian Lütke-Stetzkamp authored
Fix checkpatch error: POINTER_LOCATION Signed-off-by:
-
Christian Lütke-Stetzkamp authored
Fixes checkpatch errors, warnings, checks: SPACING, LEADING_SPACE, LINE_SPACING Signed-off-by:
-
Christian Lütke-Stetzkamp authored
This fixes the indentaions in the file sd.c Signed-off-by:
-
Christian Lütke-Stetzkamp authored
This fixes the indentaions in the file mt7621_sd.h Signed-off-by:
-
Christian Lütke-Stetzkamp authored
This fixes the indentaions in the file dbg.h Signed-off-by:
-
Christian Lütke-Stetzkamp authored
This fixes the indentaions in the file board.h Signed-off-by:
-
Christian Lütke-Stetzkamp authored
This fixes the indentaions in the file dbg.c Signed-off-by:
-
Christian Lütke-Stetzkamp authored
The whitespace errors in the file sd.c are fixed by using the cleanfile script. Indentations with whitespaces are not changed in this patch. Signed-off-by:
-
Christian Lütke-Stetzkamp authored
The whitespace errors in the file mt6575_sd.h are fixed by using the cleanfile script. Indentations with whitespaces are not changed in this patch. Signed-off-by:
-
Christian Lütke-Stetzkamp authored
The whitespace errors in the file dbg.h are fixed by using the cleanfile script. Indentations with whitespaces are not changed in this patch. Signed-off-by:
-
Christian Lütke-Stetzkamp authored
The whitespace errors in the file dbg.c are fixed by using the cleanfile script. Indentations with whitespaces are not changed in this patch. Signed-off-by:
-
Christian Lütke-Stetzkamp authored
The whitespace errors in the file board.h are fixed by using the cleanfile script. Indentations with whitespaces are not changed in this patch. Signed-off-by:
-
Sergio Paracuellos authored
This commit replaces some bare unsigned definitions in some function parameters in favour of 'unsigned int' which is preferred. This also fix checkpatch warnings about this. Signed-off-by:
Sergio Paracuellos <sergio.paracuellos@gmail.com> Reviewed-by:
-
NeilBrown authored
The mt7621-pci support 3 pci devices and has 3 interrupts. Each of these need to be enabled by the same sort of hack to map hwirq number to virq number. This is a hack which will go as soon as I understand how this is supposed to work. Signed-off-by:
-
Chris Coffey authored
This fixes the following sparse warning: drivers/staging/mt7621-eth/ethtool.c:213:6: warning: symbol 'mtk_set_ethtool_ops' was not declared. Should it be static? Signed-off-by:
Chris Coffey <cmc@babblebit.net> Reviewed-by:
-
Danilo Alves authored
This patch corrects the function definition style of CARDvSafeResetRx. Issue found by checkpatch. CHECK: Lines should not end with a '(' Signed-off-by:Danilo Alves <daniloalves@riseup.net> Signed-off-by:
-
Ji-Hun Kim authored
There was no code for handling memory leaks of device_init_rings() and request_irq(). It needs to free allocated memory in the device_init_rings() , when request_irq() would be failed. Add freeing sequences of irq and device init rings. Signed-off-by:
Ji-Hun Kim <ji_hun.kim@samsung.com> Reviewed-by:
Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by:
-
Ji-Hun Kim authored
There are no null pointer checking on rd_info and td_info values which are allocated by kzalloc. It has potential null pointer dereferencing issues. Implement error handling code on device_init_rd*, device_init_td* and vnt_start for the allocation failures. Signed-off-by:
-
NeilBrown authored
Luster has a container_of0() function which is similar to container_of() but passes an IS_ERR_OR_NULL() pointer through unchanged. This could be generally useful: bcache at last has a similar function. Naming is hard, but the precedent set by hlist_entry_safe() suggests a _safe suffix might be most consistent. So add container_of_safe() to kernel.h, and replace all occurrences of container_of0() with one of - list_first_entry, list_next_entry, when that is a better fit, - container_of(), when the pointer is used as a validpointer in surrounding code, - container_of_safe() when there is no obviously better alternative. Signed-off-by:NeilBrown <neilb@suse.com> Reviewed-by:
James Simmons <jsimmons@infradead.org> Signed-off-by:
-
NeilBrown authored
Currently the code for cpu-partition tables lives in various places. The non-SMP code is partly in libcfs/libcfs_cpu.h as static inlines, and partly in lnet/libcfs/libcfs_cpu.c - some of the functions are tiny and could well be inlines. The SMP code is all in lnet/libcfs/linux/linux-cpu.c. This patch moves all the trivial non-SMP functions into libcfs_cpu.h as inlines, and all the SMP functions into libcfs_cpu.c with the non-trival !SMP code. Now when you go looking for some function, it is easier to find both versions together when neither is trivial. There is no code change here - just code movement. Signed-off-by:
-
NeilBrown authored
This include file contains definitions used when CONFIG_SMP is in effect. Other includes contain corresponding definitions for when it isn't. This can be hard to follow, so move the definitions to the one place. As HAVE_LIBCFS_CPT is defined precisely when CONFIG_SMP, we discard that macro and just use CONFIG_SMP when needed. Signed-off-by:
-
NeilBrown authored
As this is indexed by an integer, an extensible array or extensible bitmap would be better. If/when xarray lands, we should change to use that. For now, just a simple conversion to rhashtable. When removing an entry, we need to hold rcu_read_lock() across the lookup and remove in case we race with another thread performing a removal. This means we need to use call_rcu() to free the quota info so we need an rcu_head in there, which unfortunately doubles the size of the structure. Signed-off-by:
-
NeilBrown authored
The rhashtable data type is a perfect fit for the export uuid hash table, so use that instead of cfs_hash (which will eventually be removed). As rhashtable supports lookups and insertions in atomic context, there is no need to drop a spinlock while inserting a new entry, which simplifies code quite a bit. As there are no simple lookups on this hash table (only insertions which might fail and take a spinlock), there is no need to use rcu to free the exports. Signed-off-by:
-
NeilBrown authored
The pools hashtable can be implemented using the rhashtable implementation in lib. This has the benefit that lookups are lock-free. We need to use kfree_rcu() to free a pool so that a lookup racing with a deletion will not access freed memory. rhashtable has no combined lookup-and-delete interface, but as the lookup is lockless and the chains are short, this brings little cost. Even if a lookup finds a pool, we must be prepared for the delete to fail to find it, as we might race with another thread doing a delete. We use atomic_inc_not_zero() after finding a pool in the hash table and if that fails, we must have raced with a deletion, so we treat the lookup as a failure. Use hashlen_string() rather than a hand-crafted hash function. Note that the pool_name, and the search key, are guaranteed to be nul terminated. Signed-off-by:
-
NeilBrown authored
Linux has a resizeable hashtable implementation in lib, so we should use that instead of having one in libcfs. This patch converts the ptlrpc conn_hash to use rhashtable. In the process we gain lockless lookup. As connections are never deleted until the hash table is destroyed, there is no need to count the reference in the hash table. There is also no need to enable automatic_shrinking. Signed-off-by:
-
NeilBrown authored
This include file is only included in one place, and only contains a list of other include directives. So just move all those to the place where this file is included, and discard the file. One include directive uses a local name ("linux-cpu.h"), so that needs to be given a proper path. Probably many of these should be remove from here, and moved to just the files that need them. Signed-off-by: -
NeilBrown authored
CDEBUG_STACK() and CHECK_STACK() are macros to help with debugging, so move them from drivers/staging/lustre/include/linux/libcfs/linux/libcfs.h to drivers/staging/lustre/include/linux/libcfs/libcfs_debug.h This seems a more fitting location, and is a step towards removing linux/libcfs.h and simplifying the include file structure. Signed-off-by:
-
James Simmons authored
In ll_xattr_set_common() detect the removexattr() case correctly by testing for a NULL value as well as XATTR_REPLACE. Signed-off-by:
John L. Hammond <john.hammond@intel.com> Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-10787 Reviewed-on: https://review.whamcloud.com/Reviewed-by:
Dmitry Eremin <dmitry.eremin@intel.com> Reviewed-by:
James Simmons <uja.ornl@yahoo.com> Signed-off-by:
-
John L. Hammond authored
If struct xattr_handler has a name member then use it (rather than prefix) for the ACL xattrs. This avoids a bug where ACL operations failed for some kernels. Signed-off-by:
-
James Simmons authored
Small style changes to match more the kernel code standard and it make it more readable. Signed-off-by:
Bob Glossman <bob.glossman@intel.com> Reviewed-by:
Sebastien Buisson <sbuisson@ddn.com> Reviewed-by:
Oleg Drokin <oleg.drokin@intel.com> Signed-off-by:
-
James Simmons authored
Add proper punctuation to the comments. Change buf_size to size for comment in ll_listxattr() since buf_size doesn't exit which will confuse someone reading the code. Signed-off-by:
-
James Simmons authored
Convert __uXX types to uXX types since this is kernel code. The function ll_lov_user_md_size() returns ssize_t so change lum_size from int to ssize_t. Signed-off-by:
-
James Simmons authored
Having an extra ifdef makes the code harder to read. For the case of ll_xattr_get_common() we have a variable initialized at the start of the function but it is only used in XATTR_ACL_ACCESS_T code block. Lets move that variable to that location since its only used there and make the code look cleaner. Signed-off-by:
-
James Simmons authored
Keep track of attempted deletions as well as changing of the lma/link xattrs. Signed-off-by:
-
James Simmons authored
In creating the full name of a xattr a new line was added that was seen by the remote MDS server which confused it. Remove the newline. Signed-off-by:
-
James Simmons authored
The size check at the start of ll_setstripe_ea() is only valid for a directory. Move that check to the section of code handling the S_ISDIR case. Signed-off-by:
-
