1. 17 Apr, 2008 40 commits
    • Mark Lord's avatar
      sata_mv add basic port multiplier support · e49856d8
      Mark Lord authored
      Add basic port-multiplier support to sata_mv.
      This works in Command-based-switching mode for Gen-II chipsets,
      and in FIS-based-switching mode for Gen-IIe chipsets.
      
      Error handling remains at the primary port level for now
      (works okay, but not great).  This will get fixed in a subsequent
      patch series for IRQ/EH handling fixes.  There are also some
      known NCQ/PMP errata to be dealt with in the near future,
      once we have this basic PMP support in place.
      Signed-off-by: default avatarMark Lord <mlord@pobox.com>
      Signed-off-by: default avatarJeff Garzik <jgarzik@redhat.com>
      e49856d8
    • Mark Lord's avatar
      sata_mv fix SOC flags, enable NCQ on SOC · 02c1f32f
      Mark Lord authored
      The System-On-Chip (SOC) core supports all of the same
      features as the other recent Marvell chips,
      including NCQ and IRQ coalescing.
      
      Fix the chip_soc flags to enable these capabilities
      (note that the driver currently does nothing special
      for IRQ coalescing, though).
      Signed-off-by: default avatarMark Lord <mlord@pobox.com>
      Signed-off-by: default avatarJeff Garzik <jgarzik@redhat.com>
      02c1f32f
    • Mark Lord's avatar
      sata_mv disable hotplug for now · 40f0bc2d
      Mark Lord authored
      Disable hot plug/unplug detection in sata_mv for now.
      It is currently broken, and also interferes with PMP support.
      
      This will get fixed in a subsequent patch series.
      Signed-off-by: default avatarMark Lord <mlord@pobox.com>
      Signed-off-by: default avatarJeff Garzik <jgarzik@redhat.com>
      40f0bc2d
    • Mark Lord's avatar
      sata_mv cosmetics · 17c5aab5
      Mark Lord authored
      More cosmetic cleanups to unclutter the changes needed for PMP support.
      Signed-off-by: default avatarMark Lord <mlord@pobox.com>
      Signed-off-by: default avatarJeff Garzik <jgarzik@redhat.com>
      17c5aab5
    • Mark Lord's avatar
      sata_mv hardreset rework · 0d8be5cb
      Mark Lord authored
      Rework and simplify sata_mv's hardreset code to take advantage of
      libata improvements since it was first coded.
      
      Also, get rid of the now unnecessary prereset, postreset, and phy_reset
      functions.
      
      This patch also paves the way for subsequent pmp support patches,
      which will follow once this one passes muster.
      Signed-off-by: default avatarMark Lord <mlord@pobox.com>
      Signed-off-by: default avatarJeff Garzik <jgarzik@redhat.com>
      0d8be5cb
    • Jeff Garzik's avatar
    • Tejun Heo's avatar
      libata: make EH fail gracefully if no reset method is available · 4f7faa3f
      Tejun Heo authored
      When no reset method is available, libata currently oopses.  Although
      the condition can't happen unless there's a bug in a low level driver,
      oopsing isn't the best way to report the error condition.  Complain,
      dump stack and fail reset instead.
      Signed-off-by: default avatarTejun Heo <htejun@gmail.com>
      Signed-off-by: default avatarJeff Garzik <jgarzik@redhat.com>
      4f7faa3f
    • Alan Cox's avatar
      libata: Be a bit more slack about early devices · b93fda12
      Alan Cox authored
      We have a certain number of 'ATA' emulations often on CF or other flash
      devices that are at best "loosely based" on the CF 1.1 standard. These
      devices report themselves as disk but don't support the ATA minimal
      command set only the CF 1.1 set.
      
      Relax the PIO checking for devices reporting ATA rev 0, or no iordy
      support, or CFA. Rework the code a bit as it was already messy and this
      made it quite ugly.
      Signed-off-by: default avatarAlan Cox <alan@redhat.com>
      Signed-off-by: default avatarJeff Garzik <jgarzik@redhat.com>
      b93fda12
    • Alan Cox's avatar
      libata: cable logic · f792068e
      Alan Cox authored
      The cable detect isolation patch inadvertently removed 40 wire short
      cable handling. Put it back
      Signed-off-by: default avatarAlan Cox <alan@redhat.com>
      Signed-off-by: default avatarJeff Garzik <jgarzik@redhat.com>
      f792068e
    • Tejun Heo's avatar
      libata: move link onlineness check out of softreset methods · 45db2f6c
      Tejun Heo authored
      Currently, SATA softresets should do link onlineness check before
      actually performing SRST protocol but it doesn't really belong to
      softreset.
      
      This patch moves onlineness check in softreset to ata_eh_reset() and
      ata_eh_followup_srst_needed() to clean up code and help future sata_mv
      changes which need clear separation between SCR and TF accesses.
      
      sata_fsl is peculiar in that its softreset really isn't softreset but
      combination of hardreset and softreset.  This patch adds dummy private
      ->prereset to keep the current behavior but the driver really should
      implement separate hard and soft resets and return -EAGAIN from
      hardreset if it should be follwed by softreset.
      Signed-off-by: default avatarTejun Heo <htejun@gmail.com>
      Signed-off-by: default avatarJeff Garzik <jgarzik@redhat.com>
      45db2f6c
    • Tejun Heo's avatar
      libata: kill dead code paths in reset path · 2a0c15ca
      Tejun Heo authored
      Some code paths which had been made obsolete by recent reset
      simplification were still around.  Kill them.
      
      * ata_eh_reset() checked for ATA_DEV_UNKNOWN to determine
        classification failure.  This is no longer applicable.
      
      * ata_do_reset() should convert ATA_DEV_UNKNOWN to ATA_DEV_NONE
        regardless of reset result (e.g. -EAGAIN).
      
      * LLDs don't need to convert ATA_DEV_UNKNOWN to ATA_DEV_NONE.
      Signed-off-by: default avatarTejun Heo <htejun@gmail.com>
      Signed-off-by: default avatarJeff Garzik <jgarzik@redhat.com>
      2a0c15ca
    • Stephen Rothwell's avatar
      pata_scc: fix build breakage · e50e3ce5
      Stephen Rothwell authored
      drivers/ata/pata_scc.c: In function 'scc_bus_softreset':
      drivers/ata/pata_scc.c:594: error: 'deadlien' undeclared (first use in this function)
      drivers/ata/pata_scc.c:594: error: (Each undeclared identifier is reported only once
      drivers/ata/pata_scc.c:594: error: for each function it appears in.)
      Signed-off-by: default avatarStephen Rothwell <sfr@canb.auug.org.au>
      Signed-off-by: default avatarJeff Garzik <jeff@garzik.org>
      e50e3ce5
    • Tejun Heo's avatar
      libata: make PMP support optional · 88fcd562
      Tejun Heo authored
      Make PMP support optional by adding CONFIG_SATA_PMP and leaving out
      libata-pmp.c if it isn't set.  PMP helpers return constant values if
      PMP support is not enabled and PMP declarations alias non-PMP
      counterparts.  This makes the compiler to leave out PMP related part
      out and LLDs to use non-PMP counterparts automatically.
      Signed-off-by: default avatarTejun Heo <htejun@gmail.com>
      88fcd562
    • Tejun Heo's avatar
      libata: implement PMP helpers · 071f44b1
      Tejun Heo authored
      Implement helpers to test whether PMP is supported, attached and
      determine pmp number to use when issuing SRST to a link.  While at it,
      move ata_is_host_link() so that it's together with the two new PMP
      helpers.
      
      This change simplifies LLDs and helps making PMP support optional.
      Signed-off-by: default avatarTejun Heo <htejun@gmail.com>
      071f44b1
    • Tejun Heo's avatar
      libata: separate PMP support code from core code · 48515f6c
      Tejun Heo authored
      Most of PMP support code is already in libata-pmp.c.  All that are in
      libata-core.c are sata_pmp_port_ops and EXPORTs.  Move them to
      libata-pmp.c.  Also, collect PMP related prototypes and declarations
      in header files and move them right above of SFF stuff.
      
      This change is to make PMP support optional.
      Signed-off-by: default avatarTejun Heo <htejun@gmail.com>
      48515f6c
    • Tejun Heo's avatar
      libata: make SFF support optional · 127102ae
      Tejun Heo authored
      Now that SFF support is completely separated out from the core layer,
      it can be made optional.  Add CONFIG_ATA_SFF and let SFF drivers
      depend on it.  If CONFIG_ATA_SFF isn't set, all codes in libata-sff.c
      and data structures for SFF support are disabled.  This saves good
      number of bytes for small systems.
      Signed-off-by: default avatarTejun Heo <htejun@gmail.com>
      127102ae
    • Tejun Heo's avatar
      libata: don't use ap->ioaddr in non-SFF drivers · 350756f6
      Tejun Heo authored
      ap->ioaddr is to carry addresses for TF and BMDMA registers of a SFF
      controller, don't abuse it in non-SFF controllers.
      Signed-off-by: default avatarTejun Heo <htejun@gmail.com>
      350756f6
    • Tejun Heo's avatar
      libata: clean up dummy port_ops · 182d7bba
      Tejun Heo authored
      Now that SFF assumptions are removed from core layer, dummy port_ops
      can be slimmed down.  Chop it down.
      Signed-off-by: default avatarTejun Heo <htejun@gmail.com>
      182d7bba
    • Tejun Heo's avatar
      libata: kill ata_noop_dev_select() · c9f75b04
      Tejun Heo authored
      Now that SFF assumptions are separated out from non-SFF reset
      sequence, port_ops->sff_dev_select() is no longer necessary for
      non-SFF controllers.  Kill ata_noop_dev_select() and ->sff_dev_select
      initialization from base and other non-SFF port_ops.
      Signed-off-by: default avatarTejun Heo <htejun@gmail.com>
      c9f75b04
    • Tejun Heo's avatar
      libata: remove check_status from non-SFF drivers · 520d06f9
      Tejun Heo authored
      Now that all SFF stuff is separated out of core layer, core layer
      doesn't call ops->[alt_]check_status().  In fact, no one calls them
      for non-SFF drivers anymore.  Kill them.
      Signed-off-by: default avatarTejun Heo <htejun@gmail.com>
      520d06f9
    • Tejun Heo's avatar
      libata: replace tf_read with qc_fill_rtf for non-SFF drivers · 4c9bf4e7
      Tejun Heo authored
      Now that all SFF stuff is separated out of core layer, core layer
      doesn't call ops->tf_read directly.  It gets called only via
      ops->qc_fill_rtf() for non-SFF drivers.  This patch directly
      implements private ops->qc_fill_rtf() for non-SFF controllers and kill
      ops->tf_read().
      
      This is much cleaner for non-SFF controllers as some of them have to
      cache SFF register values in private data structure and report the
      cached values via ops->tf_read().  Also, ops->tf_read() gets nasty for
      controllers which don't have clear notion of TF registers when
      operation is not in progress.
      
      As this change makes default ops->qc_fill_rtf unnecessary, move
      ata_sff_qc_fill_rtf() form ata_base_port_ops to ata_sff_port_ops where
      it belongs.
      Signed-off-by: default avatarTejun Heo <htejun@gmail.com>
      4c9bf4e7
    • Tejun Heo's avatar
      libata: drop @finish_qc from ata_qc_complete_multiple() · 79f97dad
      Tejun Heo authored
      ata_qc_complete_multiple() took @finish_qc and called it on every qc
      before completing it.  This was to give opportunity to update TF cache
      before ata_qc_complete() tries to fill result_tf.  Now that result TF
      is a separate operation, this is no longer necessary.
      
      Update sata_sil24, which was the only user of this mechanism, such
      that it implements its own ops->qc_fill_rtf() and drop @finish_qc from
      ata_qc_complete_multiple().
      Signed-off-by: default avatarTejun Heo <htejun@gmail.com>
      79f97dad
    • Tejun Heo's avatar
      libata: add qc_fill_rtf port operation · 22183bf5
      Tejun Heo authored
      On command completion, ata_qc_complete() directly called ops->tf_read
      to fill qc->result_tf.  This patch adds ops->qc_fill_rtf to replace
      hardcoded ops->tf_read usage.
      
      ata_sff_qc_fill_rtf() which uses ops->tf_read to fill result_tf is
      implemented and set in ata_base_port_ops and other ops tables which
      don't inherit from ata_base_port_ops, so this patch doesn't introduce
      any behavior change.
      
      ops->qc_fill_rtf() is similar to ops->sff_tf_read() but can only be
      called when a command finishes.  As some non-SFF controllers don't
      have TF registers defined unless they're associated with in-flight
      commands, this limited operation makes life easier for those drivers
      and help lifting SFF assumptions from libata core layer.
      Signed-off-by: default avatarTejun Heo <htejun@gmail.com>
      22183bf5
    • Tejun Heo's avatar
      libata: unify mechanism to request follow-up SRST · 305d2a1a
      Tejun Heo authored
      Previously, there were two ways to trigger follow-up SRST from
      hardreset method - returning -EAGAIN and leaving all device classes
      unmodified.  Drivers never used the latter mechanism and the only use
      case for the former was when hardreset couldn't classify.
      
      Drop the latter mechanism and let -EAGAIN mean "perform follow-up SRST
      if classification is required".  This change removes unnecessary
      follow-up SRSTs and simplifies reset implementations.
      Signed-off-by: default avatarTejun Heo <htejun@gmail.com>
      305d2a1a
    • Tejun Heo's avatar
      libata: move PMP SCR access failure during reset to ata_eh_reset() · 5958e302
      Tejun Heo authored
      If PMP fan-out reset fails and SCR isn't accessible, PMP should be
      reset.  This used to be tested by sata_pmp_std_hardreset() and
      communicated to EH by -ERESTART.  However, this logic is generic and
      doesn't really have much to do with specific hardreset implementation.
      
      This patch moves SCR access failure detection logic to ata_eh_reset()
      where it belongs.  As this makes sata_pmp_std_hardreset() identical to
      sata_std_hardreset(), the function is killed and replaced with the
      standard method.
      Signed-off-by: default avatarTejun Heo <htejun@gmail.com>
      5958e302
    • Tejun Heo's avatar
      libata: clear SError after link resume · ac371987
      Tejun Heo authored
      SError used to be cleared in ->postreset.  This has small hotplug race
      condition.  If a device is plugged in after reset is complete but
      postreset hasn't run yet, its hotplug event gets lost when SError is
      cleared.  This patch makes sata_link_resume() clear SError.  This
      kills the race condition and makes a lot of sense as some PMP and host
      PHYs don't work properly without SError cleared.
      
      This change makes sata_pmp_std_{pre|post}_reset()'s unnecessary as
      they become identical to ata_std counterparts.  It also simplifies
      sata_pmp_hardreset() and ahci_vt8251_hardreset().
      Signed-off-by: default avatarTejun Heo <htejun@gmail.com>
      ac371987
    • Tejun Heo's avatar
      libata: implement and use sata_std_hardreset() · 57c9efdf
      Tejun Heo authored
      Implement sata_std_hardreset(), which simply wraps around
      sata_link_hardreset().  sata_std_hardreset() becomes new standard
      hardreset method for sata_port_ops and sata_sff_hardreset() moves from
      ata_base_port_ops to ata_sff_port_ops, which is where it really
      belongs.
      
      ata_is_builtin_hardreset() is added so that both
      ata_std_error_handler() and ata_sff_error_handler() skip both builtin
      hardresets if SCR isn't accessible.
      
      piix_sidpr_hardreset() in ata_piix.c is identical to
      sata_std_hardreset() in functionality and got replaced with the
      standard function.
      Signed-off-by: default avatarTejun Heo <htejun@gmail.com>
      57c9efdf
    • Tejun Heo's avatar
      libata: move generic hardreset code from sata_sff_hardreset() to sata_link_hardreset() · 9dadd45b
      Tejun Heo authored
      sata_sff_hardreset() contains link readiness wait logic which isn't
      SFF specific.  Move that part into sata_link_hardreset(), which now
      takes two more parameters - @online and @check_ready.  Both are
      optional.  The former is out parameter for link onlineness after
      reset.  The latter is used to wait for link readiness after hardreset.
      
      Users of sata_link_hardreset() is updated to use new funtionality and
      ahci_hardreset() is updated to use sata_link_hardreset() instead of
      sata_sff_hardreset().  This doesn't really cause any behavior change.
      Signed-off-by: default avatarTejun Heo <htejun@gmail.com>
      9dadd45b
    • Tejun Heo's avatar
      ahci: use ata_wait_after_reset() instead of ata_sff_wait_ready() · a89611e8
      Tejun Heo authored
      Implement ahci_check_ready() and replace ata_sff_wait_after_reset()
      with ata_wait_after_reset().  As ahci was faking TF access, this
      change doesn't result in any functional difference.
      Signed-off-by: default avatarTejun Heo <htejun@gmail.com>
      a89611e8
    • Tejun Heo's avatar
      libata: separate out ata_wait_ready() and implement ata_wait_after_reset() · aa2731ad
      Tejun Heo authored
      Factor out waiting logic (which is common to all ATA controllers) from
      ata_sff_wait_ready() into ata_wait_ready().  ata_wait_ready() takes
      @check_ready function pointer and uses it to poll for readiness.  This
      allows non-SFF controllers to use ata_wait_ready() to wait for link
      readiness.
      
      This patch also implements ata_wait_after_reset() - generic version of
      ata_sff_wait_after_reset() - using ata_wait_ready().
      
      ata_sff_wait_ready() is reimplemented using ata_wait_ready() and
      ata_sff_check_ready().  Functionality remains the same.
      Signed-off-by: default avatarTejun Heo <htejun@gmail.com>
      aa2731ad
    • Tejun Heo's avatar
      libata: restructure SFF post-reset readiness waits · 705e76be
      Tejun Heo authored
      Previously, post-softreset readiness is waited as follows.
      
      1. ata_sff_wait_after_reset() waits for 150ms and then for
         ATA_TMOUT_FF_WAIT if status is 0xff and other conditions meet.
      
      2. ata_bus_softreset() finishes with -ENODEV if status is still 0xff.
         If not, continue to #3.
      
      3. ata_bus_post_reset() waits readiness of dev0 and/or dev1 depending
         on devmask using ata_sff_wait_ready().
      
      And for post-hardreset readiness,
      
      1. ata_sff_wait_after_reset() waits for 150ms and then for
         ATA_TMOUT_FF_WAIT if status is 0xff and other conditions meet.
      
      2. sata_sff_hardreset waits for device readiness using
         ata_sff_wait_ready().
      
      This patch merges and unifies post-reset readiness waits into
      ata_sff_wait_ready() and ata_sff_wait_after_reset().
      
      ATA_TMOUT_FF_WAIT handling is merged into ata_sff_wait_ready().  If TF
      status is 0xff, link status is unknown and the port is SATA, it will
      continue polling till ATA_TMOUT_FF_WAIT.
      
      ata_sff_wait_after_reset() is updated to perform the following steps.
      
      1. waits for 150ms.
      
      2. waits for dev0 readiness using ata_sff_wait_ready().  Note that
         this is done regardless of devmask, as ata_sff_wait_ready() handles
         0xff status correctly, this preserves the original behavior except
         that it may wait longer after softreset if link is online but
         status is 0xff.  This behavior change is very unlikely to cause any
         actual difference and is intended.  It brings softreset behavior to
         that of hardreset.
      
      3. waits for dev1 readiness just the same way ata_bus_post_reset() did.
      
      Now both soft and hard resets call ata_sff_wait_after_reset() after
      reset to wait for readiness after resets.  As
      ata_sff_wait_after_reset() contains calls to ->sff_dev_select(),
      explicit call near the end of sata_sff_hardreset() is removed.
      
      This change makes reset implementation simpler and more consistent.
      
      While at it, make the magical 150ms wait post-reset wait duration a
      constant and ata_sff_wait_ready() and ata_sff_wait_after_reset() take
      @link instead of @ap.  This is to make them consistent with other
      reset helpers and ease core changes.
      
      pata_scc is updated accordingly.
      Signed-off-by: default avatarTejun Heo <htejun@gmail.com>
      705e76be
    • Tejun Heo's avatar
      libata: separate out ata_std_postreset() from ata_sff_postreset() · 203c75b8
      Tejun Heo authored
      Separate out generic ATA portion from ata_sff_postreset() into
      ata_std_postreset() and implement ata_sff_postreset() using the std
      version.
      
      ata_base_port_ops now has ata_std_postreset() for its postreset and
      ata_sff_port_ops overrides it to ata_sff_postreset().
      
      This change affects pdc_adma, ahci, sata_fsl and sata_sil24.  pdc_adma
      now specifies postreset to ata_sff_postreset() explicitly.  sata_fsl
      and sata_sil24 now use ata_std_postreset() which makes no difference
      to them.  ahci now calls ata_std_postreset() from its own postreset
      method, which causes no behavior difference.
      Signed-off-by: default avatarTejun Heo <htejun@gmail.com>
      203c75b8
    • Tejun Heo's avatar
      libata: separate out ata_std_prereset() from ata_sff_prereset() · 0aa1113d
      Tejun Heo authored
      Separate out generic ATA portion from ata_sff_prereset() into
      ata_std_prereset() and implement ata_sff_prereset() using the std
      version.  Waiting for device readiness is the only SFF specific part.
      
      ata_base_port_ops now has ata_std_prereset() for its prereset and
      ata_sff_port_ops overrides it to ata_sff_prereset().  This change can
      affect pdc_adma, ahci, sata_fsl and sata_sil24.  pdc_adma implements
      its own prereset using ata_sff_prereset() and the rest has hardreset
      and thus are unaffected by this change.
      
      This change reflects real world situation.  There is no generic way to
      wait for device readiness for non-SFF controllers and some of them
      don't have any mechanism for that.  Non-sff drivers which don't have
      hardreset should wrap ata_std_prereset() and wait for device readiness
      itself but there's no such driver now and isn't likely to be popular
      in the future either.
      Signed-off-by: default avatarTejun Heo <htejun@gmail.com>
      0aa1113d
    • Tejun Heo's avatar
      libata: clean up port_ops->sff_irq_clear() · 288623a0
      Tejun Heo authored
      ->sff_irq_clear() is called only from SFF interrupt handler, so there
      is no reason to initialize it for non-SFF controllers.  Also,
      ata_sff_irq_clear() can handle both BMDMA and non-BMDMA SFF
      controllers.
      
      This patch kills ata_noop_irq_clear() and removes it from base
      port_ops and sets ->sff_irq_clear to ata_sff_irq_clear() in sff
      port_ops instead of bmdma port_ops.
      Signed-off-by: default avatarTejun Heo <htejun@gmail.com>
      288623a0
    • Tejun Heo's avatar
      libata: rename SFF port ops · 5682ed33
      Tejun Heo authored
      Add sff_ prefix to SFF specific port ops.
      
      This rename is in preparation of separating SFF support out of libata
      core layer.  This patch strictly renames ops and doesn't introduce any
      behavior difference.
      Signed-off-by: default avatarTejun Heo <htejun@gmail.com>
      5682ed33
    • Tejun Heo's avatar
      libata: rename SFF functions · 9363c382
      Tejun Heo authored
      SFF functions have confusing names.  Some have sff prefix, some have
      bmdma, some std, some pci and some none.  Unify the naming by...
      
      * SFF functions which are common to both BMDMA and non-BMDMA are
        prefixed with ata_sff_.
      
      * SFF functions which are specific to BMDMA are prefixed with
        ata_bmdma_.
      
      * SFF functions which are specific to PCI but apply to both BMDMA and
        non-BMDMA are prefixed with ata_pci_sff_.
      
      * SFF functions which are specific to PCI and BMDMA are prefixed with
        ata_pci_bmdma_.
      
      * Drop generic prefixes from LLD specific routines.  For example,
        bfin_std_dev_select -> bfin_dev_select.
      
      The following renames are noteworthy.
      
        ata_qc_issue_prot() -> ata_sff_qc_issue()
        ata_pci_default_filter() -> ata_bmdma_mode_filter()
        ata_dev_try_classify() -> ata_sff_dev_classify()
      
      This rename is in preparation of separating SFF support out of libata
      core layer.  This patch strictly renames functions and doesn't
      introduce any behavior difference.
      Signed-off-by: default avatarTejun Heo <htejun@gmail.com>
      9363c382
    • Mark Lord's avatar
      sata_mv fix ifctl handling · b67a1064
      Mark Lord authored
      Fix handling of the SATA_INTERFACE_CFG register to match datasheet requirements.
      Signed-off-by: default avatarMark Lord <mlord@pobox.com>
      Signed-off-by: default avatarJeff Garzik <jeff@garzik.org>
      b67a1064
    • Mark Lord's avatar
      sata_mv clean up mv_stop_edma usage · b562468c
      Mark Lord authored
      Clean up uses of mv_stop_edma{_engine}() to match datasheet requirements.
      Signed-off-by: default avatarMark Lord <mlord@pobox.com>
      Signed-off-by: default avatarJeff Garzik <jeff@garzik.org>
      b562468c
    • Mark Lord's avatar
      sata_mv cosmetic fixes · e12bef50
      Mark Lord authored
      Various cosmetic fixes in preparation for real code changes later on.
      Signed-off-by: default avatarMark Lord <mlord@pobox.com>
      Signed-off-by: default avatarJeff Garzik <jeff@garzik.org>
      e12bef50
    • Yoichi Yuasa's avatar
      use ATA_TAG_INTERNAL in ata_tag_internal() · 83c063dd
      Yoichi Yuasa authored
      It should be ATA_TAG_INTERNAL.
      Signed-off-by: default avatarYoichi Yuasa <yoichi_yuasa@tripeaks.co.jp>
      Signed-off-by: default avatarJeff Garzik <jeff@garzik.org>
      83c063dd