1. 08 Feb, 2019 19 commits
  2. 07 Feb, 2019 15 commits
  3. 05 Feb, 2019 3 commits
    • Steve Wise's avatar
      RDMA/iwpm: move kdoc comments to functions · a2bfd708
      Steve Wise authored
      Move the iwpm kdoc comments from the prototype declarations to above
      the function bodies.  There are no functional changes in this patch.
      Signed-off-by: default avatarSteve Wise <swise@opengridcomputing.com>
      Signed-off-by: default avatarJason Gunthorpe <jgg@mellanox.com>
      a2bfd708
    • Leon Romanovsky's avatar
      RDMA/cma: Remove CM_ID statistics provided by rdma-cm module · a78e8723
      Leon Romanovsky authored
      Netlink statistics exported by rdma-cm never had any working user space
      component published to the mailing list or to any open source
      project. Canvassing various proprietary users, and the original requester,
      we find that there are no real users of this interface.
      
      This patch simply removes all occurrences of RDMA CM netlink in favour of
      modern nldev implementation, which provides the same information and
      accompanied by widely used user space component.
      Signed-off-by: default avatarLeon Romanovsky <leonro@mellanox.com>
      Reviewed-by: default avatarSteve Wise <swise@opengridcomputing.com>
      Signed-off-by: default avatarJason Gunthorpe <jgg@mellanox.com>
      a78e8723
    • Bart Van Assche's avatar
      IB/mlx5: Do not use hw_access_flags for be and CPU data · bf3b4f06
      Bart Van Assche authored
      Avoid that sparse reports the following for the mlx5 driver:
      
      drivers/infiniband/hw/mlx5/qp.c:2671:34: warning: invalid assignment: |=
      drivers/infiniband/hw/mlx5/qp.c:2671:34:    left side has type restricted __be32
      drivers/infiniband/hw/mlx5/qp.c:2671:34:    right side has type int
      drivers/infiniband/hw/mlx5/qp.c:2679:34: warning: invalid assignment: |=
      drivers/infiniband/hw/mlx5/qp.c:2679:34:    left side has type restricted __be32
      drivers/infiniband/hw/mlx5/qp.c:2679:34:    right side has type int
      drivers/infiniband/hw/mlx5/qp.c:2680:34: warning: invalid assignment: |=
      drivers/infiniband/hw/mlx5/qp.c:2680:34:    left side has type restricted __be32
      drivers/infiniband/hw/mlx5/qp.c:2680:34:    right side has type int
      drivers/infiniband/hw/mlx5/qp.c:2684:34: warning: invalid assignment: |=
      drivers/infiniband/hw/mlx5/qp.c:2684:34:    left side has type restricted __be32
      drivers/infiniband/hw/mlx5/qp.c:2684:34:    right side has type int
      drivers/infiniband/hw/mlx5/qp.c:2686:28: warning: cast from restricted __be32
      drivers/infiniband/hw/mlx5/qp.c:2686:28: warning: incorrect type in argument 1 (different base types)
      drivers/infiniband/hw/mlx5/qp.c:2686:28:    expected unsigned int [usertype] val
      drivers/infiniband/hw/mlx5/qp.c:2686:28:    got restricted __be32 [usertype]
      drivers/infiniband/hw/mlx5/qp.c:2686:28: warning: cast from restricted __be32
      drivers/infiniband/hw/mlx5/qp.c:2686:28: warning: cast from restricted __be32
      drivers/infiniband/hw/mlx5/qp.c:2686:28: warning: cast from restricted __be32
      drivers/infiniband/hw/mlx5/qp.c:2686:28: warning: cast from restricted __be32
      
      This patch does not change any functionality.
      
      Fixes: a60109dc ("IB/mlx5: Add support for extended atomic operations")
      Signed-off-by: default avatarBart Van Assche <bvanassche@acm.org>
      Acked-by: default avatarLeon Romanovsky <leonro@mellanox.com>
      Signed-off-by: default avatarJason Gunthorpe <jgg@mellanox.com>
      bf3b4f06
  4. 04 Feb, 2019 3 commits
    • Steve Wise's avatar
      RDMA/IWPM: Support no port mapping requirements · b0bad9ad
      Steve Wise authored
      A soft iwarp driver that uses the host TCP stack via a kernel mode socket
      does not need port mapping.  In fact, if the port map daemon, iwpmd, is
      running, then iwpmd must not try and create/bind a socket to the actual
      port for a soft iwarp connection, since the driver already has that socket
      bound.
      
      Yet if the soft iwarp driver wants to interoperate with hard iwarp devices
      that -are- using port mapping, then the soft iwarp driver's mappings still
      need to be maintained and advertised by the iwpm protocol.
      
      This patch enhances the rdma driver<->iwcm interface to allow an iwarp
      driver to specify that it does not want port mapping.  The iwpm
      kernel<->iwpmd interface is also enhanced to pass up this information on
      map requests.
      
      Care is taken to interoperate with the current iwpmd version (ABI version
      3) and only use the new NL attributes if iwpmd supports ABI version 4.
      
      The ABI version define has also been created in rdma_netlink.h so both
      kernel and user code can share it.  The iwcm and iwpmd negotiate the ABI
      version to use with a new HELLO netlink message.
      Signed-off-by: default avatarSteve Wise <swise@opengridcomputing.com>
      Reviewed-by: default avatarTatyana Nikolova <Tatyana.E.Nikolova@intel.com>
      Signed-off-by: default avatarJason Gunthorpe <jgg@mellanox.com>
      b0bad9ad
    • Steve Wise's avatar
      RDMA/IWPM: refactor the IWPM message attribute names · f76903d5
      Steve Wise authored
      In order to add new IWPM_NL attributes, the enums for the IWPM commands
      attributes are refactored such that a new attribute can be added without
      breaking ABI version 3. Instead of sharing nl attribute enums for both
      request and response messages, we create separate enums for each IWPM
      message request and reply.  This allows us to extend any given IWPM
      message by adding new attributes for just that message.  These new enums
      are created, though, in a way to avoid breaking ABI version 3.
      Signed-off-by: default avatarSteve Wise <swise@opengridcomputing.com>
      Reviewed-by: default avatarTatyana Nikolova <Tatyana.E.Nikolova@intel.com>
      Signed-off-by: default avatarJason Gunthorpe <jgg@mellanox.com>
      f76903d5
    • Steve Wise's avatar
      iw_cxgb*: kzalloc the iwcm verbs struct · 95b8e384
      Steve Wise authored
      So future additions to that struct get initialized by default.
      Signed-off-by: default avatarSteve Wise <swise@opengridcomputing.com>
      Signed-off-by: default avatarJason Gunthorpe <jgg@mellanox.com>
      95b8e384