- 19 Mar, 2015 1 commit
-
-
Redha Gouicem authored
This patch fixes lines longer than the 80 char limit. Signed-off-by:
Redha Gouicem <redha.gouicem@gmail.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
- 18 Mar, 2015 35 commits
-
-
Gauthier Voron authored
This patch remove unnecessary bracket. Signed-off-by:
Gauthier Voron <gauthier.voron@lip6.fr> Signed-off-by:
Hakan Metin <hakan.metin@lip6.fr> Signed-off-by:
-
Gauthier Voron authored
This patch fix too large line. Signed-off-by:
-
Jonathan Sid-Otmane authored
This fixes the charatcer limit in niobuf.c Signed-off-by:
Jonathan Sid-Otmane <Jonathan.SidOtmane@gmail.com> Signed-off-by:
-
Jonathan Sid-Otmane authored
This fixes the space issues in the file vvp_dev.c Signed-off-by:
-
Roberto Medina authored
Coding style fixes due to exported symbols and comment style. Signed-off-by:
Roberto Medina <robertoxmed@gmail.com> Signed-off-by:
-
Laure Millet authored
This patch fixes lines over 80 characters Signed-off-by:
Laure Millet <laure.millet@lip6.fr> Signed-off-by:
Maxime Lorrillere <maxime.lorrillere@lip6.fr> Signed-off-by:
-
Laure Millet authored
This patch fixes a quoted string split across lines. Signed-off-by:
-
Laure Millet authored
This patch fixes a trailing whitespace in namei.c Signed-off-by:
-
Laure Millet authored
This patch fixes a coding style error in a pointer declaration. Signed-off-by:
-
Laure Millet authored
This fixes a missing blank line after declarations. Signed-off-by:
-
Quentin Lambert authored
The refactoring intrduced in c84a083b ("Staging: dgnc: Use goto for spinlock release before return") inverts the order in which the lock is released and ld is tested for nullity. This patch restores the execution flow. Fixes: c84a083b ("Staging: dgnc: Use goto for spinlock release before return") Signed-off-by:
Quentin Lambert <lambert.quentin@gmail.com> Signed-off-by:
-
Haneen Mohammed authored
dev_* is prefered over pr_* when appropriate device stuct is present. This patch replace pr_err and pr_warn with its dev_ counterpart. Signed-off-by:
Haneen Mohammed <hamohammed.sa@gmail.com> Signed-off-by:
-
Haneen Mohammed authored
This patch replace pr_err/pr_info with dev_err/dev_infi, when appropriate device structure is found. Issues found using the following Coccinelle script. pr_err/dev_err was substituted with pr_info/dev_info in the later case. @r exists@ identifier f, s, i; position p; @@ f(...,struct s *i,...) { <+... when != i == NULL pr_err@p(...); ...+> } @rr@ identifier r.s, s2, fld; @@ struct s { ... struct s2 *fld; ... }; @rrr@ identifier rr.s2, fld2; @@ struct s2 { ... struct device fld2; ... }; @@ identifier r.i, r.s, rr.fld, rrr.fld2; position r.p; @@ -pr_err@p +dev_err ( + &i->fld->fld2, ...) Signed-off-by: -
Haneen Mohammed authored
This patch replace pr_err/pr_info with dev_err/dev_info, when appropriate device structure is found. Issue found and resolved using the following Coccinelle script. pr_err/dev_err was substituted with pr_info/dev_info in the later case. @r exists@ identifier f, s, i; position p; @@ f(...,struct s *i,...) { <+... when != i == NULL pr_err@p(...); ...+> } @rr@ identifier r.s, s2, fld; @@ struct s { ... struct s2 *fld; ... }; @rrr@ identifier rr.s2, fld2; @@ struct s2 { ... struct device fld2; ... }; @@ identifier r.i, r.s, rr.fld, rrr.fld2; position r.p; @@ -pr_err@p +dev_err ( + &i->fld->fld2, ...) Signed-off-by: -
Vaishali Thakkar authored
After the commit 28af7ea8 ("Staging: rtl8188eu: Eliminate use of _init_timer"), macros (RTW_TIMER_HDL_ARGS, RTW_TIMER_HDL_NAME, RTW_DECLARE_TIMER_HDL) are no longer needed. So, remove them. Signed-off-by:
Vaishali Thakkar <vthakkar1994@gmail.com> Signed-off-by:
-
Haneen Mohammed authored
This patch replace pr_err with dev_err, when appropriate device structure is found. Issue found using the following Coccinelle script: @r exists@ identifier f, s, i; position p; @@ f(...,struct s *i,...) { <+... when != i == NULL pr_err@p(...); ...+> } @rr@ identifier r.s, fld; @@ struct s { ... struct device *fld; ... }; @@ identifier r.i, rr.fld; position r.p; @@ -pr_err@p +dev_err ( + i->fld, ...) Signed-off-by: -
Haneen Mohammed authored
This patch replace pr_err with dev_err, when appropriate device structre is found. Issue found using the following Coccinelle script: @r exists@ identifier f, s, i; position p; @@ f(...,struct s *i,...) { <+... when != i == NULL pr_err@p(...); ...+> } @rr@ identifier r.s, fld; @@ struct s { ... struct device *fld; ... }; @@ identifier r.i, rr.fld; position r.p; @@ -pr_err@p +dev_err ( + i->fld, ...) Signed-off-by: -
Haneen Mohammed authored
This patch replace pr_err with dev_err, when appropriate device structre is found. Issue found using the following Coccinelle script: @r exists@ identifier f, s, i; position p; @@ f(...,struct s *i,...) { <+... when != i == NULL pr_err@p(...); ...+> } @rr@ identifier r.s, fld; @@ struct s { ... struct device *fld; ... }; @@ identifier r.i, rr.fld; position r.p; @@ -pr_err@p +dev_err ( + i->fld, ...) Signed-off-by: -
Haneen Mohammed authored
This patch replace pr_err with dev_err, when appropriate device structure is found. Issue found using the following Coccinelle script: @r exists@ identifier f, s, i; position p; @@ f(...,struct s *i,...) { <+... when != i == NULL pr_err@p(...); ...+> } @rr@ identifier r.s, fld; @@ struct s { ... struct device *fld; ... }; @@ identifier r.i, rr.fld; position r.p; @@ -pr_err@p +dev_err ( + i->fld, ...) Signed-off-by: -
Vaishali Thakkar authored
Macro module_i2c_driver is used for drivers whose init and exit paths does only register and unregister to i2c API. So, here remove some boilerplate code by using module_i2c_driver. Signed-off-by:
-
Mario J. Rugiero authored
Replace uses of __attribute__(format(__printf,...)) by __printf(...), as suggested by checkpatch. Signed-off-by:
Mario J. Rugiero <mrugiero@gmail.com> Signed-off-by:
-
Mario J. Rugiero authored
Remove trailing semicolons from macros, as suggested by checkpatch. Signed-off-by:
-
Alberto Pires de Oliveira Neto authored
This patch fixes checkpatch.pl warning. WARNING: space required after that close brace '}' Signed-off-by:
Alberto Pires de Oliveira Neto <mrpenguin2005@gmail.com> Signed-off-by:
-
Alberto Pires de Oliveira Neto authored
This patch fixes checkpatch.pl warning. WARNING: void function return statements are not generally useful Signed-off-by:
-
Alberto Pires de Oliveira Neto authored
This patch fixes checkpatch.pl warning. WARNING: space prohibited between function name and open parenthesis '(' Signed-off-by: -
Yogeswaran Thulasidoss authored
This patch fixes the code style space issues identified by checkpatch.pl in drivers/staging/lustre/lustre/obdecho/echo_client.c Signed-off-by:
Yogeswaran Thulasidoss <yogeeswaran@gmail.com> Signed-off-by:
-
Ravindran, Madhusudhanan (M.) authored
The semantic patch that makes this change is available in scriptcoccinelle/api/memdup.cocci. Signed-off-by:
Madhusudhanan Ravindran <mravindr@visteon.com> Signed-off-by:
-
Oleg Drokin authored
Move setting of TASK_INTERRUPTIBLE just around schedule call in libcfs_sock_accept. Signed-off-by:
Oleg Drokin <green@linuxhacker.ru> Signed-off-by:
-
Lai Siyao authored
ll_intent_drop_lock() may sleep in memory allocation, which should not be called inside spinlock. Signed-off-by:
Lai Siyao <lai.siyao@intel.com> Signed-off-by:
Jian Yu <jian.yu@intel.com> Reviewed-on: http://review.whamcloud.com/10674 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-2272Signed-off-by:
Oleg Drokin <oleg.drokin@intel.com> Signed-off-by:
-
Oleg Drokin authored
cpus_weight and for_each_cpu_mask are deprecated, so replace them with cpumask_weight and for_each_cpu respectively. Signed-off-by:
-
Oleg Drokin authored
This patch continues to further remove deprecated functions, such as any_online_cpu, for_each_cpu_mask and also cleaning up usage of NR_CPUS in a few places Signed-off-by:
-
Haneen Mohammed authored
This patch fix the following spelling mistakes: interoprability, SEPERATOR, defult. Issue found using checkpatch.pl. Signed-off-by:
-
Cristina Opriceana authored
This patch renames struct DRxPathSel to dynamic_rx_path_sel in order to keep the notations consistent and to remove the warning: "CHECK: Avoid CamelCase". Done with coccinelle: @@ @@ struct -DRxPathSel +dynamic_rx_path_sel {...} @@ @@ struct -DRxPathSel +dynamic_rx_path_sel Signed-off-by:Cristina Opriceana <cristina.opriceana@gmail.com> Signed-off-by:
-
Cristina Opriceana authored
This patch removes the dig_t and DRxPathSel type definitions in order to avoid the following warning: "WARNING: Do not add new typedefs". Done with coccinelle and this script: @r@ type t; identifier id; @@ typedef struct id {...} t; @script:python get_name@ t << r.t; tdres; @@ coccinelle.tdres = t.replace("_t", ""); @r_match@ type r.t; identifier r.id; identifier get_name.tdres; @@ -typedef struct -id +tdres {...} -t ; @r_replace@ type r.t; identifier get_name.tdres; @@ -t +struct tdres Signed-off-by: -
Haneen Mohammed authored
This patch replace memcpy with ethe_addr_copy to address the following warning generated by checkpatch.pl: ""Prefer ether_addr_copy over memcpy if the Ethernet addresses are __aligned(2)" Follwoing is the output of pahole for the relevant datastructures: 1- for "iwe.u.ap_addr.sa_data" and "wrqu->ap_addr.sa_data" struct sockaddr { sa_family_t sa_family; /* 0 2 */ char sa_data[14]; /* 2 14 */ /* size: 16, cachelines: 1, members: 2 */ /* last cacheline: 16 bytes */ }; struct iw_event { __u16 len; /* 0 2 */ __u16 cmd; /* 2 2 */ /* XXX 4 bytes hole, try to pack */ union iwreq_data u; /* 8 16 */ /* size: 24, cachelines: 1, members: 3 */ /* sum members: 20, holes: 1, sum holes: 4 */ /* last cacheline: 24 bytes */ }; 2- for "pnetwork->network.MacAddress" and "pcur_bss->MacAddress" struct wlan_network { struct list_head list; /* 0 16 */ int network_type; /* 16 4 */ int fixed; /* 20 4 */ unsigned int last_scanned; /* 24 4 */ int aid; /* 28 4 */ int join_res; /* 32 4 */ struct ndis_wlan_bssid_ex network; /* 36 884 */ /* --- cacheline 14 boundary (896 bytes) was 24 bytes ago --- */ /* size: 920, cachelines: 15, members: 7 */ /* last cacheline: 24 bytes */ }; struct ndis_wlan_bssid_ex { u32 Length; /* 0 4 */ unsigned char MacAddress[6]; /* 4 6 */ u8 Reserved[2]; /* 10 2 */ struct ndis_802_11_ssid Ssid; /* 12 36 */ u32 Privacy; /* 48 4 */ s32 Rssi; /* 52 4 */ enum NDIS_802_11_NETWORK_TYPE NetworkTypeInUse; /* 56 4 */ struct NDIS_802_11_CONFIGURATION Configuration; /* 60 32 */ /* --- cacheline 1 boundary (64 bytes) was 28 bytes ago --- */ enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode; /* 92 4 */ NDIS_802_11_RATES_EX SupportedRates; /* 96 16 */ u32 IELength; /* 112 4 */ u8 IEs[768]; /* 116 768 */ /* --- cacheline 13 boundary (832 bytes) was 52 bytes ago --- */ /* size: 884, cachelines: 14, members: 12 */ /* last cacheline: 52 bytes */ }; Signed-off-by:
-
- 16 Mar, 2015 4 commits
-
-
Andy Shevchenko authored
This patch converts code to use %pM specifier instead of placing each byte on stack. Signed-off-by:
Andy Shevchenko <andy.shevchenko@gmail.com> Signed-off-by:
-
Dan Carpenter authored
When we removed the ERRDEV() macro we made a small mistake so now it doesn't print the "Virtual PCI devices" section header. Fixes: 0aca7844 ('staging: unisys: remove ERRDEV macros') Signed-off-by:
Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by:
-
Michel von Czettritz authored
This fixes "braces {} are not necessary for single statement blocks" in uislib. Signed-off-by:Michel von Czettritz <michel.von.czettritz@gmail.com> Signed-off-by:
-
Somya Anand authored
Functions like devm_kzalloc, kmalloc_array, devm_ioremap, usb_alloc_urb, alloc_netdev return NULL as a return value on failure. Generally, When NULL represents failure, !x is commonly used. This patch cleans up the tests on the results of these functions, thereby using !x instead of x == NULL or NULL == x. This is done via following coccinelle script: @prob_7@ identifier x; statement S; @@ ( x = devm_kzalloc(...); | x = usb_alloc_urb(...); | x = kmalloc_array(...); | x = devm_ioremap(...); | x = alloc_netdev(...); ) ... - if(NULL == x) + if(!x) S Further we have used isomorphism characteristics of coccinelle to indicate x == NULL and NULL == x are equivalent. This is done via following iso script. Expression @ is_null @ expression X; @@ X == NULL <=> NULL == X Signed-off-by:Somya Anand <somyaanand214@gmail.com> Signed-off-by:
-
