Commits · e8192f367cb3dcbefaa4109d26f3b1645b0c6b56 · nexedi / linux

29 Sep, 2006 40 commits

[IPV4] bug: broken open-coded inet_make_mask() (multipath_wrandom) · e8192f36

Al Viro authored Sep 26, 2006

multipath_wrandom.c::__multipath_lookup_weight() contains open-coded
attempt at inet_make_mask(); broken on big-endian.
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

e8192f36

[IPV4] multipath_wrandom.c: trivial annotations · f20f4a60

Al Viro authored Sep 26, 2006

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

f20f4a60

[IPV4]: multipath_set_nhinfo() annotations · d9cd66e0

Al Viro authored Sep 26, 2006

multipath_set_nhinfo() (and underlying callback) take net-endian
network and netmask.
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

d9cd66e0

[IPV4] fib_trie.c: trivial annotations · 32ab5f80

Al Viro authored Sep 26, 2006

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

32ab5f80

[IPV4] bug: open-coded inet_make_mask() in fib_semantic_match() is broken · 1e8aa6f1

Al Viro authored Sep 26, 2006

... and works only on little-endian
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

1e8aa6f1

[IPV4]: fib_semantic_match() annotations · 1ef1b8c8

Al Viro authored Sep 26, 2006

'mask' and 'zone' arguments are net-endian
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

1ef1b8c8

[IPV4]: trivial fib_hash.c annotations · b6e80c6c

Al Viro authored Sep 26, 2006

hash key and stored netmask are net-endian
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

b6e80c6c

[IPV4]: annotate addresses in fib_result and fib_result_nl · 80e856e1

Al Viro authored Sep 26, 2006

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

80e856e1

[IPV4]: ip_fragment.c endianness annotations · 18277770

Al Viro authored Sep 26, 2006

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

18277770

[IPV4]: inetpeer annotations · 53576d9b

Al Viro authored Sep 26, 2006

This one is interesting - we use net-endian value as search key, but
order the tree by *host-endian* comparisons of keys.  OK since we only
care about lookups.  Annotated inet_getpeer() and friends.
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

53576d9b

[IPV4]: ip_fib_check_default() annotated · d878e72e

Al Viro authored Sep 26, 2006

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

d878e72e

[IPV4]: inet_addr_type() annotations · fd683222

Al Viro authored Sep 26, 2006

argument and inferred net-endian variables in callers annotated.
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

fd683222

[IPV4]: icmp_send() annotation · e4883014

Al Viro authored Sep 26, 2006

The last argument is network-endian (it will go straight into the packet).
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

e4883014

[IPV4]: annotate inetdev.h helpers · 60cad5da

Al Viro authored Sep 26, 2006

inet_confirm_addr(), inet_ifa_byprefix(), ip_dev_find(), inet_make_mask() and
inet_ifa_match() annotated, along with inferred net-endian variables
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

60cad5da

[IPV4]: IFA_{LOCAL,ADDRESS,BROADCAST,ANYCAST} on ipv4 annotated · a7a628c4

Al Viro authored Sep 26, 2006

use be32 netlink accessors
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

a7a628c4

[IPV4]: annotate struct in_ifaddr · a144ea4b

Al Viro authored Sep 28, 2006

ifa_local, ifa_address, ifa_mask, ifa_broadcast and ifa_anycast are
net-endian.  Annotated them and variables that are inferred to be
net-endian.
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

a144ea4b

[IPV4]: struct fib_config IPv4 address fields annotated · 6d85c10a

Al Viro authored Sep 26, 2006

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

6d85c10a

[IPV4]: RTA_{DST,SRC,GATEWAY,PREFSRC} annotated · 17fb2c64

Al Viro authored Sep 26, 2006

these are passed net-endian; use be32 netlink accessors
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

17fb2c64

[IPV4] net/ipv4/route.c: trivial endianness annotations · e448515c

Al Viro authored Sep 26, 2006

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

e448515c

[IPV4]: introduce nla_get_be32()/NLA_PUT_BE32() · 00012e5b

Al Viro authored Sep 26, 2006

net-endian counterparts of nla_get_u32()/NLA_PUT_U32()
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

00012e5b

[IPV4]: FIB_RES_PREFSRC() annotated · b83738ae

Al Viro authored Sep 26, 2006

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

b83738ae

[IPV4]: fib_hn ->nh_gw is net-endian · ed49e3ca

Al Viro authored Sep 26, 2006

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

ed49e3ca

[IPV4]: inet_addr_onlink() annotated · ff428d72

Al Viro authored Sep 26, 2006

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

ff428d72

[IPV4]: ip_check_mc() annotations · a60c4923

Al Viro authored Sep 26, 2006

annotated arguments
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

a60c4923

[IPV4]: fib_validate_source() annotations · d9c9df8c

Al Viro authored Sep 26, 2006

annotated arguments and inferred net-endian variables in callers
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

d9c9df8c

[IPV4]: inet_select_addr() annotations · a61ced5d

Al Viro authored Sep 26, 2006

argument and return value are net-endian.  Annotated function and inferred
net-endian variables in callers.
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

a61ced5d

[IPV4]: annotated ipv4 addresses in struct inet_sock · 011a9261

Al Viro authored Sep 26, 2006

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

011a9261

[IPV4]: ip_route_connect() ipv4 address arguments annotated · bada8adc

Al Viro authored Sep 26, 2006

annotated address arguments (port number left alone for now); ditto
for inferred net-endian variables in callers.
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

bada8adc

[IPV4]: annotate ipv4 addresses in struct rtable and struct flowi · f2c3fe24
Al Viro authored Sep 26, 2006
```
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
```
f2c3fe24

[IPV4]: annotate rt_hash_code() users · 8c7bc840

Al Viro authored Sep 26, 2006

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

8c7bc840

[IPV4]: ip_rt_redirect() annotations · f7655229

Al Viro authored Sep 26, 2006

The first 4 arguments of ip_rt_redirect() are net-endian.  Annotated.
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

f7655229

[IPV4]: ip_route_input() annotations · 9e12bb22

Al Viro authored Sep 26, 2006

ip_route_input() takes net-endian source and destination address.
* Annotated as such.
* arguments of its invocations annotated where needed.
* local helpers getting the same values passed to by it (ip_route_input_mc(),
ip_route_input_slow(), ip_handle_martian_source(), ip_mkroute_input(),
ip_mkroute_input_def(), __mkroute_input()) annotated
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

9e12bb22

[IPV4]: headers endianness · 046d0331

Al Viro authored Sep 26, 2006

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

046d0331

[ATM]: use NIPQUAD instead of open-coding it · b4229934

Al Viro authored Sep 26, 2006

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

b4229934

[TR]: endiannness annotations · 0ac0760a

Al Viro authored Sep 26, 2006

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

0ac0760a

[ATALK]: endianness annotations · 2a50f28c

Al Viro authored Sep 26, 2006

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

2a50f28c

[NET] Kconfig: fix cut/paste error in TCPPROBE · 82fe7c92

Grant Grundler authored Sep 25, 2006

Fix cut/paste error in TCPPROBE help text.
Signed-off-by: Grant Grundler <grundler@parisc-linux.org>
Signed-off-by: David S. Miller <davem@davemloft.net>

82fe7c92

[NETDEV] config: revert part of previous patch · 1618cb0c

Randy Dunlap authored Sep 25, 2006

Net devices should depend on NETDEVICES, so revert part of
Paolo's previous patch.

See http://marc.theaimsgroup.com/?l=linux-kernel&m=115566326218740&w=2
for history.
Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
Signed-off-by: David S. Miller <davem@davemloft.net>

1618cb0c

[IRDA] via-ircc: fix memory leak · 83e331e2

Chuck Short authored Sep 25, 2006

Fix memory leak.

Coverity id# 653

patch location:
http://www.kernel.org/git/?p=linux/kernel/git/bcollins/ubuntu-dapper.git;a=commitdiff;h=a1f34cb68b16807ed9d5ebb0f6a6ec5ff8a5fc78Signed-off-by: Chuck Short <zulcss@gmail.com>
Signed-off-by: Ben Collins <bcollins@ubuntu.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: David S. Miller <davem@davemloft.net>

83e331e2

[IPV6]: bh_lock_sock_nested on tcp_v6_rcv · 293b9c42

Fabio Olive Leite authored Sep 25, 2006

A while ago Ingo patched tcp_v4_rcv on net/ipv4/tcp_ipv4.c to use
bh_lock_sock_nested and silence a lock validator warning. This fixed
it for IPv4, but recently I saw a report of the same warning on IPv6.
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: David S. Miller <davem@davemloft.net>

293b9c42