An error occurred fetching the project authors.
  1. 27 Aug, 2011 1 commit
    • Doron Cohen's avatar
      [media] siano: apply debug flag to module level · ea370943
      Doron Cohen authored
      Siano modules already had sms_dbg flag which is a module parameter which
      sets the debug mode so module prints messages to dmesg for debugging.
      The variable was static therefore apply only to the file which defines
      the module. In modules as smsmdtv.ko that contain a few files, the debug
      flag applied only for functions in that main file.
      flag was changed to be non-static and therefore can be accessed by all
      module files (although it is still not exported out of the module).
      Signed-off-by: default avatarDoron Cohen <doronc@siano-ms.com>
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
      ea370943
  2. 27 Jul, 2011 1 commit
  3. 29 Dec, 2010 1 commit
  4. 21 Oct, 2010 1 commit
  5. 28 Sep, 2010 1 commit
  6. 09 Aug, 2010 1 commit
  7. 02 Aug, 2010 1 commit
  8. 16 Jun, 2010 1 commit
  9. 30 Mar, 2010 1 commit
    • Tejun Heo's avatar
      include cleanup: Update gfp.h and slab.h includes to prepare for breaking... · 5a0e3ad6
      Tejun Heo authored
      include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h
      
      percpu.h is included by sched.h and module.h and thus ends up being
      included when building most .c files.  percpu.h includes slab.h which
      in turn includes gfp.h making everything defined by the two files
      universally available and complicating inclusion dependencies.
      
      percpu.h -> slab.h dependency is about to be removed.  Prepare for
      this change by updating users of gfp and slab facilities include those
      headers directly instead of assuming availability.  As this conversion
      needs to touch large number of source files, the following script is
      used as the basis of conversion.
      
        http://userweb.kernel.org/~tj/misc/slabh-sweep.py
      
      The script does the followings.
      
      * Scan files for gfp and slab usages and update includes such that
        only the necessary includes are there.  ie. if only gfp is used,
        gfp.h, if slab is used, slab.h.
      
      * When the script inserts a new include, it looks at the include
        blocks and try to put the new include such that its order conforms
        to its surrounding.  It's put in the include block which contains
        core kernel includes, in the same order that the rest are ordered -
        alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
        doesn't seem to be any matching order.
      
      * If the script can't find a place to put a new include (mostly
        because the file doesn't have fitting include block), it prints out
        an error message indicating which .h file needs to be added to the
        file.
      
      The conversion was done in the following steps.
      
      1. The initial automatic conversion of all .c files updated slightly
         over 4000 files, deleting around 700 includes and adding ~480 gfp.h
         and ~3000 slab.h inclusions.  The script emitted errors for ~400
         files.
      
      2. Each error was manually checked.  Some didn't need the inclusion,
         some needed manual addition while adding it to implementation .h or
         embedding .c file was more appropriate for others.  This step added
         inclusions to around 150 files.
      
      3. The script was run again and the output was compared to the edits
         from #2 to make sure no file was left behind.
      
      4. Several build tests were done and a couple of problems were fixed.
         e.g. lib/decompress_*.c used malloc/free() wrappers around slab
         APIs requiring slab.h to be added manually.
      
      5. The script was run on all .h files but without automatically
         editing them as sprinkling gfp.h and slab.h inclusions around .h
         files could easily lead to inclusion dependency hell.  Most gfp.h
         inclusion directives were ignored as stuff from gfp.h was usually
         wildly available and often used in preprocessor macros.  Each
         slab.h inclusion directive was examined and added manually as
         necessary.
      
      6. percpu.h was updated not to include slab.h.
      
      7. Build test were done on the following configurations and failures
         were fixed.  CONFIG_GCOV_KERNEL was turned off for all tests (as my
         distributed build env didn't work with gcov compiles) and a few
         more options had to be turned off depending on archs to make things
         build (like ipr on powerpc/64 which failed due to missing writeq).
      
         * x86 and x86_64 UP and SMP allmodconfig and a custom test config.
         * powerpc and powerpc64 SMP allmodconfig
         * sparc and sparc64 SMP allmodconfig
         * ia64 SMP allmodconfig
         * s390 SMP allmodconfig
         * alpha SMP allmodconfig
         * um on x86_64 SMP allmodconfig
      
      8. percpu.h modifications were reverted so that it could be applied as
         a separate patch and serve as bisection point.
      
      Given the fact that I had only a couple of failures from tests on step
      6, I'm fairly confident about the coverage of this conversion patch.
      If there is a breakage, it's likely to be something in one of the arch
      headers which should be easily discoverable easily on most builds of
      the specific arch.
      Signed-off-by: default avatarTejun Heo <tj@kernel.org>
      Guess-its-ok-by: default avatarChristoph Lameter <cl@linux-foundation.org>
      Cc: Ingo Molnar <mingo@redhat.com>
      Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
      5a0e3ad6
  10. 26 Feb, 2010 1 commit
  11. 05 Dec, 2009 1 commit
  12. 21 Sep, 2009 1 commit
  13. 13 Aug, 2009 1 commit
  14. 23 Jun, 2009 1 commit
    • Hans Verkuil's avatar
      V4L/DVB (12107): smscoreapi: fix compile warning · be5daa9b
      Hans Verkuil authored
      gcc 4.3.1 generates this warning:
      
      v4l/smscoreapi.c: In function 'smscore_gpio_configure':
      v4l/smscoreapi.c:1481: warning: 'GroupNum' may be used uninitialized in this function
      v4l/smscoreapi.c:1480: warning: 'TranslatedPinNum' may be used uninitialized in this function
      
      While in practice this will not happen, it is something that the compiler
      can't determine. Initializing these two local variables to 0 suppresses
      this warning.
      
      Cc: Udi Atar <udi.linuxtv@gmail.com>
      Signed-off-by: default avatarHans Verkuil <hverkuil@xs4all.nl>
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
      be5daa9b
  15. 16 Jun, 2009 10 commits
  16. 30 Mar, 2009 4 commits
    • Michael Krufky's avatar
      V4L/DVB (10772): siano: prevent duplicate variable declaration · 0d02efe4
      Michael Krufky authored
      Fix the following build error:
      
      drivers/media/dvb/siano/smsusb.o: In function `get_order':
      include/asm-generic/page.h:10: multiple definition of `sms_dbg'
      drivers/media/dvb/siano/sms1xxx.o:include/asm-generic/page.h:10: first defined here
      drivers/media/dvb/siano/smsdvb.o: In function `get_order':
      include/asm-generic/page.h:10: multiple definition of `sms_dbg'
      drivers/media/dvb/siano/sms1xxx.o:include/asm-generic/page.h:10: first defined here
      
      Thanks to Mauro Carvalho Chehab for his original patch to address this issue.
      Signed-off-by: default avatarMichael Krufky <mkrufky@linuxtv.org>
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
      0d02efe4
    • Michael Krufky's avatar
      V4L/DVB (10753): siano: convert EXPORT_SYMBOL to EXPORT_SYMBOL_GPL · a0beec8f
      Michael Krufky authored
      As pointed out by Mauro Chehab, we should always use EXPORT_SYMBOL_GPL
      instead of EXPORT_SYMBOL wherever possible.
      
      A message was posted to the linux-media mailing list about this, checking
      with Uri Shkolnik of Siano Mobile Silicon if this is okay to convert.
      
      As per Uri's response to this email, it is OK for us to make this conversion.
      
      http://www.spinics.net/lists/linux-media/msg02200.htmlSigned-off-by: default avatarMichael Krufky <mkrufky@linuxtv.org>
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
      a0beec8f
    • Michael Krufky's avatar
      V4L/DVB (10751): sms1xxx: fix checkpatch.pl violations introduced by previous changeset · b9391f41
      Michael Krufky authored
      Fix checkpatch.pl violations introduced by previous changeset:
      
      ERROR: do not use C99 // comments
      156: FILE: linux/drivers/media/dvb/siano/smscoreapi.c:1373:
      +//#ifdef DVB_CORE
      
      ERROR: do not use C99 // comments
      157: FILE: linux/drivers/media/dvb/siano/smscoreapi.c:1374:
      +//	smsdvb_unregister();
      
      ERROR: do not use C99 // comments
      158: FILE: linux/drivers/media/dvb/siano/smscoreapi.c:1375:
      +//#endif
      
      WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
      163: FILE: linux/drivers/media/dvb/siano/smscoreapi.c:1380:
      +EXPORT_SYMBOL(smscore_onresponse);
      
      WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
      164: FILE: linux/drivers/media/dvb/siano/smscoreapi.c:1381:
      +EXPORT_SYMBOL(sms_get_board);
      
      WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
      165: FILE: linux/drivers/media/dvb/siano/smscoreapi.c:1382:
      +EXPORT_SYMBOL(sms_debug);
      
      WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
      166: FILE: linux/drivers/media/dvb/siano/smscoreapi.c:1383:
      +EXPORT_SYMBOL(smscore_putbuffer);
      
      WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
      167: FILE: linux/drivers/media/dvb/siano/smscoreapi.c:1384:
      +EXPORT_SYMBOL(smscore_registry_getmode);
      
      WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
      168: FILE: linux/drivers/media/dvb/siano/smscoreapi.c:1385:
      +EXPORT_SYMBOL(smscore_register_device);
      
      WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
      169: FILE: linux/drivers/media/dvb/siano/smscoreapi.c:1386:
      +EXPORT_SYMBOL(smscore_set_board_id);
      
      WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
      170: FILE: linux/drivers/media/dvb/siano/smscoreapi.c:1387:
      +EXPORT_SYMBOL(smscore_start_device);
      
      WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
      171: FILE: linux/drivers/media/dvb/siano/smscoreapi.c:1388:
      +EXPORT_SYMBOL(smsusb_id_table);
      
      WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
      172: FILE: linux/drivers/media/dvb/siano/smscoreapi.c:1389:
      +EXPORT_SYMBOL(smscore_unregister_device);
      
      WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
      173: FILE: linux/drivers/media/dvb/siano/smscoreapi.c:1390:
      +EXPORT_SYMBOL(smscore_getbuffer);
      
      WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
      174: FILE: linux/drivers/media/dvb/siano/smscoreapi.c:1391:
      +EXPORT_SYMBOL(smscore_get_device_mode);
      
      WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
      175: FILE: linux/drivers/media/dvb/siano/smscoreapi.c:1392:
      +EXPORT_SYMBOL(smscore_register_client);
      
      WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
      176: FILE: linux/drivers/media/dvb/siano/smscoreapi.c:1393:
      +EXPORT_SYMBOL(smscore_unregister_hotplug);
      
      WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
      177: FILE: linux/drivers/media/dvb/siano/smscoreapi.c:1394:
      +EXPORT_SYMBOL(smsclient_sendrequest);
      
      WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
      178: FILE: linux/drivers/media/dvb/siano/smscoreapi.c:1395:
      +EXPORT_SYMBOL(smscore_unregister_client);
      
      WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
      179: FILE: linux/drivers/media/dvb/siano/smscoreapi.c:1396:
      +EXPORT_SYMBOL(smscore_get_board_id);
      
      WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
      180: FILE: linux/drivers/media/dvb/siano/smscoreapi.c:1397:
      +EXPORT_SYMBOL(smscore_register_hotplug);
      
      WARNING: line over 80 characters
      391: FILE: linux/drivers/media/dvb/siano/smscoreapi.h:398:
      +extern int smscore_get_fw_filename(struct smscore_device_t *coredev, int mode, char* filename);
      
      ERROR: "foo* bar" should be "foo *bar"
      391: FILE: linux/drivers/media/dvb/siano/smscoreapi.h:398:
      +extern int smscore_get_fw_filename(struct smscore_device_t *coredev, int mode, char* filename);
      
      WARNING: line over 80 characters
      392: FILE: linux/drivers/media/dvb/siano/smscoreapi.h:399:
      +extern int smscore_send_fw_file(struct smscore_device_t *coredev, u8* ufwbuf,int size);
      
      ERROR: "foo* bar" should be "foo *bar"
      392: FILE: linux/drivers/media/dvb/siano/smscoreapi.h:399:
      +extern int smscore_send_fw_file(struct smscore_device_t *coredev, u8* ufwbuf,int size);
      
      ERROR: space required after that ',' (ctx:VxV)
      392: FILE: linux/drivers/media/dvb/siano/smscoreapi.h:399:
      +extern int smscore_send_fw_file(struct smscore_device_t *coredev, u8* ufwbuf,int size);
                                                                                   ^
      
      WARNING: __func__ should be used instead of gcc specific __FUNCTION__
      489: FILE: linux/drivers/media/dvb/siano/smsusb.c:443:
      +	printk(KERN_INFO"%s  Entering status %d.\n", __FUNCTION__, msg.event);
      
      WARNING: __func__ should be used instead of gcc specific __FUNCTION__
      501: FILE: linux/drivers/media/dvb/siano/smsusb.c:455:
      +	printk(KERN_INFO  "%s  Entering.\n", __FUNCTION__);
      
      ERROR: space prohibited before that '++' (ctx:WxB)
      505: FILE: linux/drivers/media/dvb/siano/smsusb.c:459:
      +	for (i = 0; i < intf->cur_altsetting->desc.bNumEndpoints; i ++)
       	                                                            ^
      
      WARNING: __func__ should be used instead of gcc specific __FUNCTION__
      517: FILE: linux/drivers/media/dvb/siano/smsusb.c:471:
      +			__FUNCTION__, rc);
      Signed-off-by: default avatarMichael Krufky <mkrufky@linuxtv.org>
      [mchehab@redhat.com: sms_dbg were declared on 3 different files]
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
      b9391f41
    • Uri Shkolnik's avatar
      V4L/DVB (10750): import changes from Siano · e0f14c25
      Uri Shkolnik authored
      Import the following changes from Uri Shkolnik
      
      * Two-ways merge with Siano internal repository
      * Continuing with DVB sub-system separation
      * kconfig and makefile updates
      * Code cleanup
      
      This is a work-in-progress sync with Siano's internal repository.
      
      Some changes had to be altered or dropped in order not to break the build.
      
      This breaks normal operation for the current driver, but it is being committed
      now for tracking purposes.
      
      These changes introduce the following checkpatch.pl violations:
      
      ERROR: do not use C99 // comments
      156: FILE: linux/drivers/media/dvb/siano/smscoreapi.c:1373:
      +//#ifdef DVB_CORE
      
      ERROR: do not use C99 // comments
      157: FILE: linux/drivers/media/dvb/siano/smscoreapi.c:1374:
      +//	smsdvb_unregister();
      
      ERROR: do not use C99 // comments
      158: FILE: linux/drivers/media/dvb/siano/smscoreapi.c:1375:
      +//#endif
      
      WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
      163: FILE: linux/drivers/media/dvb/siano/smscoreapi.c:1380:
      +EXPORT_SYMBOL(smscore_onresponse);
      
      WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
      164: FILE: linux/drivers/media/dvb/siano/smscoreapi.c:1381:
      +EXPORT_SYMBOL(sms_get_board);
      
      WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
      165: FILE: linux/drivers/media/dvb/siano/smscoreapi.c:1382:
      +EXPORT_SYMBOL(sms_debug);
      
      WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
      166: FILE: linux/drivers/media/dvb/siano/smscoreapi.c:1383:
      +EXPORT_SYMBOL(smscore_putbuffer);
      
      WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
      167: FILE: linux/drivers/media/dvb/siano/smscoreapi.c:1384:
      +EXPORT_SYMBOL(smscore_registry_getmode);
      
      WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
      168: FILE: linux/drivers/media/dvb/siano/smscoreapi.c:1385:
      +EXPORT_SYMBOL(smscore_register_device);
      
      WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
      169: FILE: linux/drivers/media/dvb/siano/smscoreapi.c:1386:
      +EXPORT_SYMBOL(smscore_set_board_id);
      
      WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
      170: FILE: linux/drivers/media/dvb/siano/smscoreapi.c:1387:
      +EXPORT_SYMBOL(smscore_start_device);
      
      WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
      171: FILE: linux/drivers/media/dvb/siano/smscoreapi.c:1388:
      +EXPORT_SYMBOL(smsusb_id_table);
      
      WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
      172: FILE: linux/drivers/media/dvb/siano/smscoreapi.c:1389:
      +EXPORT_SYMBOL(smscore_unregister_device);
      
      WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
      173: FILE: linux/drivers/media/dvb/siano/smscoreapi.c:1390:
      +EXPORT_SYMBOL(smscore_getbuffer);
      
      WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
      174: FILE: linux/drivers/media/dvb/siano/smscoreapi.c:1391:
      +EXPORT_SYMBOL(smscore_get_device_mode);
      
      WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
      175: FILE: linux/drivers/media/dvb/siano/smscoreapi.c:1392:
      +EXPORT_SYMBOL(smscore_register_client);
      
      WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
      176: FILE: linux/drivers/media/dvb/siano/smscoreapi.c:1393:
      +EXPORT_SYMBOL(smscore_unregister_hotplug);
      
      WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
      177: FILE: linux/drivers/media/dvb/siano/smscoreapi.c:1394:
      +EXPORT_SYMBOL(smsclient_sendrequest);
      
      WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
      178: FILE: linux/drivers/media/dvb/siano/smscoreapi.c:1395:
      +EXPORT_SYMBOL(smscore_unregister_client);
      
      WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
      179: FILE: linux/drivers/media/dvb/siano/smscoreapi.c:1396:
      +EXPORT_SYMBOL(smscore_get_board_id);
      
      WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
      180: FILE: linux/drivers/media/dvb/siano/smscoreapi.c:1397:
      +EXPORT_SYMBOL(smscore_register_hotplug);
      
      WARNING: line over 80 characters
      391: FILE: linux/drivers/media/dvb/siano/smscoreapi.h:398:
      +extern int smscore_get_fw_filename(struct smscore_device_t *coredev, int mode, char* filename);
      
      ERROR: "foo* bar" should be "foo *bar"
      391: FILE: linux/drivers/media/dvb/siano/smscoreapi.h:398:
      +extern int smscore_get_fw_filename(struct smscore_device_t *coredev, int mode, char* filename);
      
      WARNING: line over 80 characters
      392: FILE: linux/drivers/media/dvb/siano/smscoreapi.h:399:
      +extern int smscore_send_fw_file(struct smscore_device_t *coredev, u8* ufwbuf,int size);
      
      ERROR: "foo* bar" should be "foo *bar"
      392: FILE: linux/drivers/media/dvb/siano/smscoreapi.h:399:
      +extern int smscore_send_fw_file(struct smscore_device_t *coredev, u8* ufwbuf,int size);
      
      ERROR: space required after that ',' (ctx:VxV)
      392: FILE: linux/drivers/media/dvb/siano/smscoreapi.h:399:
      +extern int smscore_send_fw_file(struct smscore_device_t *coredev, u8* ufwbuf,int size);
                                                                                   ^
      
      WARNING: __func__ should be used instead of gcc specific __FUNCTION__
      489: FILE: linux/drivers/media/dvb/siano/smsusb.c:443:
      +	printk(KERN_INFO"%s  Entering status %d.\n", __FUNCTION__, msg.event);
      
      WARNING: __func__ should be used instead of gcc specific __FUNCTION__
      501: FILE: linux/drivers/media/dvb/siano/smsusb.c:455:
      +	printk(KERN_INFO  "%s  Entering.\n", __FUNCTION__);
      
      ERROR: space prohibited before that '++' (ctx:WxB)
      505: FILE: linux/drivers/media/dvb/siano/smsusb.c:459:
      +	for (i = 0; i < intf->cur_altsetting->desc.bNumEndpoints; i ++)
       	                                                            ^
      
      WARNING: __func__ should be used instead of gcc specific __FUNCTION__
      517: FILE: linux/drivers/media/dvb/siano/smsusb.c:471:
      +			__FUNCTION__, rc);
      
      total: 7 errors, 23 warnings, 524 lines checked
      Signed-off-by: default avatarUri Shkolnik <uris@siano-ms.com>
      Signed-off-by: default avatarMichael Krufky <mkrufky@linuxtv.org>
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
      e0f14c25
  17. 29 Dec, 2008 2 commits
  18. 03 Sep, 2008 1 commit
  19. 26 Jul, 2008 1 commit
    • Adrian Bunk's avatar
      V4L/DVB (8453): sms1xxx: dvb/siano/: cleanups · c5e0bd1a
      Adrian Bunk authored
      This patch contains the following cleanups:
      - mark smscore_module_init() as __init
      - mark smscore_module_exit as __exit
      - make the following needlessly global code static:
        - smscoreapi.c: struct g_smscore_notifyees
        - smscoreapi.c: struct g_smscore_devices
        - smscoreapi.c: struct g_smscore_deviceslock
        - smscoreapi.c: struct g_smscore_registry
        - smscoreapi.c: struct g_smscore_registrylock
        - smscoreapi.c: smscore_module_init()
        - smscoreapi.c: smscore_module_exit()
        - smsdvb.c: struct g_smsdvb_clients
        - smsdvb.c: struct g_smsdvb_clientslock
      Signed-off-by: default avatarAdrian Bunk <bunk@kernel.org>
      Signed-off-by: default avatarMichael Krufky <mkrufky@linuxtv.org>
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@infradead.org>
      c5e0bd1a
  20. 20 Jul, 2008 8 commits