An error occurred fetching the project authors.
- 05 Nov, 2004 1 commit
-
-
Thomas Gleixner authored
To make spinlock/rwlock initialization consistent all over the kernel, this patch converts explicit lock-initializers into spin_lock_init() and rwlock_init() calls. Currently, spinlocks and rwlocks are initialized in two different ways: lock = SPIN_LOCK_UNLOCKED spin_lock_init(&lock) rwlock = RW_LOCK_UNLOCKED rwlock_init(&rwlock) this patch converts all explicit lock initializations to spin_lock_init() or rwlock_init(). (Besides consistency this also helps automatic lock validators and debugging code.) The conversion was done with a script, it was verified manually and it was reviewed, compiled and tested as far as possible on x86, ARM, PPC. There is no runtime overhead or actual code change resulting out of this patch, because spin_lock_init() and rwlock_init() are macros and are thus equivalent to the explicit initialization method. That's the second batch of the unifying patches. Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Acked-by: Ingo Molnar <mingo@elte.hu> Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
-
- 14 Jul, 2004 1 commit
-
-
Vernon Mauery authored
This patch adds the ability to register callback functions with the acpiphp core to set and get the current attention LED status. The reason this is needed is because there is not set ACPI standard for how this is done so each hardware platform may implement it differently. To keep hardware specific code out of acpiphp, we allow other modules to register their code with it. Signed-off-by: Vernon Mauery <vernux@us.ibm.com> Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
-
- 13 Jul, 2004 1 commit
-
-
Alexander Viro authored
-
- 17 May, 2004 1 commit
-
-
Greg Kroah-Hartman authored
-
- 11 May, 2004 1 commit
-
-
Herbert Xu authored
It oopses during modprobe becasue the first load of acpiphp didn't clean up properly.
-
- 29 Apr, 2004 2 commits
-
-
Rolf Eike Beer authored
If there is a condition with the comment "should never happen" it is a good place for a BUG() if it is ever reached.
-
Rolf Eike Beer authored
Some minor coding style fixes: -space before opening brace of function -wrap some long lines -change some identations from spaces to tabs
-
- 26 Mar, 2004 1 commit
-
-
Matthew Wilcox authored
On the error path, we currently try to up() a semaphore twice. There was also a typo in an error message.
-
- 10 Mar, 2004 1 commit
-
-
Takayoshi Kochi authored
Attached patch includes the I/O space fix and applies to 2.6.3. This should also solve the problem Maeda-san reported in January (sorry for replying so late!) Here are changes in the patch: - fix the acpiphp driver not powering down a PCI card (from Gary Hade) - fix I/O space size calculation and ISA aliasing (from Gary Hade) - fix some debug messages - only execute ACPI methods on the first existing function
-
- 04 Feb, 2004 1 commit
-
-
Rolf Eike Beer authored
These functions are only called from places marked __init or __exit, so we can mark them also.
-
- 02 Feb, 2004 1 commit
-
-
Rolf Eike Beer authored
This are some whitespace fixes for acpiphp, in most cases killing spaces before the opening brace of function declarations.
-
- 29 Jan, 2004 3 commits
-
-
Takayoshi Kochi authored
This is the pending patch that adds 'address' file to show PCI-address and a few other minor fixes. As 2.6.0 is out, I'm resending the patch. Would you mind taking this? > > > Thanks. I had a little time to try your patch today. Sorry > > > to report that it isn't working for me. > > > > > > I first powered off (successfully the 1st time) a populated slot > > > and removed and reinserted the card into the same slot. The slot > > > powered back up but I was then unable to power it off. I believe > > > the following instruction that still exists in power_off_slot() > > > may be preventing the slot from being powered off more than once. > > > func->flags &= (~FUNC_EXISTS); > > > > > > I then tried to insert an adapter in an un-populated slot. For > > > some reason (which I don't understand yet) there was an enabling > > > error which I believe caused enable_device() to exit via a path > > > that bypassed the instruction that sets the FUNC_EXISTS flag. > > > I was then unable to power off the slot which I believe was due > > > to the FUNC_EXISTS flag not being set. > > > > > > I didn't have time to definitely confirmed the above theories. > > > I'll take a closer look at this tomorrow unless you are able > > > to diagnose using my vague clues :) > > > > It turns out that both of the above mentioned problems happened > > because the call to acpiphp_configure_slot() from enable_device() > > failed after inserting the card. When this happens enable_device() > > exits without setting the FUNC_EXISTS flag for any of the slot > > functions. Subsequent attempts to power off the same slot fail > > when power_off_slot() is unable to locate a function with both > > FUNC_HAS_EJ0 and FUNC_EXISTS flags set. > > > > The patch works okay when using a card that allows > > acpiphp_configure_slot() to succeed but I believe it should > > be improved to allow the slot to be powered off following > > device enablement errors. > > Thanks for testing and comments. > I really appreciate it. > > This problem turned out to be somewhat fragile state > transition: > > a lifecycle of a slot is (if there's no error) > > function state > ---------------------------------------------------- > 0 nothing > 1 power_on_slot() -> SLOT_POWERDON > 2 enable_device() -> SLOT_POWEREDON + SLOT_ENABLED > 3 disable_device() -> SLOT_POWEREDON > 4 power_off_slot() -> nothing > > but if any error occur during enable_device(), slot will remain > SLOT_POWERDON, but some functions on the card may not have > FUNC_EXISTS flags, which will eventually prevents powering > off in power_off_slot(), state transition from 1 to 4 directly. > I.e, the FUNC_EXISTS flag introduced more states to > complicate things. > > The FUNC_EXISTS flag was introduced after some discussion > between me and Irene Zubarev, but it has no more meaning > than that the function has corresponding 'pci_dev' structure. > So I eliminated the usage of FUNC_EXISTS and the result is > the patches attached to this mail (for both 2.4 and 2.6. > I think Greg already applied the 2.4 'cleanup' patch to his tree, > but it's not in Marcelo's release so I'm re-attaching to > this mail for anyone interested in this topic. It's identical > to the one I posted earlier). > These patches don't include Gary's patch in his post last week, > so please apply separately. > > Please note that current acpiphp driver cannot handle a > PCI card that has a PCI-to-PCI bridge on it (support > for such cards is incomplete). But if it's treated as > an error, it should be recoverable anyway.
-
Martin Hicks authored
This just gets rid of a stupid compile warning.
-
Matthew Wilcox authored
When plugging a 33MHz card into a bus that's running at 66MHz, I'd like to see a better error message than: acpiphp_glue: notify_handler: unknown event type 0x5 for \_SB_.SBA0.PCI4.S2F0 The following patch would give us: Device \_SB_.SBA0.PCI4.S2F0 cannot be configured due to a frequency mismatch which I think is clearer.
-
- 27 Aug, 2003 1 commit
-
-
Greg Kroah-Hartman authored
It needs to be "Copyright (C)" not "Copyright (c)" according to the lawyers who know these things...
-
- 14 Jul, 2003 1 commit
-
-
Greg Kroah-Hartman authored
-
- 03 Jul, 2003 1 commit
-
-
Matthew Wilcox authored
Give pci_find_bus a domain argument and move its declaration to <linux/pci.h>
-
- 17 Jun, 2003 1 commit
-
-
Andy Grover authored
-
- 03 Jun, 2003 3 commits
-
-
Greg Kroah-Hartman authored
-
Greg Kroah-Hartman authored
This will let include/linux/pci.h get smaller, and is what I should have done in the first place 2 years ago...
-
Greg Kroah-Hartman authored
-
- 15 May, 2003 1 commit
-
-
Andrew Morton authored
From Badari Pulavarti. Fixes lots of error-path memleaks which the Stanford guys found.
-
- 06 May, 2003 1 commit
-
-
Greg Kroah-Hartman authored
-
- 06 Mar, 2003 1 commit
-
-
Russell King authored
- Eliminate the stack allocation of a struct pci_dev, and make pci_scan_slot() take a bus and a devfn argument. - Add "dev->multifunction" to indicate whether this is a multifunction device. - Run header fixups before inserting the new pci device into any device lists or announcing it to the drivers. - Convert some more stuff to use the list_for_each* macro(s).
-
- 27 Feb, 2003 1 commit
-
-
Andy Grover authored
(Bjorn Helgaas)
-
- 24 Feb, 2003 1 commit
-
-
Michael Hayes authored
This fixes: occured -> occurred Fixes 135 occurrences in all.
-
- 06 Feb, 2003 1 commit
-
-
Randy Dunlap authored
Here's the memory leaks patch for acpiphp_glue.c.
-
- 14 Jan, 2003 1 commit
-
-
Matthew Wilcox authored
The current ACPI code searches for a _HID of PNP0A03. This is wrong, it needs to check _CID too. But we already have generic code for doing that, so this patch converts the ACPI pcihp code to do this.
-
- 07 Jan, 2003 1 commit
-
-
Andy Grover authored
-
- 02 Nov, 2002 1 commit
-
-
Takayoshi Kouchi authored
These are updates of the acpiphp driver for 2.5. - change debug flag from 'acpiphp_debug' to 'debug' for insmod - whitespace cleanup - message cleanup
-
- 09 Oct, 2002 1 commit
-
-
Takayoshi Kouchi authored
-