- 27 Jun, 2014 9 commits
-
-
H Hartley Sweeten authored
As indicated by checkpatch.pl, "WARNING: Use of volatile is usually wrong: ...". The variables in the private data that are marked volatile don't need to be. Remove the volatile. Signed-off-by:
H Hartley Sweeten <hsweeten@visionengravers.com> Reviewed-by:
Ian Abbott <abbotti@mev.co.uk> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
H Hartley Sweeten authored
The (*insn_write) functions are expected to write 'insn->n' samples to the hardware. Fix this function so it works like the comedi core expects. The comedi core sanity checks that the samples are within the 'maxdata' range of the subdevice before calling the (*insn_write) so this function does not need to mask each sample by 's->maxdata'. Also, the wrong '*2scomp' flag in the private data was being checked to see if the sample needs to be munged before being written. Fix this. Signed-off-by:
-
H Hartley Sweeten authored
This member of the boardinfo is the number of bits in the analog output data. Convert this member into the subdevice 'maxdata', (1 << board->dabits) - 1, to avoid needing to do the calculation. Use the subdevice 'maxdata' in the driver instead of using the boardinfo and use the comedi_offset_munge() helper to convert the two's complement data to the offset binary form that the comedi core expects. Signed-off-by:
-
H Hartley Sweeten authored
This member of the boardinfo is the number of bits in the analog input data. Convert this member into the subdevice 'maxdata', (1 << board->adbits) - 1, to avoid needing to do the calculation. Use the subdevice 'maxdata' in the driver instead of using the boardinfo and use the comedi_offset_munge() helper to convert the two's complement data to the offset binary form that the comedi core expects. Signed-off-by:
-
H Hartley Sweeten authored
All unlisted members in the boardinfo declaraction will default to '0'. Remove the unnecessary code. Signed-off-by:
-
H Hartley Sweeten authored
For asethetics, move the boardinfo declaration closer to the struct definition. Signed-off-by:
-
H Hartley Sweeten authored
Move some of the functions to remove the need for the forward declarations. Signed-off-by:
-
H Hartley Sweeten authored
Introduce an inline helper to return the number of bytes that are ready to read from the comedi_async buffer. Use the helper in the comedi drivers that currently do the calculation as part of the (*poll) operation. Also, use the helper in comedi_fops where the calculation is used as part of the subdevice going nonbusy. Signed-off-by:
-
H Hartley Sweeten authored
As pointed out by Ian Abbott, the INSN_CONFIG_SET_CLOCK_SRC options should be exposed in the user header comedi.h. Signed-off-by:
-
- 26 Jun, 2014 6 commits
-
-
Himangi Saraogi authored
This patch removes a test in error handling code by adding a return path. The Coccinelle semantic match that found the problem is: // <smpl> @@ expression E,E1,E2; @@ E = alloc_etherdev(...) ... when != E = E1 if (...) { ... free_netdev(E); ... return ...; } ... when != E = E2 ( if (...) { ... when != free_netdev(E); return dev; } | * if (...) { ... when != free_netdev(E); return ...; } | register_netdev(E) ) // </smpl> Signed-off-by:Himangi Saraogi <himangi774@gmail.com> Acked-by:
Julia Lawall <julia.lawall@lip6.fr> Signed-off-by:
-
Rickard Strandqvist authored
A struct member variable is set to the same value more than once This was found using a static code analysis program called cppcheck. Signed-off-by:
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se> Signed-off-by:
-
Chaitanya Hazarey authored
Fixed the following error reported by running checkpatch.pl ERROR: trailing whitespace Signed-off-by:
Chaitanya Hazarey <c@24.io> Signed-off-by:
-
Chaitanya Hazarey authored
Fixed the following warnings issued by checkpatch.pl WARNING: please, no space before tabs Signed-off-by:
-
Chaitanya Hazarey authored
Fixed some of the following warning generated by checkpatch.pl: WARNING: Missing a blank line after declarations Signed-off-by:
-
Vincent Heuken authored
This is a patch to the serqt_usb2.c file that fixes three instances of the following checkpatch.pl warning: WARNING: else is not generally useful after a break or return Signed-off-by:
Vincent Heuken <me@vincentheuken.com> Signed-off-by:
-
- 24 Jun, 2014 25 commits
-
-
James A Shackleford authored
This patch fixes the following sparse warnings: drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c:46:20: warning: symbol 'the_ksocklnd' was not declared. Should it be static? drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c:49:19: warning: symbol 'ksocknal_ip2iface' was not declared. Should it be static? drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c:67:15: warning: symbol 'ksocknal_create_route' was not declared. Should it be static? drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c:103:1: warning: symbol 'ksocknal_create_peer' was not declared. Should it be static? drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c:218:1: warning: symbol 'ksocknal_unlink_peer_locked' was not declared. Should it be static? drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c:248:1: warning: symbol 'ksocknal_get_peer_info' was not declared. Should it be static? drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c:323:1: warning: symbol 'ksocknal_associate_route_conn_locked' was not declared. Should it be static? drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c:368:1: warning: symbol 'ksocknal_add_route_locked' was not declared. Should it be static? drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c:409:1: warning: symbol 'ksocknal_del_route_locked' was not declared. Should it be static? drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c:511:1: warning: symbol 'ksocknal_del_peer_locked' was not declared. Should it be static? drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c:566:1: warning: symbol 'ksocknal_del_peer' was not declared. Should it be static? drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c:624:14: warning: symbol 'ksocknal_get_conn_by_idx' was not declared. Should it be static? drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c:661:15: warning: symbol 'ksocknal_choose_scheduler_locked' was not declared. Should it be static? drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c:685:1: warning: symbol 'ksocknal_local_ipvec' was not declared. Should it be static? drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c:713:1: warning: symbol 'ksocknal_match_peerip' was not declared. Should it be static? drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c:745:1: warning: symbol 'ksocknal_select_ips' was not declared. Should it be static? drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c:847:1: warning: symbol 'ksocknal_create_routes' was not declared. Should it be static? drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c:997:1: warning: symbol 'ksocknal_connecting' was not declared. Should it be static? drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c:1853:1: warning: symbol 'ksocknal_push_peer' was not declared. Should it be static? drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c:1886:1: warning: symbol 'ksocknal_push' was not declared. Should it be static? drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c:1935:1: warning: symbol 'ksocknal_add_interface' was not declared. Should it be static? drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c:1997:1: warning: symbol 'ksocknal_peer_del_interface_locked' was not declared. Should it be static? drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c:2038:1: warning: symbol 'ksocknal_del_interface' was not declared. Should it be static? drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c:2213:1: warning: symbol 'ksocknal_free_buffers' was not declared. Should it be static? drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c:2256:1: warning: symbol 'ksocknal_base_shutdown' was not declared. Should it be static? drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c:2349:1: warning: symbol 'ksocknal_new_incarnation' was not declared. Should it be static? drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c:2364:1: warning: symbol 'ksocknal_base_startup' was not declared. Should it be static? drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c:2496:1: warning: symbol 'ksocknal_debug_peerhash' was not declared. Should it be static? drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c:2603:1: warning: symbol 'ksocknal_enumerate_interfaces' was not declared. Should it be static? drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c:2660:1: warning: symbol 'ksocknal_search_new_ipif' was not declared. Should it be static? drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c:2702:1: warning: symbol 'ksocknal_start_schedulers' was not declared. Should it be static? drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c:2748:1: warning: symbol 'ksocknal_net_start_threads' was not declared. Should it be static? drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c:2860:1: warning: symbol 'ksocknal_module_fini' was not declared. Should it be static? drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c:2866:1: warning: symbol 'ksocknal_module_init' was not declared. Should it be static? Signed-off-by:
James A Shackleford <shack@linux.com> Signed-off-by:
-
Jes Sorensen authored
Signed-off-by:
Jes Sorensen <Jes.Sorensen@redhat.com> Signed-off-by:
-
Jes Sorensen authored
Don't run rtw_validate_vendor_specific_ies() on anything but WLAN_EID_VENDOR_SPECIFIC. In addition use the proper WLAN_OUI_TYPE_MICROSOFT_* definitions. Signed-off-by:
-
Jes Sorensen authored
Another case using hard coded offsets counting on the presence of fixed beacon elements in the IEs array. Signed-off-by:
-
Jes Sorensen authored
Rewrite rtw_restruct_wmm_ie23a() using cfg80211_find_vendor_ie() Signed-off-by:
-
Jes Sorensen authored
This also eliminates another round of determine algorithm based on key length, followed by determine key length based on algorithm. Signed-off-by:
-
Jes Sorensen authored
We validate the parameters in cfg80211_rtw_add_key() so no need to do it all again in rtw_cfg80211_{ap_}set_encryption() Signed-off-by: -
Jes Sorensen authored
Signed-off-by:
-
Jes Sorensen authored
struct ieee_parms is obsolete, so stop passing it on. Signed-off-by:
-
Jes Sorensen authored
Signed-off-by:
-
Jes Sorensen authored
Signed-off-by:
-
Jes Sorensen authored
Signed-off-by:
-
Jes Sorensen authored
Signed-off-by:
-
Jes Sorensen authored
Signed-off-by:
-
Jes Sorensen authored
Signed-off-by:
-
Jes Sorensen authored
Signed-off-by:
-
Jes Sorensen authored
Signed-off-by:
-
Jes Sorensen authored
Use key_params->cipher to determine WEP/TKIP Signed-off-by:
-
Jes Sorensen authored
Signed-off-by:
-
Jes Sorensen authored
Signed-off-by:
-
Jes Sorensen authored
We already know which type of WEP we are using when we get here, no point trying to determine it from key_len. Signed-off-by:
-
Jes Sorensen authored
Signed-off-by:
-
Jes Sorensen authored
Signed-off-by:
-
Jes Sorensen authored
No point checking it again in here, twice! Signed-off-by:
-
Jes Sorensen authored
staging: rtl8723au: rtw_cfg80211_ap_set_encryption(): Use key_params->cipher to determine encryption Passing strings around for something we have defines for is just silly. Signed-off-by:
-
