1. 29 Jul, 2011 2 commits
    • Stephen Rothwell's avatar
      [media] ir-mce_kbd-decoder: include module.h for its facilities · ee2ce3a0
      Stephen Rothwell authored
      drivers/media/rc/ir-mce_kbd-decoder.c:446:16: error: expected declaration specifiers or '...' before string constant
      drivers/media/rc/ir-mce_kbd-decoder.c:446:1: warning: data definition has no type or storage class
      drivers/media/rc/ir-mce_kbd-decoder.c:446:1: warning: type defaults to 'int' in declaration of 'MODULE_LICENSE'
      drivers/media/rc/ir-mce_kbd-decoder.c:446:16: warning: function declaration isn't a prototype
      drivers/media/rc/ir-mce_kbd-decoder.c:447:15: error: expected declaration specifiers or '...' before string constant
      drivers/media/rc/ir-mce_kbd-decoder.c:447:1: warning: data definition has no type or storage class
      drivers/media/rc/ir-mce_kbd-decoder.c:447:1: warning: type defaults to 'int' in declaration of 'MODULE_AUTHOR'
      drivers/media/rc/ir-mce_kbd-decoder.c:447:15: warning: function declaration isn't a prototype
      drivers/media/rc/ir-mce_kbd-decoder.c:448:20: error: expected declaration specifiers or '...' before string constant
      drivers/media/rc/ir-mce_kbd-decoder.c:448:1: warning: data definition has no type or storage class
      drivers/media/rc/ir-mce_kbd-decoder.c:448:1: warning: type defaults to 'int' in declaration of 'MODULE_DESCRIPTION'
      drivers/media/rc/ir-mce_kbd-decoder.c:448:20: warning: function declaration isn't a prototype
      Signed-off-by: default avatarStephen Rothwell <sfr@canb.auug.org.au>
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
      ee2ce3a0
    • Stephen Rothwell's avatar
      [media] ov5642: include module.h for its facilities · d208c97c
      Stephen Rothwell authored
      drivers/media/video/ov5642.c:985:1: warning: data definition has no type or storage class
      drivers/media/video/ov5642.c:985:1: warning: type defaults to 'int' in declaration of 'MODULE_DEVICE_TABLE'
      drivers/media/video/ov5642.c:985:1: warning: parameter names (without types) in function declaration
      drivers/media/video/ov5642.c: In function 'ov5642_mod_init':
      drivers/media/video/ov5642.c:998:9: error: 'THIS_MODULE' undeclared (first use in this function)
      drivers/media/video/ov5642.c:998:9: note: each undeclared identifier is reported only once for each function it appears in
      drivers/media/video/ov5642.c: At top level:
      drivers/media/video/ov5642.c:1009:20: error: expected declaration specifiers or '...' before string constant
      drivers/media/video/ov5642.c:1009:1: warning: data definition has no type or storage class
      drivers/media/video/ov5642.c:1009:1: warning: type defaults to 'int' in declaration of 'MODULE_DESCRIPTION'
      drivers/media/video/ov5642.c:1009:20: warning: function declaration isn't a prototype
      drivers/media/video/ov5642.c:1010:15: error: expected declaration specifiers or '...' before string constant
      drivers/media/video/ov5642.c:1010:1: warning: data definition has no type or storage class
      drivers/media/video/ov5642.c:1010:1: warning: type defaults to 'int' in declaration of 'MODULE_AUTHOR'
      drivers/media/video/ov5642.c:1010:15: warning: function declaration isn't a prototype
      drivers/media/video/ov5642.c:1011:16: error: expected declaration specifiers or '...' before string constant
      drivers/media/video/ov5642.c:1011:1: warning: data definition has no type or storage class
      drivers/media/video/ov5642.c:1011:1: warning: type defaults to 'int' in declaration of 'MODULE_LICENSE'
      drivers/media/video/ov5642.c:1011:16: warning: function declaration isn't a prototype
      drivers/media/video/ov5642.c: In function 'ov5642_mod_init':
      drivers/media/video/ov5642.c:999:1: warning: control reaches end of non-void function
      Signed-off-by: default avatarStephen Rothwell <sfr@canb.auug.org.au>
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
      d208c97c
  2. 28 Jul, 2011 2 commits
    • Mauro Carvalho Chehab's avatar
      [media] em28xx: Fix DVB-C maxsize for em2884 · f7acc4bb
      Mauro Carvalho Chehab authored
      The logic at em28xx_isoc_dvb_max_packetsize() sucks, at least for newer
      the needed packet size. Yet, it is better than nothing.
      
      Rewrite the code in order to change the default to 752 for em2884 and
      newer chips and provide a better way to handle per-chipset specifics.
      
      For em2874, the current default should be enough, as the only em2874
      board is currently a 1-seg ISDB-T board, so, it needs only a limited
      amount of bandwidth.
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
      f7acc4bb
    • Mauro Carvalho Chehab's avatar
      [media] tda18271c2dd: Fix saw filter configuration for DVB-C @6MHz · cf845297
      Mauro Carvalho Chehab authored
      Currently, the driver assumes that all QAM carriers are spaced with
      8MHz. This is wrong, and may decrease QoS on Countries like Brazil,
      that have DVB-C carriers with 6MHz-spaced.
      
      Fortunately, both ITU-T J-83 and EN 300 429 specifies a way to
      associate the symbol rate with the bandwidth needed for it.
      
      For ITU-T J-83 2007 annex A, the maximum symbol rate for 6 MHz is:
      	6 MHz / 1.15 = 5217391 Bauds
      For  ITU-T J-83 2007 annex C, the maximum symbol rate for 6 MHz is:
      	6 MHz / 1.13 = 5309735 Bauds.
      
      As this tuner is currently used only for DRX-K, and it is currently
      hard-coded to annex A, I've opted to use the roll-off factor of 0.15,
      instead of 0.13.
      
      If we ever support annex C, the better would be to add a DVB S2API
      call to allow changing between Annex A and C, and add the 0.13 roll-off
      factor to it.
      
      This code is currently being used on other frontends, so I think we
      should later add a core function with this code, to warrant that
      it will be properly implemented everywhere.
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
      cf845297
  3. 27 Jul, 2011 36 commits