- 25 Oct, 2015 40 commits
-
-
Amitoj Kaur Chawla authored
Replace uint32_t with u32 consistent with Linux kernel coding practice. Problem found using checkpatch.pl Signed-off-by:
Amitoj Kaur Chawla <amitoj1606@gmail.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Amitoj Kaur Chawla authored
Problem found using checkpatch.pl WARNING: Use #include <linux/io.h> instead of <asm/io.h> WARNING: Use #include <linux/uaccess.h> instead of <asm/uaccess.h> Signed-off-by:
-
Ioana Ciornei authored
This patch removes multiple blank lines in order to follow linux kernel coding style. Signed-off-by:
Ioana Ciornei <ciorneiioana@gmail.com> Signed-off-by:
-
Ioana Ciornei authored
This patch converts sizeof(TYPE) to sizeof(VAR) when used as a kzalloc/kmaloc argument. Signed-off-by:
-
Ioana Ciornei authored
This patch add spaces around binary operators in order to follow kernel coding style. Signed-off-by:
-
Ioana Ciornei authored
This patch converts explicit NULL comparison to its shorter equivalent form. Done with coccinelle semantic patch: @@ expression e; @@ - e == NULL + !e Signed-off-by:
-
Ioana Ciornei authored
Indent parameters and arguments passed to function calls to match open paranthesis Signed-off-by:
-
Cristina Moraru authored
Replace kmalloc with specialized function kmalloc_array when the size is a multiplication of: number_of_elements * size_of_element Signed-off-by:
Cristina Moraru <cristina.moraru09@gmail.com> Signed-off-by:
-
Nilesh Kokane authored
Braces not needed for single statement block Signed-off-by:
Nilesh Kokane <Nilesh.Kokane05@gmail.com> Signed-off-by:
-
Nilesh Kokane authored
Return function in void function is not needed. Signed-off-by:
-
Nilesh Kokane authored
Fixed a coding style issue. Signed-off-by:
-
Luis de Bethencourt authored
The code is correct, the indentation is misleading. Only the the return rc is part of the conditional statement if rc != 0. Fix a smatch warning: drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c:2157 kiblnd_hdev_setup_mrs() warn: curly braces intended? Signed-off-by:
Luis de Bethencourt <luisbg@osg.samsung.com> Signed-off-by:
-
James Simmons authored
Update struct netstrfns to use C99 initializers. Remove old LND types from the netstrfns table, as they are long obsolete and shouldn't be needed even for interop anymore. Signed-off-by:
James Simmons <uja.ornl@yahoo.com> Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-6210 Reviewed-on: http://review.whamcloud.com/15088Reviewed-by:
frank zago <fzago@cray.com> Reviewed-by:
Andreas Dilger <andreas.dilger@intel.com> Signed-off-by:
-
Frederic Saunier authored
Currently NID string handling test for the last entry, and last entry has .nf_type == (__u32) -1. If we ask for a non existent LND we hit the last entry which then calls a strlen on a NULL which causes a error. We can avoid this problem if we just remove the last entry since it is not used for anything except as a last entry marker. Signed-off-by:
Frederic Saunier <frederic.saunier@atos.net> Signed-off-by:
Dmitry Eremin <dmitry.eremin@intel.com> Reviewed-by:
Oleg Drokin <oleg.drokin@intel.com> Signed-off-by:
-
Dmitry Eremin authored
Provide duplicates with separate buffers for libcfs_*2str() functions. Replace libcfs_nid2str() with libcfs_nid2str_r() function in critical places. Provide buffer size for nf_addr2str functions. Use __u32 as nf_type always Signed-off-by:
John L. Hammond <john.hammond@intel.com> Reviewed-by:
-
Joshua Walgenbach authored
This is a partial backport of the NID range management added in for nodemap. We only backport the libcfs related parts here. Signed-off-by:
Joshua Walgenbach <jjw@iu.edu> Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-3527 Reviewed-on: http://review.whamcloud.com/8057Reviewed-by:
Andrew Perepechko <andrew_perepechko@xyratex.com> Reviewed-by:
Ken Hornstein <kenh@cmf.nrl.navy.mil> Signed-off-by:
-
James Simmons authored
Since forward declarations are frowned on upstream we move the NID range handling to near the start of the nidstring.c file. Signed-off-by:
Bob Glossman <bob.glossman@intel.com> Reviewed-by:
-
James Simmons authored
Both of cfs_ip_addr_parse and cfs_ip_addr_match which are located in libcfs kernel module are used only for LNet so move this into the nidstring handling code where it belongs. Also create user land versions of these functions in the libcfs user land library. Signed-off-by:
-
James Simmons authored
The reason struct netstrfns exist in nidstrings.c was to avoid forward decleration errors. The best way to handle this instead is to move this structure to a header file. Since this structure is used in the userland utilities as well so we place it in nidstr.h which is exposed to userland. Signed-off-by:
-
James Simmons authored
No need to have a one line wrapper in libcfs that only is used to delete a list which is only done once in the LNet layer. Signed-off-by:
James Simmons <jsimmons@infradead.org> Signed-off-by:
-
James Simmons authored
All the function libcfs_init_string did was initialize a spinlock. We can initialize the spinlock statically instead. Signed-off-by:
-
James Simmons authored
Moved the source file nidstring.c from libcfs to lnet since that is the only place it is used. With the move of nidstring to lnet some functions in libcfs need to be exported. In later patches those functions that are only used by LNet also will be moved to the LNet layer. Also add in missing MAX_NUMERIC_VALUE defination. Signed-off-by:
-
Gregoire Pichon authored
The libcfs already provides services to parse a string into a nidlist and to match a nid into a nidlist. This patch implements a service that prints a nidlist into a buffer. This is required for instance to print the nosquash_nids parameter of the MDT procfs component. Additionally, this patch fixes a bug in return code of parse_addrange() routine, so that parsing of nids including a * character works fine ('*@elan' for instance). Signed-off-by:Gregoire Pichon <gregoire.pichon@bull.net> Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-1778 Reviewed-on: http://review.whamcloud.com/9221Reviewed-by:
Liang Zhen <liang.zhen@intel.com> Reviewed-by:
-
Mike Rapoport authored
The OBD_SLAB_ALLOC* and OBD_SLAB_FREE* macros are not used and can be removed. Signed-off-by:
Mike Rapoport <mike.rapoport@gmail.com> Signed-off-by:
-
Mike Rapoport authored
Use kmem_cache_free directly instead of wrapping macro. Signed-off-by:
-
Mike Rapoport authored
Use kmem_cache_free directly instead of wrapping macro. Signed-off-by:
-
Mike Rapoport authored
Use kmem_cache_free directly instead of wrapping macro. Signed-off-by:
-
Mike Rapoport authored
The OBD_SLAB_ALLOC_PTR_GFP macro expands to call to kmem_cache_alloc, which may be used directly. Signed-off-by:
-
Mike Rapoport authored
The OBD_SLAB_ALLOC_PTR macro expands to call to kmem_cache_alloc, which may be used directly. Signed-off-by:
-
Mike Rapoport authored
The OBDO_ALLOC and OBDO_FREE macros are not used and can be removed. Signed-off-by:
-
Mike Rapoport authored
Use kmem_cache_free directly instead of wrapping macro. Signed-off-by:
-
Mike Rapoport authored
Use direct call to kmem_cache_alloc instead of wrapping macro Signed-off-by:
-
Mike Rapoport authored
The OBD_SLAB_CPT_ALLOC* macros are not used and can be removed Signed-off-by:
-
Sanne Wouda authored
Fix lustre/ptlrpc/client.c block comments following the Coding Style preferred format for multi-line and single-line comments: /* * This is the preferred style for multi-line * comments in the Linux kernel source code. * Please use it consistently. * * Description: A column of asterisks on the left side, * with beginning and ending almost-blank lines. */ Included some minor textual fixes to get some comments on a single line. Signed-off-by:Sanne Wouda <snnw@gruttepier.net> Signed-off-by:
-
Shivani Bhardwaj authored
Remove multiple assignments by factorizing them. Fix checkpatch CHECK: multiple assignments should be avoided Signed-off-by:
Shivani Bhardwaj <shivanib134@gmail.com> Signed-off-by:
-
Geliang Tang authored
This patch makes sptlrpc_flavor_has_bulk return boolean, since this function only uses either one or zero as its return value. Signed-off-by:
Geliang Tang <geliangtang@163.com> Signed-off-by:
-
Shivani Bhardwaj authored
Variable rc is not tested for negative values and hence a check should be included. Also, a check for variable val should be introduced. Signed-off-by:
-
Cristina Moraru authored
Replace __aligned__((packed)) with __packed in order to follow the best practices and to fix checkpatch.pl warning: 'WARNING: __packed is preferred over __attribute__((packed))' Signed-off-by:
-
Eva Rachel Retuya authored
Remove the unneeded cast to 'int' since 'retval' is originally declared as 'int'. Signed-off-by:
Eva Rachel Retuya <eraretuya@gmail.com> Signed-off-by:
-
Eva Rachel Retuya authored
Replace remaining instances of 'uint8_t' with 'u8' for consistency since 'u8' and 'u16' are already being used in other parts of the code. Replace also 'uint32_t' with 'u32' on the header file. Checkpatch pointed out this issue. CHECK: Prefer kernel type 'u8' over 'uint8_t' CHECK: Prefer kernel type 'u32' over 'uint32_t' Signed-off-by:
-
