Commits · f7b7f375491b0016004b2c50118160de57908278 · nexedi / linux

02 Sep, 2016 1 commit

usb: core: use IS_ENABLED() instead of checking for built-in or module · f7b7f375

Javier Martinez Canillas authored Aug 18, 2016

The IS_ENABLED() macro checks if a Kconfig symbol has been enabled either
built-in or as a module, use that macro instead of open coding the same.

Using the macro makes the code more readable by helping abstract away some
of the Kconfig built-in and module enable details.
Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

f7b7f375

30 Aug, 2016 39 commits

usb: usbip: vudc: fix left shift overflow · 238b7bd9

Nicolas Iooss authored Aug 23, 2016

In v_recv_cmd_submit(), urb_p->urb->pipe has the type unsigned int
(which is 32-bit long on x86_64) but 11<<30 results in a 34-bit integer.
Therefore the 2 leading bits are truncated and

    urb_p->urb->pipe &= ~(11 << 30);

has the same meaning as

    urb_p->urb->pipe &= ~(3 << 30);

This second statement seems to be how the code was intended to be
written, as PIPE_ constants have values between 0 and 3.

The overflow has been detected with a clang warning:

    drivers/usb/usbip/vudc_rx.c:145:27: warning: signed shift result
    (0x2C0000000) requires 35 bits to represent, but 'int' only has 32
    bits [-Wshift-overflow]
            urb_p->urb->pipe &= ~(11 << 30);
                                  ~~ ^  ~~

Fixes: 79c02cb1 ("usbip: vudc: Add vudc_rx")
Signed-off-by: Nicolas Iooss <nicolas.iooss_linux@m4x.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

238b7bd9

USB: ohci-omap - avoid including mach/irqs.h · b68824b1

Russell King authored Aug 19, 2016

ohci-omap doesn't need to include mach/irqs.h - nothing within this
driver needs anything from this header file.  Remove this include.
Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
Acked-by: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

b68824b1

usb: ohci-sa1111: remove mach/hardware.h include · 70efb643

Russell King authored Aug 26, 2016

The mach/hardware.h include doesn't seem to be necessary to build
ohci-sa1111, so let's remove it to kill off an unnecessary platform
specific include.
Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

70efb643

usb: ohci-sa1111: remove machine_has_neponset() · 6ebb8f0f

Russell King authored Aug 26, 2016

The neponset is a daughter board for the Assabet platform, which has a
SA1111 chip on it.  If we're initialising the SA1111 OHCI, and we're
part of a neponset, the host platform must be an Assabet.

This allows us to eliminate machine_has_neponset() from this driver,
replacing it instead with machine_is_assabet(), and killing the
mach/assabet.h include.
Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
Acked-by: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

6ebb8f0f

usb: ohci-at91: Forcibly suspend ports while USB suspend · 2e2aa1bc

Wenyou Yang authored Aug 23, 2016

The usb controller does not manage correctly the suspend mode for
the ehci. In echi mode, there is no way to suspend without any
device connected to it. This is why this specific control is added
to fix this issue. Since the suspend mode works in ohci mode, this
specific control works by suspend the usb controller in ohci mode.

This specific control is by setting the SUSPEND_A/B/C fields of
SFR_OHCIICR(OHCI Interrupt Configuration Register) in the SFR
while the OHCI USB suspend.

This set operation must be done before the USB clock disabled,
clear operation after the USB clock enabled.
Signed-off-by: Wenyou Yang <wenyou.yang@atmel.com>
Reviewed-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
Acked-by: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

2e2aa1bc

usb-storage: MAINTAINERS: Alan Stern is the new maintainer · fc8b690d

Alan Stern authored Aug 25, 2016

At Matt Dharm's request, I am taking over maintainership of the
usb-storage driver.
Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
Acked-by: Matthew Dharm <mdharm-usb@one-eyed-alien.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

fc8b690d

usb: wusbcore: wa-nep: don't print on ENOMEM · 84f11ce5

Wolfram Sang authored Aug 25, 2016

All kmalloc-based functions print enough information on failures.
Signed-off-by: Wolfram Sang <wsa-dev@sang-engineering.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

84f11ce5

usb: wusbcore: security: don't print on ENOMEM · d919523f

Wolfram Sang authored Aug 25, 2016

All kmalloc-based functions print enough information on failures.
Signed-off-by: Wolfram Sang <wsa-dev@sang-engineering.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

d919523f

usb: wusbcore: crypto: don't print on ENOMEM · 90b61386

Wolfram Sang authored Aug 25, 2016

All kmalloc-based functions print enough information on failures.
Signed-off-by: Wolfram Sang <wsa-dev@sang-engineering.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

90b61386

usb: usb-skeleton: don't print on ENOMEM · dc0c32c9

Wolfram Sang authored Aug 25, 2016

All kmalloc-based functions print enough information on failures.
Signed-off-by: Wolfram Sang <wsa-dev@sang-engineering.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

dc0c32c9

usb: storage: sddr09: don't print on ENOMEM · fd233925

Wolfram Sang authored Aug 25, 2016

All kmalloc-based functions print enough information on failures.
Signed-off-by: Wolfram Sang <wsa-dev@sang-engineering.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

fd233925

usb: storage: alauda: don't print on ENOMEM · e5cdac92

Wolfram Sang authored Aug 25, 2016

All kmalloc-based functions print enough information on failures.
Signed-off-by: Wolfram Sang <wsa-dev@sang-engineering.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

e5cdac92

usb: renesas_usbhs: pipe: don't print on ENOMEM · c34515f8

Wolfram Sang authored Aug 25, 2016

All kmalloc-based functions print enough information on failures.
Signed-off-by: Wolfram Sang <wsa-dev@sang-engineering.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

c34515f8

usb: renesas_usbhs: mod_host: don't print on ENOMEM · 93b6cb45

Wolfram Sang authored Aug 25, 2016

All kmalloc-based functions print enough information on failures.
Signed-off-by: Wolfram Sang <wsa-dev@sang-engineering.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

93b6cb45

usb: renesas_usbhs: mod_gadget: don't print on ENOMEM · 7d80e4be

Wolfram Sang authored Aug 25, 2016

All kmalloc-based functions print enough information on failures.
Signed-off-by: Wolfram Sang <wsa-dev@sang-engineering.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

7d80e4be

usb: musb: da8xx: don't print on ENOMEM · 92c0c490

Wolfram Sang authored Aug 25, 2016

All kmalloc-based functions print enough information on failures.
Signed-off-by: Wolfram Sang <wsa-dev@sang-engineering.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

92c0c490

usb: musb: am35x: don't print on ENOMEM · 906f5dc9

Wolfram Sang authored Aug 25, 2016

All kmalloc-based functions print enough information on failures.
Signed-off-by: Wolfram Sang <wsa-dev@sang-engineering.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

906f5dc9

usb: misc: yurex: don't print on ENOMEM · 0c2bc5c2

Wolfram Sang authored Aug 25, 2016

All kmalloc-based functions print enough information on failures.
Signed-off-by: Wolfram Sang <wsa-dev@sang-engineering.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

0c2bc5c2

usb: misc: uss720: don't print on ENOMEM · c9220ba5

Wolfram Sang authored Aug 25, 2016

All kmalloc-based functions print enough information on failures.
Signed-off-by: Wolfram Sang <wsa-dev@sang-engineering.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

c9220ba5

usb: misc: usbsevseg: don't print on ENOMEM · bcf0848d

Wolfram Sang authored Aug 25, 2016

All kmalloc-based functions print enough information on failures.
Signed-off-by: Wolfram Sang <wsa-dev@sang-engineering.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

bcf0848d

usb: misc: usblcd: don't print on ENOMEM · a1841732

Wolfram Sang authored Aug 25, 2016

All kmalloc-based functions print enough information on failures.
Signed-off-by: Wolfram Sang <wsa-dev@sang-engineering.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

a1841732

usb: misc: trancevibrator: don't print on ENOMEM · 58e61402

Wolfram Sang authored Aug 25, 2016

All kmalloc-based functions print enough information on failures.
Signed-off-by: Wolfram Sang <wsa-dev@sang-engineering.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

58e61402

usb: misc: lvstest: don't print on ENOMEM · 5c47fd61

Wolfram Sang authored Aug 25, 2016

All kmalloc-based functions print enough information on failures.
Signed-off-by: Wolfram Sang <wsa-dev@sang-engineering.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

5c47fd61

usb: misc: legousbtower: don't print on ENOMEM · 49d8ffab

Wolfram Sang authored Aug 25, 2016

All kmalloc-based functions print enough information on failures.
Signed-off-by: Wolfram Sang <wsa-dev@sang-engineering.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

49d8ffab

usb: misc: ldusb: don't print on ENOMEM · 6714ffae

Wolfram Sang authored Aug 25, 2016

All kmalloc-based functions print enough information on failures.
Signed-off-by: Wolfram Sang <wsa-dev@sang-engineering.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

6714ffae

usb: misc: iowarrior: don't print on ENOMEM · 3cfb4842

Wolfram Sang authored Aug 25, 2016

All kmalloc-based functions print enough information on failures.
Signed-off-by: Wolfram Sang <wsa-dev@sang-engineering.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

3cfb4842

usb: misc: idmouse: don't print on ENOMEM · 081e303e

Wolfram Sang authored Aug 25, 2016

All kmalloc-based functions print enough information on failures.
Signed-off-by: Wolfram Sang <wsa-dev@sang-engineering.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

081e303e

usb: misc: ftdi-elan: don't print on ENOMEM · 524fd353

Wolfram Sang authored Aug 25, 2016

All kmalloc-based functions print enough information on failures.
Signed-off-by: Wolfram Sang <wsa-dev@sang-engineering.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

524fd353

usb: misc: cytherm: don't print on ENOMEM · 29a99df1

Wolfram Sang authored Aug 25, 2016

All kmalloc-based functions print enough information on failures.
Signed-off-by: Wolfram Sang <wsa-dev@sang-engineering.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

29a99df1

usb: misc: cypress_cy7c63: don't print on ENOMEM · e83c06e9

Wolfram Sang authored Aug 25, 2016

All kmalloc-based functions print enough information on failures.
Signed-off-by: Wolfram Sang <wsa-dev@sang-engineering.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

e83c06e9

usb: misc: appledisplay: don't print on ENOMEM · d7f040e9

Wolfram Sang authored Aug 25, 2016

All kmalloc-based functions print enough information on failures.
Signed-off-by: Wolfram Sang <wsa-dev@sang-engineering.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

d7f040e9

usb: misc: adutux: don't print on ENOMEM · a02b55c8

Wolfram Sang authored Aug 25, 2016

All kmalloc-based functions print enough information on failures.
Signed-off-by: Wolfram Sang <wsa-dev@sang-engineering.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

a02b55c8

usb: host: xhci: don't print on ENOMEM · f4c46f11

Wolfram Sang authored Aug 25, 2016

All kmalloc-based functions print enough information on failures.
Signed-off-by: Wolfram Sang <wsa-dev@sang-engineering.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

f4c46f11

usb: host: xhci-tegra: don't print on ENOMEM · a35234b2

Wolfram Sang authored Aug 25, 2016

All kmalloc-based functions print enough information on failures.
Signed-off-by: Wolfram Sang <wsa-dev@sang-engineering.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

a35234b2

usb: host: uhci-hcd: don't print on ENOMEM · 314e6725

Wolfram Sang authored Aug 25, 2016

All kmalloc-based functions print enough information on failures.
Signed-off-by: Wolfram Sang <wsa-dev@sang-engineering.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

314e6725

usb: host: max3421-hcd: don't print on ENOMEM · 13dcf780

Wolfram Sang authored Aug 25, 2016

All kmalloc-based functions print enough information on failures.
Signed-off-by: Wolfram Sang <wsa-dev@sang-engineering.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

13dcf780

usb: host: fhci-hcd: don't print on ENOMEM · 2652de71

Wolfram Sang authored Aug 25, 2016

All kmalloc-based functions print enough information on failures.
Signed-off-by: Wolfram Sang <wsa-dev@sang-engineering.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

2652de71

usb: gadget: udc: udc-xilinx: don't print on ENOMEM · c86af711

Wolfram Sang authored Aug 25, 2016

All kmalloc-based functions print enough information on failures.
Signed-off-by: Wolfram Sang <wsa-dev@sang-engineering.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

c86af711

usb: gadget: udc: goku_udc: don't print on ENOMEM · e2088ec0

Wolfram Sang authored Aug 25, 2016

All kmalloc-based functions print enough information on failures.
Signed-off-by: Wolfram Sang <wsa-dev@sang-engineering.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

e2088ec0