- 10 Oct, 2019 24 commits
-
-
Wambui Karuga authored
Fix the following warning generated by sparse in drivers/staging/octeon/ethernet-tx.c: drivers/staging/octeon/ethernet-tx.c:563:50: warning: incorrect type in assignment (different base types) drivers/staging/octeon/ethernet-tx.c:563:50: expected unsigned short [usertype] hw_chksum drivers/staging/octeon/ethernet-tx.c:563:50: got restricted __wsum [usertype] csum Warning generated by running: make C=2 CF="-D__CHECK_ENDIAN__" drivers/staging/octeon/ Signed-off-by:
Wambui Karuga <wambui.karugax@gmail.com> Link: https://lore.kernel.org/r/20191010043815.14027-1-wambui.karugax@gmail.comSigned-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Wambui Karuga authored
Fixes checkpatch.pl "CHECK Alignment should match open parenthesis" on drivers/staging/rtl8712/rtl8712_recv.c:122 Signed-off-by:
-
Javier F. Arias authored
Fix the style in definitions where commented code was previously removed for an improved code readability. Signed-off-by:
Javier F. Arias <jarias.linux@gmail.com> Link: https://lore.kernel.org/r/fc488562c0ddf3fa8a59e86be9b33506496ccd0c.1570672544.git.jarias.linux@gmail.comSigned-off-by:
-
Javier F. Arias authored
Remove space before tabs to fix checkpatch warning. Issue found by checkpatch. Signed-off-by:
-
Javier F. Arias authored
Remove duplicate blank lines. Signed-off-by:
-
Javier F. Arias authored
Remove commented code for a cleaner file. Issue found by checkpatch. Signed-off-by:
-
Javier F. Arias authored
Fix incorrect type in declaration to solve the warnings 'incorrect type in argument 2' in the rtw_get_wpa_ie and rtw_get_wpa_ie function calls, as both expect the same variable in argument 2 with the type int *. Issue found by Sparse. Signed-off-by:
-
Javier F. Arias authored
Concatenated strings should use spaces between elements. Issue found by checkpatch. Signed-off-by:
-
Javier F. Arias authored
Fix the wrapping style used for the function call. Issue found by checkpatch. Signed-off-by:
-
Javier F. Arias authored
Break last two function call arguments into two separate lines. Issue found by checkpatch. Signed-off-by:
-
Hans de Goede authored
rtl8723bs had 2 private file operation helpers: rtw_is_file_readable() rtw_retrive_from_file() These were only used by the removed phy_Config*WithParaFile() functions, so they can be removed now. Signed-off-by:
Hans de Goede <hdegoede@redhat.com> Link: https://lore.kernel.org/r/20191009123223.163241-5-hdegoede@redhat.comSigned-off-by:
-
Hans de Goede authored
The phy_Config*WithParaFile() functions were the only user of this function. Signed-off-by:
-
Hans de Goede authored
Now that the phy_Config*WithParaFile() functions have been removed nothing is using these module-parameters and defines anymore. Signed-off-by:
-
Hans de Goede authored
These are no longer used, so remove them and also remove various struct definitions only used by these functions. Signed-off-by:
-
Hans de Goede authored
The rtl8723bs driver tries to load various parameters from disk, circumventing the standard firmware loader mechanism and using DIY code for this. No devices which run the mainline kernel ship with these files and even if these files were present then they still would not be loaded without additional module parameters. To be precise the following 3 conditions must all 3 be true for on disk parameters to be used: 1) The rtw_load_phy_file modparam must contain the mask for the type, this defaults to(LOAD_BB_PG_PARA_FILE | LOAD_RF_TXPWR_LMT_PARA_FILE) so with the default settings this condition is only true for: phy_ConfigBBWithPgParaFile() PHY_ConfigRFWithPowerLimitTableParaFile(); and 2) rtw_phy_file_path modparam must be set to say "/lib/firmware/"; and 3) Store a /lib/firmware/rtl8723b/XXX file in the expected format. In practice all 3 being true never happens, so the phy_Config*With*ParaFile() calls are nops, remove them. The actual code implementing them will be removed in a separate patch. Note the ODM_ConfigRFWithHeaderFile() and ODM_ConfigBBWithHeaderFile() functions always return HAL_STATUS_SUCCESS, this patch makes use of this to simplify the new code without the phy_Config*With*ParaFile() calls. Signed-off-by:
-
zhengbin authored
Fixes gcc '-Wunused-but-set-variable' warning: drivers/staging/rtl8723bs/core/rtw_xmit.c: In function update_attrib: drivers/staging/rtl8723bs/core/rtw_xmit.c:680:7: warning: variable i set but not used [-Wunused-but-set-variable] It is not used since commit 554c0a3a ("staging: Add rtl8723bs sdio wifi driver") Reported-by:
Hulk Robot <hulkci@huawei.com> Signed-off-by:
zhengbin <zhengbin13@huawei.com> Link: https://lore.kernel.org/r/1570578905-95675-1-git-send-email-zhengbin13@huawei.comSigned-off-by:
-
Javier F. Arias authored
Fix warning by removing space before tab. Signed-off-by:
-
Javier F. Arias authored
Replace the hardcoded function name with its predefined identifier. Signed-off-by:
Julia Lawall <julia.lawall@lip6.fr> Link: https://lore.kernel.org/r/20191008214851.p4w7cbpuldnwkne4@gmail.comSigned-off-by:
-
Nachammai Karuppiah authored
Remove typecast in the call to kfree as it is not needed. Issue found using the below coccinelle script with options -I and --recursive-includes, @@ type t1; expression *e; @@ -kfree((t1 *)e); +kfree(e); Signed-off-by:
Nachammai Karuppiah <nachukannan@gmail.com> Acked-by:
-
zhengbin authored
Fix sparse warnings: drivers/staging/wfx/sta.c:269:6: warning: symbol 'wfx_update_filtering_work' was not declared. Should it be static? drivers/staging/wfx/sta.c:475:6: warning: symbol 'wfx_event_handler_work' was not declared. Should it be static? drivers/staging/wfx/sta.c:521:6: warning: symbol 'wfx_bss_loss_work' was not declared. Should it be static? drivers/staging/wfx/sta.c:528:6: warning: symbol 'wfx_bss_params_work' was not declared. Should it be static? drivers/staging/wfx/sta.c:539:6: warning: symbol 'wfx_set_beacon_wakeup_period_work' was not declared. Should it be static? drivers/staging/wfx/sta.c:732:6: warning: symbol 'wfx_unjoin_work' was not declared. Should it be static? drivers/staging/wfx/sta.c:794:6: warning: symbol 'wfx_set_cts_work' was not declared. Should it be static? drivers/staging/wfx/sta.c:1234:6: warning: symbol 'wfx_set_tim_work' was not declared. Should it be static? Reported-by:
Jérôme Pouiller <jerome.pouiller@silabs.com> Link: https://lore.kernel.org/r/1570629030-29888-4-git-send-email-zhengbin13@huawei.comSigned-off-by:
-
zhengbin authored
Fix sparse warnings: drivers/staging/wfx/queue.c:218:16: warning: symbol 'wfx_tx_queue_get' was not declared. Should it be static? Reported-by:
-
zhengbin authored
Fix sparse warnings: drivers/staging/wfx/fwio.c:83:5: warning: symbol 'sram_write_dma_safe' was not declared. Should it be static? drivers/staging/wfx/fwio.c:229:5: warning: symbol 'load_firmware_secure' was not declared. Should it be static? Reported-by:
-
Colin Ian King authored
The memset appears to have the 2nd and 3rd arguments in the wrong order, fix this by swapping these around into the correct order. Addresses-Coverity: ("Memset fill truncated") Fixes: 4f8b7fab ("staging: wfx: allow to send commands to chip") Signed-off-by:Colin Ian King <colin.king@canonical.com> Reviewed-by:
-
Wambui Karuga authored
Remove unnecessary variable `val` in kp_spi_read_reg() that only holds the return value from readq(). Issue found by coccinelle using the script: @@ local idexpression ret; expression e; @@ -ret = +return e; -return ret; Signed-off-by:
-
- 08 Oct, 2019 16 commits
-
-
zhengbin authored
Fixes gcc '-Wunused-but-set-variable' warning: drivers/staging/comedi/drivers/dt3000.c: In function dt3k_ai_insn_read: drivers/staging/comedi/drivers/dt3000.c:511:27: warning: variable aref set but not used [-Wunused-but-set-variable] It is not used since commit 2e310235 ("staging: comedi: dt3000: rename dt3k_ai_insn()") Reported-by:
Dan Carpenter <dan.carpenter@oracle.com> Reviewed-by:
Ian Abbott <abbotti@mev.co.uk> Link: https://lore.kernel.org/r/1570520515-2186-7-git-send-email-zhengbin13@huawei.comSigned-off-by:
-
Matteo Croce authored
Since commit ad67b74d ("printk: hash addresses printed with %p"), an obfuscated kernel pointer is printed at boot: vchiq: vchiq_init_state: slot_zero = (____ptrval____) Remove the the print completely, as it's useless without the address. Signed-off-by:
Matteo Croce <mcroce@redhat.com> Link: https://lore.kernel.org/r/20191008123346.3931-1-mcroce@redhat.comSigned-off-by:
-
zhengbin authored
Fixes gcc '-Wunused-but-set-variable' warning: drivers/staging/sm750fb/ddk750_chip.c: In function set_chip_clock: drivers/staging/sm750fb/ddk750_chip.c:59:15: warning: variable actual_mx_clk set but not used [-Wunused-but-set-variable] It is not used since commit f0977109 ("staging: sm750fb: lower case to fix camelcase checkpatch warning") Reported-by:
-
zhengbin authored
Fixes gcc '-Wunused-but-set-variable' warning: drivers/staging/sm750fb/ddk750_mode.c: In function ddk750_setModeTiming: drivers/staging/sm750fb/ddk750_mode.c:212:15: warning: variable uiActualPixelClk set but not used [-Wunused-but-set-variable] It is not used since commit 81dee67e ("staging: sm750fb: add sm750 to staging") Reported-by:
-
zhengbin authored
If vchi_msg_dequeue return -1, variable m is not assigined, need to return. Reported-by:
-
Paul Burton authored
When building for a non-Cavium MIPS system with COMPILE_TEST=y, the Octeon ethernet driver hits a number of issues due to use of macros provided only for CONFIG_CAVIUM_OCTEON_SOC=y configurations. For example: drivers/staging/octeon/ethernet-rx.c:190:6: error: 'CONFIG_CAVIUM_OCTEON_CVMSEG_SIZE' undeclared (first use in this function) drivers/staging/octeon/ethernet-rx.c:472:25: error: 'OCTEON_IRQ_WORKQ0' undeclared (first use in this function) These come from various asm/ headers that a non-Octeon build will be using a non-Octeon version of. Fix this by using the octeon-stubs.h header for non-Cavium MIPS builds, and only using the real asm/octeon/ headers when building a Cavium Octeon kernel configuration. This requires that octeon-stubs.h doesn't redefine XKPHYS_TO_PHYS, which is defined for MIPS by asm/addrspace.h which is pulled in by many other common asm/ headers. Signed-off-by:Paul Burton <paul.burton@mips.com> Reported-by:
Geert Uytterhoeven <geert@linux-m68k.org> URL: https://lore.kernel.org/linux-mips/CAMuHMdXvu+BppwzsU9imNWVKea_hoLcRt9N+a29Q-QsjW=ip2g@mail.gmail.com/ Fixes: 171a9bae ("staging/octeon: Allow test build on !MIPS") Cc: Matthew Wilcox (Oracle) <willy@infradead.org> Cc: David S. Miller <davem@davemloft.net> Link: https://lore.kernel.org/r/20191007231741.2012860-1-paul.burton@mips.comSigned-off-by:
-
Nachammai Karuppiah authored
Remove typecast in the call to kfree as it is not needed. Issue found using the below coccinelle script, @@ type t1; expression e; @@ -kfree((t1 *)e); +kfree(e); Signed-off-by:
-
Javier F. Arias authored
Remove commented code for a cleaner file. Issue found by checkpatch. Signed-off-by:
-
Antonio Borneo authored
Fix typo s/mechansim/mechanism/ Signed-off-by:
Antonio Borneo <antonio.borneo@st.com> Link: https://lore.kernel.org/r/20191007154306.95827-2-antonio.borneo@st.comSigned-off-by:
-
Wambui Karuga authored
Fixes checkpatch.pl warning: do not add new typedefs in drivers/staging/octeon/octeon-stubs.h:41 Signed-off-by:
-
Colin Ian King authored
There is a spelling mistake in the documentation and a module parameter description. Fix these. Signed-off-by:
-
Jérôme Pouiller authored
tx_policy_init() was already defined in driver cw1200. So, compilation failed when wfx and cw1200 were both built-in. In order to keep a coherent naming scheme, this patch prefixes all "tx_policy_*" functions with "wfx_". Fixes: 9bca45f3 ("staging: wfx: allow to send 802.11 frames") Reported-by:
kbuild test robot <lkp@intel.com> Signed-off-by:
-
Jérôme Pouiller authored
Most of calls to BUG_ON() could replaced by WARN(). By the way, this patch also try to favor WARN() (that include a comment about the problem) instead of WARN_ON(). Reported-by:
Andrew Lunn <andrew@lunn.ch> Signed-off-by:
-
Jérôme Pouiller authored
On error, copy_to_user() returns number of bytes remaining. Driver should return -EFAULT. Fixes: 4f8b7fab ("staging: wfx: allow to send commands to chip") Reported-by:
-
Jérôme Pouiller authored
When built for a big-endian target, original code caused error: include/uapi/linux/swab.h:242:29: note: expected '__u32 * {aka unsigned int *}' but argument is of type 'struct hif_mib_protected_mgmt_policy *' Fixes: f95a29d4 ("staging: wfx: add HIF commands helpers") Reported-by:Stephen Rothwell <sfr@canb.auug.org.au> Signed-off-by:
-
Jérôme Pouiller authored
Original code caused an (100% reproducible) invalid memory access on big-endian targets. Fixes: b0998f0c "staging: wfx: add IRQ handling" Reported-by:
-
