1. 25 Jul, 2014 13 commits
  2. 24 Jul, 2014 4 commits
    • David Härdeman's avatar
      [media] rc-core: simplify sysfs code · da6e162d
      David Härdeman authored
      Simplify and cleanup the sysfs code a bit.
      
      [m.chehab@samsung.com: rebased and fixed a CodingStyle issue]
      Signed-off-by: default avatarDavid Härdeman <david@hardeman.nu>
      Signed-off-by: default avatarMauro Carvalho Chehab <m.chehab@samsung.com>
      da6e162d
    • David Härdeman's avatar
      [media] saa7134: NEC scancode fix · 0bc56cbe
      David Härdeman authored
      This driver codes the two address bytes in reverse order when compared to the
      other drivers, so make it consistent (and update the keymap, note that the
      result is a prefix change from 0x6b86 -> 0x866b, and the latter is pretty
      common among the NECX keymaps. While not conclusive, it's still a strong hint
      that the change is correct).
      Signed-off-by: default avatarDavid Härdeman <david@hardeman.nu>
      Signed-off-by: default avatarMauro Carvalho Chehab <m.chehab@samsung.com>
      0bc56cbe
    • David Härdeman's avatar
      [media] rc-core: document the protocol type · 120703f9
      David Härdeman authored
      Right now the protocol information is not preserved, rc-core gets handed a
      scancode but has no idea which protocol it corresponds to.
      
      This patch (which required reading through the source/keymap for all drivers,
      not fun) makes the protocol information explicit which is important
      documentation and makes it easier to e.g. support multiple protocols with one
      decoder (think rc5 and rc-streamzap). The information isn't used yet so there
      should be no functional changes.
      
      [m.chehab@samsung.com: rebased, added cxusb and removed bad whitespacing]
      Signed-off-by: default avatarDavid Härdeman <david@hardeman.nu>
      Signed-off-by: default avatarMauro Carvalho Chehab <m.chehab@samsung.com>
      120703f9
    • David Härdeman's avatar
      [media] dib0700: NEC scancode cleanup · af3a4a9b
      David Härdeman authored
      the RC RX packet is defined as:
      
              struct dib0700_rc_response {
      		...
                                      u8 not_system;
                                      u8 system;
      		...
                      u8 data;
                      u8 not_data;
      
      The NEC protocol transmits in the order:
              system
              not_system
              data
              not_data
      
      Note that the code defines the NEC extended scancode as:
      
              scancode = be16_to_cpu(poll_reply->system16) << 8 | poll_reply->data;
      
      i.e.
      
              scancode = poll_reply->not_system << 16 |
                         poll_reply->system     << 8  |
                         poll_reply->data;
      
      Which, if the order *is* reversed, would mean that the scancode that
      gets defined is in reality:
      
              scancode = poll_reply->system     << 16 |
                         poll_reply->not_system << 8  |
                         poll_reply->data;
      
      Which is the same as the order used in drivers/media/rc/ir-nec-decoder.c.
      
      This patch changes the code to match my assumption (the generated scancode
      should, however, not change).
      
      [m.chehab@samsung.com: rebased and fixed the decoding error message]
      Signed-off-by: default avatarDavid Härdeman <david@hardeman.nu>
      CC: Patrick Boettcher <pboettcher@kernellabs.com>
      Tested-by: default avatarMauro Carvalho Chehab <m.chehab@samsung.com>
      Signed-off-by: default avatarMauro Carvalho Chehab <m.chehab@samsung.com>
      af3a4a9b
  3. 23 Jul, 2014 23 commits