1. 24 Jul, 2020 1 commit
    • Oleg Nesterov's avatar
      uprobes: Change handle_swbp() to send SIGTRAP with si_code=SI_KERNEL, to fix GDB regression · fe5ed7ab
      Oleg Nesterov authored
      If a tracee is uprobed and it hits int3 inserted by debugger, handle_swbp()
      does send_sig(SIGTRAP, current, 0) which means si_code == SI_USER. This used
      to work when this code was written, but then GDB started to validate si_code
      and now it simply can't use breakpoints if the tracee has an active uprobe:
      
      	# cat test.c
      	void unused_func(void)
      	{
      	}
      	int main(void)
      	{
      		return 0;
      	}
      
      	# gcc -g test.c -o test
      	# perf probe -x ./test -a unused_func
      	# perf record -e probe_test:unused_func gdb ./test -ex run
      	GNU gdb (GDB) 10.0.50.20200714-git
      	...
      	Program received signal SIGTRAP, Trace/breakpoint trap.
      	0x00007ffff7ddf909 in dl_main () from /lib64/ld-linux-x86-64.so.2
      	(gdb)
      
      The tracee hits the internal breakpoint inserted by GDB to monitor shared
      library events but GDB misinterprets this SIGTRAP and reports a signal.
      
      Change handle_swbp() to use force_sig(SIGTRAP), this matches do_int3_user()
      and fixes the problem.
      
      This is the minimal fix for -stable, arch/x86/kernel/uprobes.c is equally
      wrong; it should use send_sigtrap(TRAP_TRACE) instead of send_sig(SIGTRAP),
      but this doesn't confuse GDB and needs another x86-specific patch.
      Reported-by: default avatarAaron Merey <amerey@redhat.com>
      Signed-off-by: default avatarOleg Nesterov <oleg@redhat.com>
      Signed-off-by: default avatarIngo Molnar <mingo@kernel.org>
      Reviewed-by: default avatarSrikar Dronamraju <srikar@linux.vnet.ibm.com>
      Cc: stable@vger.kernel.org
      Link: https://lore.kernel.org/r/20200723154420.GA32043@redhat.com
      fe5ed7ab
  2. 23 Jul, 2020 1 commit
  3. 22 Jul, 2020 3 commits
    • Linus Torvalds's avatar
      Merge tag 'media/v5.8-3' of... · d15be546
      Linus Torvalds authored
      Merge tag 'media/v5.8-3' of git://git.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-media into master
      
      Pull media fixes from Mauro Carvalho Chehab:
       "A series of fixes for the upcoming atomisp driver. They solve issues
        when probing atomisp on devices with multiple cameras and get rid of
        warnings when built with W=1.
      
        The diffstat is a bit long, as this driver has several abstractions.
        The patches that solved the issues with W=1 had to get rid of some
        duplicated code (there used to have 2 versions of the same code, one
        for ISP2401 and another one for ISP2400).
      
        As this driver is not in 5.7, such changes won't cause regressions"
      
      * tag 'media/v5.8-3' of git://git.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-media: (38 commits)
        Revert "media: atomisp: keep the ISP powered on when setting it"
        media: atomisp: fix mask and shift operation on ISPSSPM0
        media: atomisp: move system_local consts into a C file
        media: atomisp: get rid of version-specific system_local.h
        media: atomisp: move global stuff into a common header
        media: atomisp: remove non-used 32-bits consts at system_local
        media: atomisp: get rid of some unused static vars
        media: atomisp: Fix error code in ov5693_probe()
        media: atomisp: Replace trace_printk by pr_info
        media: atomisp: Fix __func__ style warnings
        media: atomisp: fix help message for ISP2401 selection
        media: atomisp: i2c: atomisp-ov2680.c: fixed a brace coding style issue.
        media: atomisp: make const arrays static, makes object smaller
        media: atomisp: Clean up non-existing folders from Makefile
        media: atomisp: Get rid of ACPI specifics in gmin_subdev_add()
        media: atomisp: Provide Gmin subdev as parameter to gmin_subdev_add()
        media: atomisp: Use temporary variable for device in gmin_subdev_add()
        media: atomisp: Refactor PMIC detection to a separate function
        media: atomisp: Deduplicate return ret in gmin_i2c_write()
        media: atomisp: Make pointer to PMIC client global
        ...
      d15be546
    • Linus Torvalds's avatar
      Merge tag 'exfat-for-5.8-rc7' of... · 071fb1bc
      Linus Torvalds authored
      Merge tag 'exfat-for-5.8-rc7' of git://git.kernel.org/pub/scm/linux/kernel/git/linkinjeon/exfat into master
      
      Pull exfat fixes from Namjae Jeon:
      
       - fix overflow issue at sector calculation
      
       - fix wrong hint_stat initialization
      
       - fix wrong size update of stream entry
      
       - fix endianness of upname in name_hash computation
      
      * tag 'exfat-for-5.8-rc7' of git://git.kernel.org/pub/scm/linux/kernel/git/linkinjeon/exfat:
        exfat: fix name_hash computation on big endian systems
        exfat: fix wrong size update of stream entry by typo
        exfat: fix wrong hint_stat initialization in exfat_find_dir_entry()
        exfat: fix overflow issue in exfat_cluster_to_sector()
      071fb1bc
    • Gerald Schaefer's avatar
  4. 21 Jul, 2020 6 commits
  5. 20 Jul, 2020 2 commits
    • Linus Torvalds's avatar
      Merge tag 'vfio-v5.8-rc7' of git://github.com/awilliam/linux-vfio into master · 4fa640dc
      Linus Torvalds authored
      Pull VFIO fix from Alex Williamson:
       "Fix race with eventfd ctx cleared outside of mutex (Zeng Tao)"
      
      * tag 'vfio-v5.8-rc7' of git://github.com/awilliam/linux-vfio:
        vfio/pci: fix racy on error and request eventfd ctx
      4fa640dc
    • Kevin Buettner's avatar
      copy_xstate_to_kernel: Fix typo which caused GDB regression · 5714ee50
      Kevin Buettner authored
      This fixes a regression encountered while running the
      gdb.base/corefile.exp test in GDB's test suite.
      
      In my testing, the typo prevented the sw_reserved field of struct
      fxregs_state from being output to the kernel XSAVES area.  Thus the
      correct mask corresponding to XCR0 was not present in the core file for
      GDB to interrogate, resulting in the following behavior:
      
         [kev@f32-1 gdb]$ ./gdb -q testsuite/outputs/gdb.base/corefile/corefile testsuite/outputs/gdb.base/corefile/corefile.core
         Reading symbols from testsuite/outputs/gdb.base/corefile/corefile...
         [New LWP 232880]
      
         warning: Unexpected size of section `.reg-xstate/232880' in core file.
      
      With the typo fixed, the test works again as expected.
      Signed-off-by: default avatarKevin Buettner <kevinb@redhat.com>
      Fixes: 9e463654 ("copy_xstate_to_kernel(): don't leave parts of destination uninitialized")
      Cc: Al Viro <viro@zeniv.linux.org.uk>
      Cc: Dave Airlie <airlied@gmail.com>
      Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
      5714ee50
  6. 19 Jul, 2020 21 commits
    • Linus Torvalds's avatar
      Linux 5.8-rc6 · ba47d845
      Linus Torvalds authored
      ba47d845
    • Linus Torvalds's avatar
      Merge tag 'perf-tools-fixes-2020-07-19' of... · 92188b41
      Linus Torvalds authored
      Merge tag 'perf-tools-fixes-2020-07-19' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into master
      
      Pull perf tooling fixes from Arnaldo Carvalho de Melo:
      
       - Update hashmap.h from libbpf and kvm.h from x86's kernel UAPI.
      
       - Set opt->set in libsubcmd's OPT_CALLBACK_SET(). This fixes
         'perf record --switch-output-event event-name' usage"
      
      * tag 'perf-tools-fixes-2020-07-19' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux:
        tools arch kvm: Sync kvm headers with the kernel sources
        perf tools: Sync hashmap.h with libbpf's
        libsubcmd: Fix OPT_CALLBACK_SET()
      92188b41
    • Linus Torvalds's avatar
      Merge tag 'x86-urgent-2020-07-19' of... · efb9666e
      Linus Torvalds authored
      Merge tag 'x86-urgent-2020-07-19' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip into master
      
      Pull x86 fixes from Thomas Gleixner:
       "A pile of fixes for x86:
      
         - Fix the I/O bitmap invalidation on XEN PV, which was overlooked in
           the recent ioperm/iopl rework. This caused the TSS and XEN's I/O
           bitmap to get out of sync.
      
         - Use the proper vectors for HYPERV.
      
         - Make disabling of stack protector for the entry code work with GCC
           builds which enable stack protector by default. Removing the option
           is not sufficient, it needs an explicit -fno-stack-protector to
           shut it off.
      
         - Mark check_user_regs() noinstr as it is called from noinstr code.
           The missing annotation causes it to be placed in the text section
           which makes it instrumentable.
      
         - Add the missing interrupt disable in exc_alignment_check()
      
         - Fixup a XEN_PV build dependency in the 32bit entry code
      
         - A few fixes to make the Clang integrated assembler happy
      
         - Move EFI stub build to the right place for out of tree builds
      
         - Make prepare_exit_to_usermode() static. It's not longer called from
           ASM code"
      
      * tag 'x86-urgent-2020-07-19' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip:
        x86/boot: Don't add the EFI stub to targets
        x86/entry: Actually disable stack protector
        x86/ioperm: Fix io bitmap invalidation on Xen PV
        x86: math-emu: Fix up 'cmp' insn for clang ias
        x86/entry: Fix vectors to IDTENTRY_SYSVEC for CONFIG_HYPERV
        x86/entry: Add compatibility with IAS
        x86/entry/common: Make prepare_exit_to_usermode() static
        x86/entry: Mark check_user_regs() noinstr
        x86/traps: Disable interrupts in exc_aligment_check()
        x86/entry/32: Fix XEN_PV build dependency
      efb9666e
    • Linus Torvalds's avatar
      Merge tag 'timers-urgent-2020-07-19' of... · 66e4b636
      Linus Torvalds authored
      Merge tag 'timers-urgent-2020-07-19' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip into master
      
      Pull timer fixes from Thomas Gleixner:
       "Two fixes for the timer wheel:
      
         - A timer which is already expired at enqueue time can set the
           base->next_expiry value backwards. As a consequence base->clk can
           be set back as well. This can lead to timers expiring early. Add a
           sanity check to prevent this.
      
         - When a timer is queued with an expiry time beyond the wheel
           capacity then it should be queued in the bucket of the last wheel
           level which is expiring last.
      
           The code adjusted the expiry time to the maximum wheel capacity,
           which is only correct when the wheel clock is 0. Aside of that the
           check whether the delta is larger than wheel capacity does not
           check the delta, it checks the expiry value itself. As a result
           timers can expire at random.
      
           Fix this by checking the right variable and adjust expiry time so
           it becomes base->clock plus capacity which places it into the
           outmost bucket in the last wheel level"
      
      * tag 'timers-urgent-2020-07-19' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip:
        timer: Fix wheel index calculation on last level
        timer: Prevent base->clk from moving backward
      66e4b636
    • Linus Torvalds's avatar
      Merge tag 'sched-urgent-2020-07-19' of... · 43768f7c
      Linus Torvalds authored
      Merge tag 'sched-urgent-2020-07-19' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip into master
      
      Pull scheduler fixes from Thomas Gleixner:
       "A set of scheduler fixes:
      
         - Plug a load average accounting race which was introduced with a
           recent optimization casing load average to show bogus numbers.
      
         - Fix the rseq CPU id initialization for new tasks. sched_fork() does
           not update the rseq CPU id so the id is the stale id of the parent
           task, which can cause user space data corruption.
      
         - Handle a 0 return value of task_h_load() correctly in the load
           balancer, which does not decrease imbalance and therefore pulls
           until the maximum number of loops is reached, which might be all
           tasks just created by a fork bomb"
      
      * tag 'sched-urgent-2020-07-19' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip:
        sched/fair: handle case of task_h_load() returning 0
        sched: Fix unreliable rseq cpu_id for new tasks
        sched: Fix loadavg accounting race
      43768f7c
    • Linus Torvalds's avatar
      Merge tag 'irq-urgent-2020-07-19' of... · 9413cd77
      Linus Torvalds authored
      Merge tag 'irq-urgent-2020-07-19' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip into master
      
      Pull irq fixes from Thomas Gleixner:
       "Two fixes for the interrupt subsystem:
      
         - Make the handling of the firmware node consistent and do not free
           the node after the domain has been created successfully. The core
           code stores a pointer to it which can lead to a use after free or
           double free.
      
           This used to "work" because the pointer was not stored when the
           initial code was written, but at some point later it was required
           to store it. Of course nobody noticed that the existing users break
           that way.
      
         - Handle affinity setting on inactive interrupts correctly when
           hierarchical irq domains are enabled.
      
           When interrupts are inactive with the modern hierarchical irqdomain
           design, the interrupt chips are not necessarily in a state where
           affinity changes can be handled. The legacy irq chip design allowed
           this because interrupts are immediately fully initialized at
           allocation time. X86 has a hacky workaround for this, but other
           implementations do not.
      
           This cased malfunction on GIC-V3. Instead of playing whack a mole
           to find all affected drivers, change the core code to store the
           requested affinity setting and then establish it when the interrupt
           is allocated, which makes the X86 hack go away"
      
      * tag 'irq-urgent-2020-07-19' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip:
        genirq/affinity: Handle affinity setting on inactive interrupts correctly
        irqdomain/treewide: Keep firmware node unconditionally allocated
      9413cd77
    • Linus Torvalds's avatar
      Merge tag 'usb-5.8-rc6' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb into master · ce20d7bf
      Linus Torvalds authored
      Pull USB fixes from Greg KH:
       "Here are a few small USB fixes, and one thunderbolt fix, for 5.8-rc6.
      
        Nothing huge in here, just the normal collection of gadget, dwc2/3,
        serial, and other minor USB driver fixes and id additions. Full
        details are in the shortlog.
      
        All of these have been in linux-next for a while with no reported
        issues"
      
      * tag 'usb-5.8-rc6' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb:
        USB: serial: iuu_phoenix: fix memory corruption
        USB: c67x00: fix use after free in c67x00_giveback_urb
        usb: gadget: function: fix missing spinlock in f_uac1_legacy
        usb: gadget: udc: atmel: fix uninitialized read in debug printk
        usb: gadget: udc: atmel: remove outdated comment in usba_ep_disable()
        usb: dwc2: Fix shutdown callback in platform
        usb: cdns3: trace: fix some endian issues
        usb: cdns3: ep0: fix some endian issues
        usb: gadget: udc: gr_udc: fix memleak on error handling path in gr_ep_init()
        usb: gadget: fix langid kernel-doc warning in usbstring.c
        usb: dwc3: pci: add support for the Intel Jasper Lake
        usb: dwc3: pci: add support for the Intel Tiger Lake PCH -H variant
        usb: chipidea: core: add wakeup support for extcon
        USB: serial: option: add Quectel EG95 LTE modem
        thunderbolt: Fix path indices used in USB3 tunnel discovery
        USB: serial: ch341: add new Product ID for CH340
        USB: serial: option: add GosunCn GM500 series
        USB: serial: cypress_m8: enable Simply Automated UPB PIM
      ce20d7bf
    • Linus Torvalds's avatar
      Merge tag 'dma-mapping-5.8-6' of git://git.infradead.org/users/hch/dma-mapping into master · 8c18fc63
      Linus Torvalds authored
      Pull dma-mapping fixes from Christoph Hellwig:
       "Ensure we always have fully addressable memory in the dma coherent
        pool (Nicolas Saenz Julienne)"
      
      * tag 'dma-mapping-5.8-6' of git://git.infradead.org/users/hch/dma-mapping:
        dma-pool: do not allocate pool memory from CMA
        dma-pool: make sure atomic pool suits device
        dma-pool: introduce dma_guess_pool()
        dma-pool: get rid of dma_in_atomic_pool()
        dma-direct: provide function to check physical memory area validity
      8c18fc63
    • Mauro Carvalho Chehab's avatar
      Revert "media: atomisp: keep the ISP powered on when setting it" · 0d6db851
      Mauro Carvalho Chehab authored
      changeset d0213061a501 ("media: atomisp: fix mask and shift operation on ISPSSPM0")
      solved the existing issue with the IUNIT power on code.
      
      So, the driver can now use the right code again.
      
      This reverts commit 95d1f398.
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+huawei@kernel.org>
      0d6db851
    • Colin Ian King's avatar
      media: atomisp: fix mask and shift operation on ISPSSPM0 · 23988c97
      Colin Ian King authored
      Currently the check on bits 25:24 on ISPSSPM0 is always 0 because
      the mask and shift operations are incorrect. Fix this by shifting
      by MRFLD_ISPSSPM0_ISPSSS_OFFSET (24 bits right) and then masking
      with RFLD_ISPSSPM0_ISPSSC_MASK (0x03) to get the appropriate 2 bits
      to check.
      
      Addresses-Coverity: ("Operands don't affect result")
      Fixes: 0f441fd7 ("media: atomisp: simplify the power down/up code")
      Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+huawei@kernel.org>
      23988c97
    • Arvind Sankar's avatar
      x86/boot: Don't add the EFI stub to targets · da05b143
      Arvind Sankar authored
      vmlinux-objs-y is added to targets, which currently means that the EFI
      stub gets added to the targets as well. It shouldn't be added since it
      is built elsewhere.
      
      This confuses Makefile.build which interprets the EFI stub as a target
      	$(obj)/$(objtree)/drivers/firmware/efi/libstub/lib.a
      and will create drivers/firmware/efi/libstub/ underneath
      arch/x86/boot/compressed, to hold this supposed target, if building
      out-of-tree. [0]
      
      Fix this by pulling the stub out of vmlinux-objs-y into efi-obj-y.
      
      [0] See scripts/Makefile.build near the end:
          # Create directories for object files if they do not exist
      Signed-off-by: default avatarArvind Sankar <nivedita@alum.mit.edu>
      Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
      Reviewed-by: default avatarMasahiro Yamada <masahiroy@kernel.org>
      Acked-by: default avatarArd Biesheuvel <ardb@kernel.org>
      Link: https://lkml.kernel.org/r/20200715032631.1562882-1-nivedita@alum.mit.edu
      da05b143
    • Kees Cook's avatar
      x86/entry: Actually disable stack protector · 58ac3154
      Kees Cook authored
      Some builds of GCC enable stack protector by default. Simply removing
      the arguments is not sufficient to disable stack protector, as the stack
      protector for those GCC builds must be explicitly disabled. Remove the
      argument removals and add -fno-stack-protector. Additionally include
      missed x32 argument updates, and adjust whitespace for readability.
      
      Fixes: 20355e5f ("x86/entry: Exclude low level entry code from sanitizing")
      Signed-off-by: default avatarKees Cook <keescook@chromium.org>
      Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
      Link: https://lkml.kernel.org/r/202006261333.585319CA6B@keescook
      58ac3154
    • Mauro Carvalho Chehab's avatar
      media: atomisp: move system_local consts into a C file · 85ebb8eb
      Mauro Carvalho Chehab authored
      Instead of declaring all those consts everywhere when the
      headers are included, just place them on a single place.
      
      This change shuts up lots of warnings when built with W=1:
      
      In file included from drivers/staging/media/atomisp/pci/ia_css_acc_types.h:23,
                       from drivers/staging/media/atomisp/pci/ia_css.h:26,
                       from drivers/staging/media/atomisp/pci/atomisp_compat_css20.h:24,
                       from drivers/staging/media/atomisp/pci/atomisp_compat.h:22,
                       from drivers/staging/media/atomisp/pci/atomisp_drvfs.c:23:
      ./drivers/staging/media/atomisp//pci/system_local.h:193:26: warning: ‘STREAM2MMIO_CTRL_BASE’ defined but not used [-Wunused-const-variable=]
        193 | static const hrt_address STREAM2MMIO_CTRL_BASE[N_STREAM2MMIO_ID] = {
            |                          ^~~~~~~~~~~~~~~~~~~~~
      ./drivers/staging/media/atomisp//pci/system_local.h:186:26: warning: ‘PIXELGEN_CTRL_BASE’ defined but not used [-Wunused-const-variable=]
        186 | static const hrt_address PIXELGEN_CTRL_BASE[N_PIXELGEN_ID] = {
            |                          ^~~~~~~~~~~~~~~~~~
      ./drivers/staging/media/atomisp//pci/system_local.h:179:26: warning: ‘CSI_RX_BE_CTRL_BASE’ defined but not used [-Wunused-const-variable=]
        179 | static const hrt_address CSI_RX_BE_CTRL_BASE[N_CSI_RX_BACKEND_ID] = {
            |                          ^~~~~~~~~~~~~~~~~~~
      ./drivers/staging/media/atomisp//pci/system_local.h:172:26: warning: ‘CSI_RX_FE_CTRL_BASE’ defined but not used [-Wunused-const-variable=]
        172 | static const hrt_address CSI_RX_FE_CTRL_BASE[N_CSI_RX_FRONTEND_ID] = {
            |                          ^~~~~~~~~~~~~~~~~~~
      ./drivers/staging/media/atomisp//pci/system_local.h:165:26: warning: ‘ISYS_IRQ_BASE’ defined but not used [-Wunused-const-variable=]
        165 | static const hrt_address ISYS_IRQ_BASE[N_ISYS_IRQ_ID] = {
            |                          ^~~~~~~~~~~~~
      ./drivers/staging/media/atomisp//pci/system_local.h:158:26: warning: ‘IBUF_CTRL_BASE’ defined but not used [-Wunused-const-variable=]
        158 | static const hrt_address IBUF_CTRL_BASE[N_IBUF_CTRL_ID] = {
            |                          ^~~~~~~~~~~~~~
      ./drivers/staging/media/atomisp//pci/system_local.h:153:26: warning: ‘RX_BASE’ defined but not used [-Wunused-const-variable=]
        153 | static const hrt_address RX_BASE[N_RX_ID] = {
            |                          ^~~~~~~
      ./drivers/staging/media/atomisp//pci/system_local.h:138:26: warning: ‘INPUT_SYSTEM_BASE’ defined but not used [-Wunused-const-variable=]
        138 | static const hrt_address INPUT_SYSTEM_BASE[N_INPUT_SYSTEM_ID] = {
            |                          ^~~~~~~~~~~~~~~~~
      ./drivers/staging/media/atomisp//pci/system_local.h:130:26: warning: ‘INPUT_FORMATTER_BASE’ defined but not used [-Wunused-const-variable=]
        130 | static const hrt_address INPUT_FORMATTER_BASE[N_INPUT_FORMATTER_ID] = {
            |                          ^~~~~~~~~~~~~~~~~~~~
      ./drivers/staging/media/atomisp//pci/system_local.h:125:26: warning: ‘TIMED_CTRL_BASE’ defined but not used [-Wunused-const-variable=]
        125 | static const hrt_address TIMED_CTRL_BASE[N_TIMED_CTRL_ID] = {
            |                          ^~~~~~~~~~~~~~~
      ./drivers/staging/media/atomisp//pci/system_local.h:120:26: warning: ‘GPIO_BASE’ defined but not used [-Wunused-const-variable=]
        120 | static const hrt_address GPIO_BASE[N_GPIO_ID] = {
            |                          ^~~~~~~~~
      ./drivers/staging/media/atomisp//pci/system_local.h:116:26: warning: ‘GP_TIMER_BASE’ defined but not used [-Wunused-const-variable=]
        116 | static const hrt_address GP_TIMER_BASE =
            |                          ^~~~~~~~~~~~~
      ./drivers/staging/media/atomisp//pci/system_local.h:109:26: warning: ‘GP_DEVICE_BASE’ defined but not used [-Wunused-const-variable=]
        109 | static const hrt_address GP_DEVICE_BASE[N_GP_DEVICE_ID] = {
            |                          ^~~~~~~~~~~~~~
      ./drivers/staging/media/atomisp//pci/system_local.h:96:26: warning: ‘FIFO_MONITOR_BASE’ defined but not used [-Wunused-const-variable=]
         96 | static const hrt_address FIFO_MONITOR_BASE[N_FIFO_MONITOR_ID] = {
            |                          ^~~~~~~~~~~~~~~~~
      ./drivers/staging/media/atomisp//pci/system_local.h:90:26: warning: ‘GDC_BASE’ defined but not used [-Wunused-const-variable=]
         90 | static const hrt_address GDC_BASE[N_GDC_ID] = {
            |                          ^~~~~~~~
      ./drivers/staging/media/atomisp//pci/system_local.h:78:26: warning: ‘IRQ_BASE’ defined but not used [-Wunused-const-variable=]
         78 | static const hrt_address IRQ_BASE[N_IRQ_ID] = {
            |                          ^~~~~~~~
      ./drivers/staging/media/atomisp//pci/system_local.h:73:26: warning: ‘ISYS2401_DMA_BASE’ defined but not used [-Wunused-const-variable=]
         73 | static const hrt_address ISYS2401_DMA_BASE[N_ISYS2401_DMA_ID] = {
            |                          ^~~~~~~~~~~~~~~~~
      ./drivers/staging/media/atomisp//pci/system_local.h:69:26: warning: ‘DMA_BASE’ defined but not used [-Wunused-const-variable=]
         69 | static const hrt_address DMA_BASE[N_DMA_ID] = {
            |                          ^~~~~~~~
      ./drivers/staging/media/atomisp//pci/system_local.h:63:26: warning: ‘MMU_BASE’ defined but not used [-Wunused-const-variable=]
         63 | static const hrt_address MMU_BASE[N_MMU_ID] = {
            |                          ^~~~~~~~
      ./drivers/staging/media/atomisp//pci/system_local.h:54:26: warning: ‘SP_DMEM_BASE’ defined but not used [-Wunused-const-variable=]
         54 | static const hrt_address SP_DMEM_BASE[N_SP_ID] = {
            |                          ^~~~~~~~~~~~
      ./drivers/staging/media/atomisp//pci/system_local.h:50:26: warning: ‘SP_CTRL_BASE’ defined but not used [-Wunused-const-variable=]
         50 | static const hrt_address SP_CTRL_BASE[N_SP_ID] = {
            |                          ^~~~~~~~~~~~
      ./drivers/staging/media/atomisp//pci/system_local.h:45:26: warning: ‘ISP_BAMEM_BASE’ defined but not used [-Wunused-const-variable=]
         45 | static const hrt_address ISP_BAMEM_BASE[N_BAMEM_ID] = {
            |                          ^~~~~~~~~~~~~~
      ./drivers/staging/media/atomisp//pci/system_local.h:41:26: warning: ‘ISP_DMEM_BASE’ defined but not used [-Wunused-const-variable=]
         41 | static const hrt_address ISP_DMEM_BASE[N_ISP_ID] = {
            |                          ^~~~~~~~~~~~~
      ./drivers/staging/media/atomisp//pci/system_local.h:37:26: warning: ‘ISP_CTRL_BASE’ defined but not used [-Wunused-const-variable=]
         37 | static const hrt_address ISP_CTRL_BASE[N_ISP_ID] = {
            |                          ^~~~~~~~~~~~~
      In file included from drivers/staging/media/atomisp/pci/ia_css_acc_types.h:23,
                       from drivers/staging/media/atomisp/pci/ia_css.h:26,
                       from drivers/staging/media/atomisp/pci/atomisp_file.c:27:
      ./drivers/staging/media/atomisp//pci/system_local.h:193:26: warning: ‘STREAM2MMIO_CTRL_BASE’ defined but not used [-Wunused-const-variable=]
        193 | static const hrt_address STREAM2MMIO_CTRL_BASE[N_STREAM2MMIO_ID] = {
            |                          ^~~~~~~~~~~~~~~~~~~~~
      ./drivers/staging/media/atomisp//pci/system_local.h:186:26: warning: ‘PIXELGEN_CTRL_BASE’ defined but not used [-Wunused-const-variable=]
        186 | static const hrt_address PIXELGEN_CTRL_BASE[N_PIXELGEN_ID] = {
            |                          ^~~~~~~~~~~~~~~~~~
      ./drivers/staging/media/atomisp//pci/system_local.h:179:26: warning: ‘CSI_RX_BE_CTRL_BASE’ defined but not used [-Wunused-const-variable=]
        179 | static const hrt_address CSI_RX_BE_CTRL_BASE[N_CSI_RX_BACKEND_ID] = {
            |                          ^~~~~~~~~~~~~~~~~~~
      ./drivers/staging/media/atomisp//pci/system_local.h:172:26: warning: ‘CSI_RX_FE_CTRL_BASE’ defined but not used [-Wunused-const-variable=]
        172 | static const hrt_address CSI_RX_FE_CTRL_BASE[N_CSI_RX_FRONTEND_ID] = {
            |                          ^~~~~~~~~~~~~~~~~~~
      ./drivers/staging/media/atomisp//pci/system_local.h:165:26: warning: ‘ISYS_IRQ_BASE’ defined but not used [-Wunused-const-variable=]
        165 | static const hrt_address ISYS_IRQ_BASE[N_ISYS_IRQ_ID] = {
            |                          ^~~~~~~~~~~~~
      ./drivers/staging/media/atomisp//pci/system_local.h:158:26: warning: ‘IBUF_CTRL_BASE’ defined but not used [-Wunused-const-variable=]
        158 | static const hrt_address IBUF_CTRL_BASE[N_IBUF_CTRL_ID] = {
            |                          ^~~~~~~~~~~~~~
      ./drivers/staging/media/atomisp//pci/system_local.h:153:26: warning: ‘RX_BASE’ defined but not used [-Wunused-const-variable=]
        153 | static const hrt_address RX_BASE[N_RX_ID] = {
            |                          ^~~~~~~
      ./drivers/staging/media/atomisp//pci/system_local.h:138:26: warning: ‘INPUT_SYSTEM_BASE’ defined but not used [-Wunused-const-variable=]
        138 | static const hrt_address INPUT_SYSTEM_BASE[N_INPUT_SYSTEM_ID] = {
            |                          ^~~~~~~~~~~~~~~~~
      ./drivers/staging/media/atomisp//pci/system_local.h:130:26: warning: ‘INPUT_FORMATTER_BASE’ defined but not used [-Wunused-const-variable=]
        130 | static const hrt_address INPUT_FORMATTER_BASE[N_INPUT_FORMATTER_ID] = {
            |                          ^~~~~~~~~~~~~~~~~~~~
      ./drivers/staging/media/atomisp//pci/system_local.h:125:26: warning: ‘TIMED_CTRL_BASE’ defined but not used [-Wunused-const-variable=]
        125 | static const hrt_address TIMED_CTRL_BASE[N_TIMED_CTRL_ID] = {
            |                          ^~~~~~~~~~~~~~~
      ./drivers/staging/media/atomisp//pci/system_local.h:120:26: warning: ‘GPIO_BASE’ defined but not used [-Wunused-const-variable=]
        120 | static const hrt_address GPIO_BASE[N_GPIO_ID] = {
            |                          ^~~~~~~~~
      ./drivers/staging/media/atomisp//pci/system_local.h:116:26: warning: ‘GP_TIMER_BASE’ defined but not used [-Wunused-const-variable=]
        116 | static const hrt_address GP_TIMER_BASE =
            |                          ^~~~~~~~~~~~~
      ./drivers/staging/media/atomisp//pci/system_local.h:109:26: warning: ‘GP_DEVICE_BASE’ defined but not used [-Wunused-const-variable=]
        109 | static const hrt_address GP_DEVICE_BASE[N_GP_DEVICE_ID] = {
            |                          ^~~~~~~~~~~~~~
      ./drivers/staging/media/atomisp//pci/system_local.h:96:26: warning: ‘FIFO_MONITOR_BASE’ defined but not used [-Wunused-const-variable=]
         96 | static const hrt_address FIFO_MONITOR_BASE[N_FIFO_MONITOR_ID] = {
            |                          ^~~~~~~~~~~~~~~~~
      ./drivers/staging/media/atomisp//pci/system_local.h:90:26: warning: ‘GDC_BASE’ defined but not used [-Wunused-const-variable=]
         90 | static const hrt_address GDC_BASE[N_GDC_ID] = {
            |                          ^~~~~~~~
      ./drivers/staging/media/atomisp//pci/system_local.h:78:26: warning: ‘IRQ_BASE’ defined but not used [-Wunused-const-variable=]
         78 | static const hrt_address IRQ_BASE[N_IRQ_ID] = {
            |                          ^~~~~~~~
      ./drivers/staging/media/atomisp//pci/system_local.h:73:26: warning: ‘ISYS2401_DMA_BASE’ defined but not used [-Wunused-const-variable=]
         73 | static const hrt_address ISYS2401_DMA_BASE[N_ISYS2401_DMA_ID] = {
            |                          ^~~~~~~~~~~~~~~~~
      ./drivers/staging/media/atomisp//pci/system_local.h:69:26: warning: ‘DMA_BASE’ defined but not used [-Wunused-const-variable=]
         69 | static const hrt_address DMA_BASE[N_DMA_ID] = {
            |                          ^~~~~~~~
      ./drivers/staging/media/atomisp//pci/system_local.h:63:26: warning: ‘MMU_BASE’ defined but not used [-Wunused-const-variable=]
         63 | static const hrt_address MMU_BASE[N_MMU_ID] = {
            |                          ^~~~~~~~
      ./drivers/staging/media/atomisp//pci/system_local.h:54:26: warning: ‘SP_DMEM_BASE’ defined but not used [-Wunused-const-variable=]
         54 | static const hrt_address SP_DMEM_BASE[N_SP_ID] = {
            |                          ^~~~~~~~~~~~
      ./drivers/staging/media/atomisp//pci/system_local.h:50:26: warning: ‘SP_CTRL_BASE’ defined but not used [-Wunused-const-variable=]
         50 | static const hrt_address SP_CTRL_BASE[N_SP_ID] = {
            |                          ^~~~~~~~~~~~
      ./drivers/staging/media/atomisp//pci/system_local.h:45:26: warning: ‘ISP_BAMEM_BASE’ defined but not used [-Wunused-const-variable=]
         45 | static const hrt_address ISP_BAMEM_BASE[N_BAMEM_ID] = {
            |                          ^~~~~~~~~~~~~~
      ./drivers/staging/media/atomisp//pci/system_local.h:41:26: warning: ‘ISP_DMEM_BASE’ defined but not used [-Wunused-const-variable=]
         41 | static const hrt_address ISP_DMEM_BASE[N_ISP_ID] = {
            |                          ^~~~~~~~~~~~~
      ./drivers/staging/media/atomisp//pci/system_local.h:37:26: warning: ‘ISP_CTRL_BASE’ defined but not used [-Wunused-const-variable=]
         37 | static const hrt_address ISP_CTRL_BASE[N_ISP_ID] = {
            |                          ^~~~~~~~~~~~~
      In file included from ./drivers/staging/media/atomisp//pci/ia_css_acc_types.h:23,
                       from ./drivers/staging/media/atomisp//pci/ia_css_pipe_public.h:29,
                       from drivers/staging/media/atomisp/pci/sh_css_legacy.h:23,
                       from drivers/staging/media/atomisp/pci/atomisp_internal.h:34,
                       from drivers/staging/media/atomisp/pci/atomisp_cmd.h:30,
                       from drivers/staging/media/atomisp/pci/atomisp_csi2.c:21:
      ./drivers/staging/media/atomisp//pci/system_local.h:193:26: warning: ‘STREAM2MMIO_CTRL_BASE’ defined but not used [-Wunused-const-variable=]
        193 | static const hrt_address STREAM2MMIO_CTRL_BASE[N_STREAM2MMIO_ID] = {
            |                          ^~~~~~~~~~~~~~~~~~~~~
      ./drivers/staging/media/atomisp//pci/system_local.h:186:26: warning: ‘PIXELGEN_CTRL_BASE’ defined but not used [-Wunused-const-variable=]
        186 | static const hrt_address PIXELGEN_CTRL_BASE[N_PIXELGEN_ID] = {
            |                          ^~~~~~~~~~~~~~~~~~
      ./drivers/staging/media/atomisp//pci/system_local.h:179:26: warning: ‘CSI_RX_BE_CTRL_BASE’ defined but not used [-Wunused-const-variable=]
        179 | static const hrt_address CSI_RX_BE_CTRL_BASE[N_CSI_RX_BACKEND_ID] = {
            |                          ^~~~~~~~~~~~~~~~~~~
      ./drivers/staging/media/atomisp//pci/system_local.h:172:26: warning: ‘CSI_RX_FE_CTRL_BASE’ defined but not used [-Wunused-const-variable=]
        172 | static const hrt_address CSI_RX_FE_CTRL_BASE[N_CSI_RX_FRONTEND_ID] = {
            |                          ^~~~~~~~~~~~~~~~~~~
      ./drivers/staging/media/atomisp//pci/system_local.h:165:26: warning: ‘ISYS_IRQ_BASE’ defined but not used [-Wunused-const-variable=]
        165 | static const hrt_address ISYS_IRQ_BASE[N_ISYS_IRQ_ID] = {
            |                          ^~~~~~~~~~~~~
      ./drivers/staging/media/atomisp//pci/system_local.h:158:26: warning: ‘IBUF_CTRL_BASE’ defined but not used [-Wunused-const-variable=]
        158 | static const hrt_address IBUF_CTRL_BASE[N_IBUF_CTRL_ID] = {
            |                          ^~~~~~~~~~~~~~
      ./drivers/staging/media/atomisp//pci/system_local.h:153:26: warning: ‘RX_BASE’ defined but not used [-Wunused-const-variable=]
        153 | static const hrt_address RX_BASE[N_RX_ID] = {
            |                          ^~~~~~~
      ./drivers/staging/media/atomisp//pci/system_local.h:138:26: warning: ‘INPUT_SYSTEM_BASE’ defined but not used [-Wunused-const-variable=]
        138 | static const hrt_address INPUT_SYSTEM_BASE[N_INPUT_SYSTEM_ID] = {
            |                          ^~~~~~~~~~~~~~~~~
      ./drivers/staging/media/atomisp//pci/system_local.h:130:26: warning: ‘INPUT_FORMATTER_BASE’ defined but not used [-Wunused-const-variable=]
        130 | static const hrt_address INPUT_FORMATTER_BASE[N_INPUT_FORMATTER_ID] = {
            |                          ^~~~~~~~~~~~~~~~~~~~
      ./drivers/staging/media/atomisp//pci/system_local.h:125:26: warning: ‘TIMED_CTRL_BASE’ defined but not used [-Wunused-const-variable=]
        125 | static const hrt_address TIMED_CTRL_BASE[N_TIMED_CTRL_ID] = {
            |                          ^~~~~~~~~~~~~~~
      ./drivers/staging/media/atomisp//pci/system_local.h:120:26: warning: ‘GPIO_BASE’ defined but not used [-Wunused-const-variable=]
        120 | static const hrt_address GPIO_BASE[N_GPIO_ID] = {
            |                          ^~~~~~~~~
      ./drivers/staging/media/atomisp//pci/system_local.h:116:26: warning: ‘GP_TIMER_BASE’ defined but not used [-Wunused-const-variable=]
        116 | static const hrt_address GP_TIMER_BASE =
            |                          ^~~~~~~~~~~~~
      ./drivers/staging/media/atomisp//pci/system_local.h:109:26: warning: ‘GP_DEVICE_BASE’ defined but not used [-Wunused-const-variable=]
        109 | static const hrt_address GP_DEVICE_BASE[N_GP_DEVICE_ID] = {
            |                          ^~~~~~~~~~~~~~
      ./drivers/staging/media/atomisp//pci/system_local.h:96:26: warning: ‘FIFO_MONITOR_BASE’ defined but not used [-Wunused-const-variable=]
         96 | static const hrt_address FIFO_MONITOR_BASE[N_FIFO_MONITOR_ID] = {
            |                          ^~~~~~~~~~~~~~~~~
      ./drivers/staging/media/atomisp//pci/system_local.h:90:26: warning: ‘GDC_BASE’ defined but not used [-Wunused-const-variable=]
         90 | static const hrt_address GDC_BASE[N_GDC_ID] = {
            |                          ^~~~~~~~
      ./drivers/staging/media/atomisp//pci/system_local.h:78:26: warning: ‘IRQ_BASE’ defined but not used [-Wunused-const-variable=]
         78 | static const hrt_address IRQ_BASE[N_IRQ_ID] = {
            |                          ^~~~~~~~
      ./drivers/staging/media/atomisp//pci/system_local.h:73:26: warning: ‘ISYS2401_DMA_BASE’ defined but not used [-Wunused-const-variable=]
         73 | static const hrt_address ISYS2401_DMA_BASE[N_ISYS2401_DMA_ID] = {
            |                          ^~~~~~~~~~~~~~~~~
      ./drivers/staging/media/atomisp//pci/system_local.h:69:26: warning: ‘DMA_BASE’ defined but not used [-Wunused-const-variable=]
         69 | static const hrt_address DMA_BASE[N_DMA_ID] = {
            |                          ^~~~~~~~
      ./drivers/staging/media/atomisp//pci/system_local.h:63:26: warning: ‘MMU_BASE’ defined but not used [-Wunused-const-variable=]
         63 | static const hrt_address MMU_BASE[N_MMU_ID] = {
            |                          ^~~~~~~~
      ./drivers/staging/media/atomisp//pci/system_local.h:54:26: warning: ‘SP_DMEM_BASE’ defined but not used [-Wunused-const-variable=]
         54 | static const hrt_address SP_DMEM_BASE[N_SP_ID] = {
            |                          ^~~~~~~~~~~~
      ./drivers/staging/media/atomisp//pci/system_local.h:50:26: warning: ‘SP_CTRL_BASE’ defined but not used [-Wunused-const-variable=]
         50 | static const hrt_address SP_CTRL_BASE[N_SP_ID] = {
            |                          ^~~~~~~~~~~~
      ./drivers/staging/media/atomisp//pci/system_local.h:45:26: warning: ‘ISP_BAMEM_BASE’ defined but not used [-Wunused-const-variable=]
         45 | static const hrt_address ISP_BAMEM_BASE[N_BAMEM_ID] = {
            |                          ^~~~~~~~~~~~~~
      ./drivers/staging/media/atomisp//pci/system_local.h:41:26: warning: ‘ISP_DMEM_BASE’ defined but not used [-Wunused-const-variable=]
         41 | static const hrt_address ISP_DMEM_BASE[N_ISP_ID] = {
            |                          ^~~~~~~~~~~~~
      ./drivers/staging/media/atomisp//pci/system_local.h:37:26: warning: ‘ISP_CTRL_BASE’ defined but not used [-Wunused-const-variable=]
         37 | static const hrt_address ISP_CTRL_BASE[N_ISP_ID] = {
            |                          ^~~~~~~~~~~~~
      In file included from ./drivers/staging/media/atomisp//pci/ia_css_acc_types.h:23,
                       from ./drivers/staging/media/atomisp//pci/ia_css_pipe_public.h:29,
                       from drivers/staging/media/atomisp/pci/sh_css_legacy.h:23,
                       from drivers/staging/media/atomisp/pci/atomisp_internal.h:34,
                       from drivers/staging/media/atomisp/pci/atomisp_acc.h:23,
                       from drivers/staging/media/atomisp/pci/atomisp_acc.c:29:
      ./drivers/staging/media/atomisp//pci/system_local.h:193:26: warning: ‘STREAM2MMIO_CTRL_BASE’ defined but not used [-Wunused-const-variable=]
        193 | static const hrt_address STREAM2MMIO_CTRL_BASE[N_STREAM2MMIO_ID] = {
            |                          ^~~~~~~~~~~~~~~~~~~~~
      ./drivers/staging/media/atomisp//pci/system_local.h:186:26: warning: ‘PIXELGEN_CTRL_BASE’ defined but not used [-Wunused-const-variable=]
        186 | static const hrt_address PIXELGEN_CTRL_BASE[N_PIXELGEN_ID] = {
            |                          ^~~~~~~~~~~~~~~~~~
      ./drivers/staging/media/atomisp//pci/system_local.h:179:26: warning: ‘CSI_RX_BE_CTRL_BASE’ defined but not used [-Wunused-const-variable=]
        179 | static const hrt_address CSI_RX_BE_CTRL_BASE[N_CSI_RX_BACKEND_ID] = {
            |                          ^~~~~~~~~~~~~~~~~~~
      ./drivers/staging/media/atomisp//pci/system_local.h:172:26: warning: ‘CSI_RX_FE_CTRL_BASE’ defined but not used [-Wunused-const-variable=]
        172 | static const hrt_address CSI_RX_FE_CTRL_BASE[N_CSI_RX_FRONTEND_ID] = {
            |                          ^~~~~~~~~~~~~~~~~~~
      ./drivers/staging/media/atomisp//pci/system_local.h:165:26: warning: ‘ISYS_IRQ_BASE’ defined but not used [-Wunused-const-variable=]
        165 | static const hrt_address ISYS_IRQ_BASE[N_ISYS_IRQ_ID] = {
            |                          ^~~~~~~~~~~~~
      ./drivers/staging/media/atomisp//pci/system_local.h:158:26: warning: ‘IBUF_CTRL_BASE’ defined but not used [-Wunused-const-variable=]
        158 | static const hrt_address IBUF_CTRL_BASE[N_IBUF_CTRL_ID] = {
            |                          ^~~~~~~~~~~~~~
      ./drivers/staging/media/atomisp//pci/system_local.h:153:26: warning: ‘RX_BASE’ defined but not used [-Wunused-const-variable=]
        153 | static const hrt_address RX_BASE[N_RX_ID] = {
            |                          ^~~~~~~
      ./drivers/staging/media/atomisp//pci/system_local.h:138:26: warning: ‘INPUT_SYSTEM_BASE’ defined but not used [-Wunused-const-variable=]
        138 | static const hrt_address INPUT_SYSTEM_BASE[N_INPUT_SYSTEM_ID] = {
            |                          ^~~~~~~~~~~~~~~~~
      ./drivers/staging/media/atomisp//pci/system_local.h:130:26: warning: ‘INPUT_FORMATTER_BASE’ defined but not used [-Wunused-const-variable=]
        130 | static const hrt_address INPUT_FORMATTER_BASE[N_INPUT_FORMATTER_ID] = {
            |                          ^~~~~~~~~~~~~~~~~~~~
      ./drivers/staging/media/atomisp//pci/system_local.h:125:26: warning: ‘TIMED_CTRL_BASE’ defined but not used [-Wunused-const-variable=]
        125 | static const hrt_address TIMED_CTRL_BASE[N_TIMED_CTRL_ID] = {
            |                          ^~~~~~~~~~~~~~~
      ./drivers/staging/media/atomisp//pci/system_local.h:120:26: warning: ‘GPIO_BASE’ defined but not used [-Wunused-const-variable=]
        120 | static const hrt_address GPIO_BASE[N_GPIO_ID] = {
            |                          ^~~~~~~~~
      ./drivers/staging/media/atomisp//pci/system_local.h:116:26: warning: ‘GP_TIMER_BASE’ defined but not used [-Wunused-const-variable=]
        116 | static const hrt_address GP_TIMER_BASE =
            |                          ^~~~~~~~~~~~~
      ./drivers/staging/media/atomisp//pci/system_local.h:109:26: warning: ‘GP_DEVICE_BASE’ defined but not used [-Wunused-const-variable=]
        109 | static const hrt_address GP_DEVICE_BASE[N_GP_DEVICE_ID] = {
            |                          ^~~~~~~~~~~~~~
      ./drivers/staging/media/atomisp//pci/system_local.h:96:26: warning: ‘FIFO_MONITOR_BASE’ defined but not used [-Wunused-const-variable=]
         96 | static const hrt_address FIFO_MONITOR_BASE[N_FIFO_MONITOR_ID] = {
            |                          ^~~~~~~~~~~~~~~~~
      ./drivers/staging/media/atomisp//pci/system_local.h:90:26: warning: ‘GDC_BASE’ defined but not used [-Wunused-const-variable=]
         90 | static const hrt_address GDC_BASE[N_GDC_ID] = {
            |                          ^~~~~~~~
      ./drivers/staging/media/atomisp//pci/system_local.h:78:26: warning: ‘IRQ_BASE’ defined but not used [-Wunused-const-variable=]
         78 | static const hrt_address IRQ_BASE[N_IRQ_ID] = {
            |                          ^~~~~~~~
      ./drivers/staging/media/atomisp//pci/system_local.h:73:26: warning: ‘ISYS2401_DMA_BASE’ defined but not used [-Wunused-const-variable=]
         73 | static const hrt_address ISYS2401_DMA_BASE[N_ISYS2401_DMA_ID] = {
            |                          ^~~~~~~~~~~~~~~~~
      ./drivers/staging/media/atomisp//pci/system_local.h:69:26: warning: ‘DMA_BASE’ defined but not used [-Wunused-const-variable=]
         69 | static const hrt_address DMA_BASE[N_DMA_ID] = {
            |                          ^~~~~~~~
      ./drivers/staging/media/atomisp//pci/system_local.h:63:26: warning: ‘MMU_BASE’ defined but not used [-Wunused-const-variable=]
         63 | static const hrt_address MMU_BASE[N_MMU_ID] = {
            |                          ^~~~~~~~
      ./drivers/staging/media/atomisp//pci/system_local.h:54:26: warning: ‘SP_DMEM_BASE’ defined but not used [-Wunused-const-variable=]
         54 | static const hrt_address SP_DMEM_BASE[N_SP_ID] = {
            |                          ^~~~~~~~~~~~
      ./drivers/staging/media/atomisp//pci/system_local.h:50:26: warning: ‘SP_CTRL_BASE’ defined but not used [-Wunused-const-variable=]
         50 | static const hrt_address SP_CTRL_BASE[N_SP_ID] = {
            |                          ^~~~~~~~~~~~
      ./drivers/staging/media/atomisp//pci/system_local.h:45:26: warning: ‘ISP_BAMEM_BASE’ defined but not used [-Wunused-const-variable=]
         45 | static const hrt_address ISP_BAMEM_BASE[N_BAMEM_ID] = {
            |                          ^~~~~~~~~~~~~~
      ./drivers/staging/media/atomisp//pci/system_local.h:41:26: warning: ‘ISP_DMEM_BASE’ defined but not used [-Wunused-const-variable=]
         41 | static const hrt_address ISP_DMEM_BASE[N_ISP_ID] = {
            |                          ^~~~~~~~~~~~~
      ./drivers/staging/media/atomisp//pci/system_local.h:37:26: warning: ‘ISP_CTRL_BASE’ defined but not used [-Wunused-const-variable=]
         37 | static const hrt_address ISP_CTRL_BASE[N_ISP_ID] = {
            |                          ^~~~~~~~~~~~~
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+huawei@kernel.org>
      85ebb8eb
    • Mauro Carvalho Chehab's avatar
      media: atomisp: get rid of version-specific system_local.h · 08b2bcc6
      Mauro Carvalho Chehab authored
      After removing the unused 32-bits data, the isp2401_system_local.h
      now contains everything that it is needed, either by isp2401 or
      by isp2400.
      
      So, remove code duplication.
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+huawei@kernel.org>
      08b2bcc6
    • Mauro Carvalho Chehab's avatar
      media: atomisp: move global stuff into a common header · 4b28ded7
      Mauro Carvalho Chehab authored
      Right now, there are two versions of system_global.h headers.
      
      Both share a lot of common code. There are some ISP2401 specific
      types on one of the headers, but it doesn't conflict with the
      ISP2400 ones.
      
      Also, the common code is identical.
      
      So, remove code duplication by moving such code into a
      common header.
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+huawei@kernel.org>
      4b28ded7
    • Mauro Carvalho Chehab's avatar
      media: atomisp: remove non-used 32-bits consts at system_local · a6154805
      Mauro Carvalho Chehab authored
      There is an abstraction at the code in order to support
      32 or 64 bits address/data length. However, for all
      Atom chipsets supported by this version, the size is fixed.
      
      So, cleanup the mess, removing the uused code and placing
      the data sizes on a single place.
      
      The end goal is to completely remove those local/global
      headers, replacing them by some ISP-version dependent struct,
      in order for the driver to decide what version it would need
      in runtime.
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+huawei@kernel.org>
      a6154805
    • Mauro Carvalho Chehab's avatar
      media: atomisp: get rid of some unused static vars · ecf1b4ca
      Mauro Carvalho Chehab authored
      There are several static vars declared inside the
      system local headers. This causes lots of warnings when W=1.
      
      Remove the unused ones.
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+huawei@kernel.org>
      ecf1b4ca
    • Dan Carpenter's avatar
      media: atomisp: Fix error code in ov5693_probe() · ac828456
      Dan Carpenter authored
      If gmin_camera_platform_data() returns NULL then we should return a
      negative error instead of success.
      
      Fixes: 90ebe55a ("media: staging: atomisp: Add driver prefix to Kconfig option and module names")
      Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+huawei@kernel.org>
      ac828456
    • Nicolas Boichat's avatar
      media: atomisp: Replace trace_printk by pr_info · 3d81099c
      Nicolas Boichat authored
      trace_printk should not be used in production code, replace it
      call with pr_info.
      Signed-off-by: default avatarNicolas Boichat <drinkcat@chromium.org>
      Acked-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+huawei@kernel.org>
      3d81099c
    • Baidyanath Kundu's avatar
      media: atomisp: Fix __func__ style warnings · d8ebd811
      Baidyanath Kundu authored
      This patch fixes the checkpatch.pl warning:
      
      Prefer using '"%s...", __func__' to using '<function name>',
      this function's name, in a string
      Signed-off-by: default avatarBaidyanath Kundu <kundubaidya99@gmail.com>
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+huawei@kernel.org>
      d8ebd811
    • Mauro Carvalho Chehab's avatar
      media: atomisp: fix help message for ISP2401 selection · 52c6f42f
      Mauro Carvalho Chehab authored
      I'm pretty sure I named this right, but it sounds that I ended
      doing something weird maybe while solving some conflict.
      
      So, fix the title of this config var.
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+huawei@kernel.org>
      52c6f42f
  7. 18 Jul, 2020 6 commits