- 27 Oct, 2015 40 commits
-
-
Alison Schofield authored
Remove unneeded forward function declarations. Addresses checkpatch.pl: WARNING: externs should be avoided in .c files Signed-off-by:
Alison Schofield <amsfield22@gmail.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Alison Schofield authored
Move function types to be adjacent to the function names in declarations to improve readability. Signed-off-by:
-
Alison Schofield authored
Adds required spacing around operands to improve readability. Corrects checkpatch.pl ERROR: spaces required * Signed-off-by:
-
Alison Schofield authored
Reworked comments per kernel coding style to improve readability. Corrects checkpatch.pl: WARNING: Block comments use * on subsequent lines WARNING: line over 80 characters Signed-off-by:
-
Amitoj Kaur Chawla authored
Remove unnecessary variable that can be replaced with a single line of code. The semantic patch used to find this is: // <smpl> @@ expression ret; @@ - if (ret) return ret; - return 0; + return ret; @@ local idexpression ret; expression e; @@ - ret = e; - return ret; + return e; @@ type T; identifier i; expression E; @@ - T i = E; ... when != i @@ type T; identifier i; @@ - T i; ... when != i // </smpl> Signed-off-by:
Amitoj Kaur Chawla <amitoj1606@gmail.com> Signed-off-by:
-
Amitoj Kaur Chawla authored
Drop unused function that is defined but is not called anywhere. Signed-off-by:
-
Amitoj Kaur Chawla authored
Remove unnecessary variables that can be replaced with a single line of code. The semantic patch used to find this is: // <smpl> @@ expression ret; @@ - if (ret) return ret; - return 0; + return ret; @@ local idexpression ret; expression e; @@ - ret = e; - return ret; + return e; @@ type T; identifier i; expression E; @@ - T i = E; ... when != i @@ type T; identifier i; @@ - T i; ... when != i // </smpl> Signed-off-by:
-
Shraddha Barke authored
Remove declaration of function lprocfs_wr_timeouts from header file since it is not used Signed-off-by:
Shraddha Barke <shraddha.6596@gmail.com> Signed-off-by:
-
Shraddha Barke authored
Remove the functions which are defined but not used anywhere Signed-off-by:
-
Eva Rachel Retuya authored
Fix alignment issues by properly indenting function parameters in accordance to the kernel coding style. Checkpatch pointed out this issue. CHECK: Alignment should match open parenthesis Signed-off-by:
Eva Rachel Retuya <eraretuya@gmail.com> Signed-off-by:
-
Amitoj Kaur Chawla authored
Remove the export symbol for static function. The semantic patch used to find this is: // <smpl> @r@ type T; identifier f; @@ static T f (...) { ... } @@ identifier r.f; declarer name EXPORT_SYMBOL; @@ -EXPORT_SYMBOL(f); // </smpl> Signed-off-by: -
Amarjargal Gundjalam authored
This patch fixes the checkpatch issue: CHECK: Logical continuations should be on the previous line Signed-off-by:
Amarjargal Gundjalam <amarjargal.gundjalam@gmail.com> Signed-off-by:
-
Amarjargal Gundjalam authored
This patch fixes some of the checkpatch issue: CHECK: Alignment should match open parenthesis Signed-off-by:
-
Amarjargal Gundjalam authored
This patch fixes checkpatch issues: CHECK: Blank lines aren't necessary before a close brace '}' CHECK: Please don't use multiple blank lines Signed-off-by:
-
Amarjargal Gundjalam authored
This patch fixes some of the checkpatch issue: CHECK: Prefer using the BIT macro Signed-off-by:
-
Amarjargal Gundjalam authored
This patch fixes the checkpatch issue: CHECK: 'splitted' may be misspelled - perhaps 'split'? Signed-off-by:
-
Amarjargal Gundjalam authored
This patch fixes the checkpatch issue: CHECK: Comparison to NULL could be written Signed-off-by:
-
Burcin Akalin authored
Remove multiple blank lines. Problem found using checkpatch.pl "CHECK: Please don't use multiple blank lines" Signed-off-by:
Burcin Akalin <brcnakalin@gmail.com> Signed-off-by:
-
Burcin Akalin authored
Add space around operator '|'. Problem found using checkpatch.pl CHECK: spaces preferred around that '|' (ctx:VxV) Signed-off-by:
-
Alison Schofield authored
Replace one block comment with a single line comment. Follow style of previous comment and omit word channel, since it's clear the topic is channels. Addresses checkpatch.pl: WARNING: Block comments use * on subsequent lines Signed-off-by:
-
Alison Schofield authored
Replace lower case names in the enum dummy_scan_elements with uppercase names and a descriptive prefix: DUMMY_INDEX_ Signed-off-by:
-
Cristina Moraru authored
We need to check adis16060_spi_read return code to avoid feeding user space with bogus data. While, at it introduce out_unlock label in order to simplify locking on error path. Signed-off-by:
Cristina Moraru <cristina.moraru09@gmail.com> Signed-off-by:
-
Cristina Moraru authored
Remove variable that is initialized but not used. Signed-off-by:
-
Burcin Akalin authored
Remove multiple blank lines. Problem found using checkpatch.pl "CHECK: Please don't use multiple blank lines". Signed-off-by:
-
Amarjargal Gundjalam authored
This patch fixes the checkpatch.pl warnings: WARNING: Block comments use * on subsequent lines WARNING: Block comments use a trailing */ on a separate line Signed-off-by:
-
Amarjargal Gundjalam authored
This patch fixes the checkpatch.pl check: CHECK: spaces preferred around that ‘’ Signed-off-by:
-
Amarjargal Gundjalam authored
This patch fixes the checkpatch.pl check: CHECK: No space is necessary after a cast Signed-off-by:
-
Amarjargal Gundjalam authored
This patch fixes the checkpatch.pl check: CHECK: Please don't use multiple blank lines Signed-off-by:
-
Lijun Pan authored
WARNING: drivers/staging/built-in.o(.init.text+0xdc): Section mismatch in reference from the function fsl_mc_bus_driver_init() to the function .exit.text:dprc_driver_exit() The function __init fsl_mc_bus_driver_init() references a function __exit dprc_driver_exit(). This is often seen when error handling in the init function uses functionality in the exit path. The fix is often to remove the __exit annotation of dprc_driver_exit() so it may be used outside an exit section. Signed-off-by:
Lijun Pan <Lijun.Pan@freescale.com> Signed-off-by:
-
Ksenija Stanojevic authored
Static inline functions are preferred over macros. The function is placed in obd_class.h instead lprocfs_status.h because obd_class.h includes header obd.h which contains definition of struct obd_device and in that way avoids build error: Dereferencing pointer to incomplete type. Also remove macro LPROCFS_CLIMP_CHECK since it's no longer used. Signed-off-by:
Ksenija Stanojevic <ksenija.stanojevic@gmail.com> Signed-off-by:
-
Amitoj Kaur Chawla authored
Replace seq_printf() with seq_putc() since it is more expensive than seq_putc(). Signed-off-by:
-
Cristina Moraru authored
Replace single variable sscanf with specialized function kstrtoint at the suggestion of checkpatch.pl, to fix 'WARNING: Prefer kstrto<type> to single variable sscanf' Signed-off-by:
-
Mike Rapoport authored
The OBD_PAGE_ALLOC/FREE and related macros are not used and can be removed Signed-off-by:
Mike Rapoport <mike.rapoport@gmail.com> Signed-off-by:
-
Mike Rapoport authored
Use alloc_page and __free_page instead Signed-off-by:
-
Cristina Moraru authored
Error stored in rc was never reported, so directly return it here. Signed-off-by:
-
Shraddha Barke authored
Remove the header file obd_cache.h since it is not needed Signed-off-by:
-
Shraddha Barke authored
Since sptlrpc_rule_set_expand is static, export symbol is not needed Signed-off-by:
-
Amitoj Kaur Chawla authored
Remove the export symbol for static function. The semantic patch used to find this is: // <smpl> @r@ type T; identifier f; @@ static T f (...) { ... } @@ identifier r.f; declarer name EXPORT_SYMBOL; @@ -EXPORT_SYMBOL(f); // </smpl> Signed-off-by: -
Ian Abbott authored
`comedi_nsamples_left(s, nsamples)` returns the number of samples remaining to complete an asynchronous command or the passed in `nsamples`, whichever is lower. However, it goes wrong in the extreme case of setting the `nsamples` parameter to `UINT_MAX` when the number of conversions per "scan" (`s->async->cmd.scan_end_arg`) is 1. It uses `comedi_nscans_remaining(s, nscans)` to determine the number of scans remaining, or the parameter `nscans`, whichever is lower. To determine the parameter `nscans`, it divides `nsamples` by the number of conversions per scan and adds 1. The addition of 1 is to avoid setting the parameter `nscans` to 0, as `comedi_nscans_remaining(s, nscans)` treats that value specially. However in the extreme case where `nsamples` is `UINT_MAX` and the number of samples per scan is 1, the addition of 1 to `nscans` overflows, producing the unwanted 0. Fix it by refactoring new a function `__comedi_nscans_remaining(s, nscans)` out of `comedi_nscans_remaining(s, nscans)`. The new function does everything except the special handling when `nscans` is 0. Change `comedi_nsamples_remaining()` to call the new function without adding 1 to `nscans` to avoid the overflow. This overflow bug doesn't affect any of the current COMEDI drivers. I stumbled across it while changing to one of the drivers. Signed-off-by:
Ian Abbott <abbotti@mev.co.uk> Signed-off-by:
-
Shivani Bhardwaj authored
Parentheses around some arguments and expressions are not required and should be removed. Signed-off-by:
Shivani Bhardwaj <shivanib134@gmail.com> Signed-off-by:
-
