1. 23 May, 2017 1 commit
  2. 22 May, 2017 2 commits
  3. 21 May, 2017 1 commit
  4. 20 May, 2017 6 commits
    • Jan Lindström's avatar
      MDEV-12615: InnoDB page compression method snappy mostly does not compress pages · 90c52e52
      Jan Lindström authored
      Snappy compression method require that output buffer
      used for compression is bigger than input buffer.
      Similarly lzo require additional work memory buffer.
      Increase the allocated buffer accordingly.
      
      buf_tmp_buffer_t: removed unnecessary lzo_mem, crypt_buf_free and
      comp_buf_free.
      
      buf_pool_reserve_tmp_slot: use alligned_alloc and if snappy
      available allocate size based on snappy_max_compressed_length and
      if lzo is available increase buffer by LZO1X_1_15_MEM_COMPRESS.
      
      fil_compress_page: Remove unneeded lzo mem (we use same buffer)
      and if output buffer is not yet allocated allocate based similarly
      as above.
      
      Decompression does not require additional work area.
      
          Modify test to use same test as other compression method tests.
      90c52e52
    • Marko Mäkelä's avatar
      f8802009
    • Marko Mäkelä's avatar
      fe291c68
    • Marko Mäkelä's avatar
      Clean up a test · 45fe62b8
      Marko Mäkelä authored
      Changed global parameters will be reset by server restart.
      There is no need to save and restore the original values.
      45fe62b8
    • Marko Mäkelä's avatar
      After-merge fix for MDEV-11638 · a4d4a5fe
      Marko Mäkelä authored
      In commit 360a4a03
      some debug assertions were introduced to the page flushing code
      in XtraDB. Add these assertions to InnoDB as well, and adjust
      the InnoDB shutdown so that these assertions will not fail.
      
      logs_empty_and_mark_files_at_shutdown(): Advance
      srv_shutdown_state from the first phase SRV_SHUTDOWN_CLEANUP
      only after no page-dirtying activity is possible
      (well, except by srv_master_do_shutdown_tasks(), which will be
      fixed separately in MDEV-12052).
      
      rotate_thread_t::should_shutdown(): Already exit the key rotation
      threads at the first phase of shutdown (SRV_SHUTDOWN_CLEANUP).
      
      page_cleaner_sleep_if_needed(): Do not sleep during shutdown.
      This change is originally from XtraDB.
      a4d4a5fe
    • Marko Mäkelä's avatar
      Merge 10.0 into 10.1 · 65e1399e
      Marko Mäkelä authored
      Significantly reduce the amount of InnoDB, XtraDB and Mariabackup
      code changes by defining pfs_os_file_t as something that is
      transparently compatible with os_file_t.
      65e1399e
  5. 19 May, 2017 7 commits
  6. 18 May, 2017 14 commits
  7. 17 May, 2017 9 commits
    • Igor Babaev's avatar
      Fixed the bug mdev-12812. · efb9f261
      Igor Babaev authored
      This is another correction of the patch for bug mdev-12670.
      If a derived table is merged into a select with STRAIGHT_JOIN
      modifier all IN subquery predicates contained in the
      specification of the derived table cannot be subject to
      conversion to semi-joins.
      efb9f261
    • Igor Babaev's avatar
      Fixed the bug mdev-12817/mdev-12820. · 7e971631
      Igor Babaev authored
      This patch is a correction of the patch for bug mdev-12670.
      With the current code handling semi-joins the following must
      be taken into account.
      Conversion of an IN subquery predicate into semi-join
      has to be blocked if the predicate occurs:
      (a) in the ON expression of an outer join
      (b) in the ON expression of an inner join embedded directly
          or indirectly in the inner nest of an outer join.
      The patch for mdev-12670 blocked conversion to semi-joins only
      in the case (a), but not in the case (b). This patch blocks
      the conversion in both cases.
      7e971631
    • Vicențiu Ciorbaru's avatar
    • Vicențiu Ciorbaru's avatar
      8b0db08f
    • Vicențiu Ciorbaru's avatar
      Fix tokudb test failures post merge · 3670d167
      Vicențiu Ciorbaru authored
      3670d167
    • Marko Mäkelä's avatar
      Follow-up to MDEV-12534: Align srv_sys · 8b34aabf
      Marko Mäkelä authored
      Allocate srv_sys statically so that the desired alignment can be
      guaranteed. This silences -fsanitize=undefined warnings.
      There probably is no performance impact of this, because the
      reason for the alignment to ensure the absence of false sharing
      between counters. Even with the misalignment, each counter would
      have been been aligned at 64 bits, and the counters would reside
      in separate cache lines.
      8b34aabf
    • Marko Mäkelä's avatar
      MDEV-12358 Work around what looks like a bug in GCC 7.1.0 · 9f89b94b
      Marko Mäkelä authored
      The parameter thr of the function btr_cur_optimistic_insert()
      is not declared as nonnull, but GCC 7.1.0 with -O3 is wrongly
      optimizing away the first part of the condition
      UNIV_UNLIKELY(thr && thr_get_trx(thr)->fake_changes)
      when the function is being called by row_merge_insert_index_tuples()
      with thr==NULL.
      
      The fake_changes is an XtraDB addition. This GCC bug only appears
      to have an impact on XtraDB, not InnoDB.
      
      We work around the problem by not attempting to dereference thr
      when both BTR_NO_LOCKING_FLAG and BTR_NO_UNDO_LOG_FLAG are set
      in the flags. Probably BTR_NO_LOCKING_FLAG alone should suffice.
      
      btr_cur_optimistic_insert(), btr_cur_pessimistic_insert(),
      btr_cur_pessimistic_update(): Correct comments that disagree with
      usage and with nonnull attributes. No other parameter than thr can
      actually be NULL.
      
      row_ins_duplicate_error_in_clust(): Remove an unused parameter.
      
      innobase_is_fake_change(): Unused function; remove.
      
      ibuf_insert_low(), row_log_table_apply(), row_log_apply(),
      row_undo_mod_clust_low():
      Because we will be passing BTR_NO_LOCKING_FLAG | BTR_NO_UNDO_LOG_FLAG
      in the flags, the trx->fake_changes flag will be treated as false,
      which is the right thing to do at these low-level operations
      (change buffer merge, ALTER TABLE…LOCK=NONE, or ROLLBACK).
      This might be fixing actual XtraDB bugs.
      
      Other callers that pass these two flags are also passing thr=NULL,
      implying fake_changes=false. (Some callers in ROLLBACK are passing
      BTR_NO_LOCKING_FLAG and a nonnull thr. In these callers, fake_changes
      better be false, to avoid corruption.)
      9f89b94b
    • Vicențiu Ciorbaru's avatar
      Fix sys_vars innodb_empty_free_list_algorithm_basic · 5fe55b1b
      Vicențiu Ciorbaru authored
      Post xtradb 5.6.36 merge the output has changed.
      5fe55b1b
    • Vicențiu Ciorbaru's avatar
      339a290d