Commits · 2d197e51323514bc537b33a62d672d15ad0905ee · nexedi / neoppod

23 Jul, 2009 19 commits

Allow functions to start with more than one underscore (and update methods too). · 2d197e51

Vincent Pelletier authored Jul 23, 2009

Simplify method regex.
Allow method names to be used as local variables.
Allow any naming at global level (to be restricted later, when protocol.py content will be accepted by pylint and when decorators will be removed).

git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@969 71dcc9de-d417-0410-9af5-da40c76e7ee4

2d197e51

Fix naming convnetion of local variable. Found by pylint. · b81e3477

Vincent Pelletier authored Jul 23, 2009

Fix shadowing "callable" global.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@968 71dcc9de-d417-0410-9af5-da40c76e7ee4

b81e3477

Follow naming conventions for class names in epoll.py. Found by pylint. · 88a4d5b9
Vincent Pelletier authored Jul 23, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@967 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
88a4d5b9

It is not allowed, per coding style rules, to start a local variable name with... · 1fb845ad

Vincent Pelletier authored Jul 23, 2009

It is not allowed, per coding style rules, to start a local variable name with an underscore. Found by pylint.
Fixes a bug introduced in r958 (variable renaming forgotten on "if" line).

git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@966 71dcc9de-d417-0410-9af5-da40c76e7ee4

1fb845ad

Use is* methods from Node class, suppress some imports by using protocol.*. · 64215aef
Grégory Wisniewski authored Jul 23, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@965 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
64215aef
Fix first parameter of "super" function. Found by pylint. · 62e025e3
Vincent Pelletier authored Jul 23, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@964 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
62e025e3

Remove this check, implied by current handler. · 76a10f89

Grégory Wisniewski authored Jul 23, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@963 71dcc9de-d417-0410-9af5-da40c76e7ee4

76a10f89

addr and connector_handler parameters are mandatory to instantiate ClientConnection class. · 56d55c34
Vincent Pelletier authored Jul 23, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@962 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
56d55c34

Define is(Master|Storage|Client|Admin) method on Node class to avoid check with · 868be91a

Grégory Wisniewski authored Jul 23, 2009

constants from protocol module. Use them in some files, more to come.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@961 71dcc9de-d417-0410-9af5-da40c76e7ee4

868be91a

Both addr and connection_handler are mandatory constructor parameters for a ListeningConnection. · 6910e589
Vincent Pelletier authored Jul 23, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@960 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
6910e589

Fix typo. · 67d8699b

Grégory Wisniewski authored Jul 23, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@959 71dcc9de-d417-0410-9af5-da40c76e7ee4

67d8699b

Don't shadow built-ins. · db0f8473

Grégory Wisniewski authored Jul 23, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@958 71dcc9de-d417-0410-9af5-da40c76e7ee4

db0f8473

Don't shadow filter built-in function, and using it. · 7b3d9eea
Grégory Wisniewski authored Jul 23, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@957 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
7b3d9eea

Remove unnecessary pass statements. · ec30d8f5

Grégory Wisniewski authored Jul 23, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@956 71dcc9de-d417-0410-9af5-da40c76e7ee4

ec30d8f5

Don't use more than one statement per line. · dcc9fbce

Grégory Wisniewski authored Jul 23, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@955 71dcc9de-d417-0410-9af5-da40c76e7ee4

dcc9fbce

Fix handler access. · 46950e71

Grégory Wisniewski authored Jul 23, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@954 71dcc9de-d417-0410-9af5-da40c76e7ee4

46950e71

Remove cyclic imports found by pylint. · 3cbc4ef7

Grégory Wisniewski authored Jul 23, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@953 71dcc9de-d417-0410-9af5-da40c76e7ee4

3cbc4ef7

Revert commit 950: the missing space after '*' operator was not detected by... · 203fb855

Vincent Pelletier authored Jul 23, 2009

Revert commit 950: the missing space after '*' operator was not detected by pylint because in that use it's not a binary operator, so coding style doesn't require them to be followed by a space.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@952 71dcc9de-d417-0410-9af5-da40c76e7ee4

203fb855

Add a XXX comment. · ea0a6843

Grégory Wisniewski authored Jul 23, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@951 71dcc9de-d417-0410-9af5-da40c76e7ee4

ea0a6843

22 Jul, 2009 21 commits

Add missing space after operators. *NOT* found by pylint. · d2aed947
Grégory Wisniewski authored Jul 22, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@950 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
d2aed947

Remove raise of NotImplementedError in base storage handler since sub handlers · e1292c5a

Grégory Wisniewski authored Jul 22, 2009

don't always have to override those methods. 


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@949 71dcc9de-d417-0410-9af5-da40c76e7ee4

e1292c5a

Remove some unused imports found by pylint. · 9e55b249

Grégory Wisniewski authored Jul 22, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@948 71dcc9de-d417-0410-9af5-da40c76e7ee4

9e55b249

Remove useless decorator and old FIXME. · 99490a92

Grégory Wisniewski authored Jul 22, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@947 71dcc9de-d417-0410-9af5-da40c76e7ee4

99490a92

Append a space after an operator. Found by pylint. · 169cbd6b
Grégory Wisniewski authored Jul 22, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@946 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
169cbd6b
This decorator is no more usefull and thus the import too. · 5275759c
Grégory Wisniewski authored Jul 22, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@945 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
5275759c
Nodes use update() method of partition table to reduce duplicate code. · ec4ca515
Grégory Wisniewski authored Jul 22, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@944 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
ec4ca515
Add an update() method on the common partition table. · f106a20c
Grégory Wisniewski authored Jul 22, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@943 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
f106a20c
Master node don't have to process notifications from client node when · 136132cf
Grégory Wisniewski authored Jul 22, 2009
```
shutdowning.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@942 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
136132cf

Client node use update() from node manager. · 61529ea6

Grégory Wisniewski authored Jul 22, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@941 71dcc9de-d417-0410-9af5-da40c76e7ee4

61529ea6

A client node must notify the master only about storage node failures, so assert · fcd9fabc

Grégory Wisniewski authored Jul 22, 2009

this in handleNotifyNodeInformation. 


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@940 71dcc9de-d417-0410-9af5-da40c76e7ee4

fcd9fabc

Remove unused variable. · 1919687f

Grégory Wisniewski authored Jul 22, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@939 71dcc9de-d417-0410-9af5-da40c76e7ee4

1919687f

Admin node use update() from node manager. · 2122448c

Grégory Wisniewski authored Jul 22, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@938 71dcc9de-d417-0410-9af5-da40c76e7ee4

2122448c

Fix drop node command in neoctl, only one UUID is allowed as parameter. · dbbcc599
Grégory Wisniewski authored Jul 22, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@937 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
dbbcc599

Storage handlers use update() from node manager. Previous custom logic is kept · 7aa40c49

Grégory Wisniewski authored Jul 22, 2009

but should be removed later.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@936 71dcc9de-d417-0410-9af5-da40c76e7ee4

7aa40c49

Add update() method on the node manager that update itself from a node list · 709d69a5

Grégory Wisniewski authored Jul 22, 2009

received with notifyNodeInformation packet.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@935 71dcc9de-d417-0410-9af5-da40c76e7ee4

709d69a5

Remove old tests now implied by current handler. · fe0f4c9b

Grégory Wisniewski authored Jul 22, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@934 71dcc9de-d417-0410-9af5-da40c76e7ee4

fe0f4c9b

Whoops, remove wrong code copy. · 1505473b

Grégory Wisniewski authored Jul 22, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@933 71dcc9de-d417-0410-9af5-da40c76e7ee4

1505473b

Storage node never send notifyNodeInformation packet, so remove related method · da14f8dd

Grégory Wisniewski authored Jul 22, 2009

handler in recovery and verification handlers since there only storage nodes
connected to the primary master. Move the method from BaseServiceHandler, common
to client and storage node in service state, to the client service handler.

git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@932 71dcc9de-d417-0410-9af5-da40c76e7ee4

da14f8dd

Factorize cache entry access. · e8ff7064

Grégory Wisniewski authored Jul 22, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@931 71dcc9de-d417-0410-9af5-da40c76e7ee4

e8ff7064

Remove odl and now useless logging message. · 58ecdcc3

Grégory Wisniewski authored Jul 22, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@930 71dcc9de-d417-0410-9af5-da40c76e7ee4

58ecdcc3