Commits · 6a0d14b37fc85573a31d577b7b3c0136efb82099 · nexedi / neoppod

05 May, 2010 10 commits

Trigger connectionClosed() on dropped client connection. · 6a0d14b3

Grégory Wisniewski authored May 05, 2010

This avoid get zombie client nodes in manager when the cluster fallback to
verification state.

git-svn-id: https://svn.erp5.org/repos/neo/trunk@2074 71dcc9de-d417-0410-9af5-da40c76e7ee4

6a0d14b3

Check that clients are forgotten when master fall to verification. · a1883c47
Grégory Wisniewski authored May 05, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@2073 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
a1883c47

Use dict.fromkeys · 176942c6

Grégory Wisniewski authored May 05, 2010

git-svn-id: https://svn.erp5.org/repos/neo/trunk@2072 71dcc9de-d417-0410-9af5-da40c76e7ee4

176942c6

Don't change a node after removal. · 55e92444

Grégory Wisniewski authored May 05, 2010

git-svn-id: https://svn.erp5.org/repos/neo/trunk@2071 71dcc9de-d417-0410-9af5-da40c76e7ee4

55e92444

Drop client connections when leaving operation state. · 291344ac

Grégory Wisniewski authored May 05, 2010

And clear queued event.

git-svn-id: https://svn.erp5.org/repos/neo/trunk@2070 71dcc9de-d417-0410-9af5-da40c76e7ee4

291344ac

Remove disconnected clients from storage's node manager. · 4c79f0b7
Grégory Wisniewski authored May 05, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@2069 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
4c79f0b7
No distinction is made when a client connection is lost, merge. · 49c8ddd6
Grégory Wisniewski authored May 05, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@2068 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
49c8ddd6
Update identified index only in case of changes. · 6ab80ea8
Grégory Wisniewski authored May 05, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@2067 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
6ab80ea8
Always unindex a node when removed. · fe4364c4
Grégory Wisniewski authored May 05, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@2066 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
fe4364c4

Use getFakeConnection · 76b17baf

Grégory Wisniewski authored May 05, 2010

git-svn-id: https://svn.erp5.org/repos/neo/trunk@2065 71dcc9de-d417-0410-9af5-da40c76e7ee4

76b17baf

04 May, 2010 6 commits

Fix decorator. · 64a63d76

Grégory Wisniewski authored May 04, 2010

git-svn-id: https://svn.erp5.org/repos/neo/trunk@2064 71dcc9de-d417-0410-9af5-da40c76e7ee4

64a63d76

Save and restore errno value around sighandler. · ff968d44

Vincent Pelletier authored May 04, 2010

The signal is often received during epoll_wait call, and python code later
checks the value of libc's errno. That value might get tainted by
sighandler, causing errors to be detected after the call (epoll_wait would
return -1 as the call was interrupted by the signal).

git-svn-id: https://svn.erp5.org/repos/neo/trunk@2063 71dcc9de-d417-0410-9af5-da40c76e7ee4

ff968d44

Fix traceback module use, and factorise code. · dfe60f81
Vincent Pelletier authored May 04, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@2062 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
dfe60f81

Add "live" debugging facility. · b9859fa8

Vincent Pelletier authored May 04, 2010

Disabled by default, as it allows code injection in NEO processes to
anyone with the ability to send signals to them and either write access to
NEO product or its controlling TTY.

git-svn-id: https://svn.erp5.org/repos/neo/trunk@2061 71dcc9de-d417-0410-9af5-da40c76e7ee4

b9859fa8

Remove unneeded parameter. · 32a4ff45

Vincent Pelletier authored May 04, 2010

git-svn-id: https://svn.erp5.org/repos/neo/trunk@2060 71dcc9de-d417-0410-9af5-da40c76e7ee4

32a4ff45

Update comment which should have been updated in r2049. · 52724198
Vincent Pelletier authored May 04, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@2059 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
52724198

30 Apr, 2010 16 commits

Use bool() instead of not(not()) · a22440f1

Grégory Wisniewski authored Apr 30, 2010

git-svn-id: https://svn.erp5.org/repos/neo/trunk@2058 71dcc9de-d417-0410-9af5-da40c76e7ee4

a22440f1

Remove unused definition. · b283d492

Grégory Wisniewski authored Apr 30, 2010

git-svn-id: https://svn.erp5.org/repos/neo/trunk@2057 71dcc9de-d417-0410-9af5-da40c76e7ee4

b283d492

Add __repr__ to Connection. · 6b60a310

Grégory Wisniewski authored Apr 30, 2010

git-svn-id: https://svn.erp5.org/repos/neo/trunk@2056 71dcc9de-d417-0410-9af5-da40c76e7ee4

6b60a310

Use more getFakeConnection() to build a clean mock object. · fd11d103
Grégory Wisniewski authored Apr 30, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@2055 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
fd11d103

Fix typo in comment. · 7b66b2c2

Vincent Pelletier authored Apr 30, 2010

git-svn-id: https://svn.erp5.org/repos/neo/trunk@2054 71dcc9de-d417-0410-9af5-da40c76e7ee4

7b66b2c2

Make storage node log its own UUID when known. · ca6831c9
Vincent Pelletier authored Apr 30, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@2053 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
ca6831c9
Check removed value is the expected one in __update and __updateSet. · 9b45ccc9
Vincent Pelletier authored Apr 30, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@2052 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
9b45ccc9

Check that node is not identified in NodeManager.remove . · 576bea44

Vincent Pelletier authored Apr 30, 2010

If it is still identified, the node would still be referenced in node
manager although having been asked for removal.

git-svn-id: https://svn.erp5.org/repos/neo/trunk@2051 71dcc9de-d417-0410-9af5-da40c76e7ee4

576bea44

Output logs in supposed-to-not-happen cases. · 0ae50a9f
Vincent Pelletier authored Apr 30, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@2050 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
0ae50a9f

Rewrite NodeManager.update main code. · 16340bad

Vincent Pelletier authored Apr 30, 2010

- Don't trash a node to recreate it right after (it was the case when a
  node was known by address only).
- Check node type consistency between:
  - parameters and node found
  - node known by type and node known by UUID
- Log actions before doing them, consistently
- Log found node in addition to loop variables
- Don't call remove when an unknown node is notified as down, and add a
  log for this case

git-svn-id: https://svn.erp5.org/repos/neo/trunk@2049 71dcc9de-d417-0410-9af5-da40c76e7ee4

16340bad

Only update node address and UUID when they actually change. · 762da524
Vincent Pelletier authored Apr 30, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@2048 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
762da524
Call _getClassFromNodeType rather than duplicating its code. · 961d69dc
Vincent Pelletier authored Apr 30, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@2047 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
961d69dc
Make node register itself to node manager. · bbaa9a63
Vincent Pelletier authored Apr 30, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@2046 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
bbaa9a63
ValueError seems more appropriate than RuntimeError. · ca861ad6
Vincent Pelletier authored Apr 30, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@2045 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
ca861ad6
Split NodeManager.createFromNodeType into 2 methods for reusability. · b7014b83
Vincent Pelletier authored Apr 30, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@2044 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
b7014b83
Display instance id in Node.__repr__ . · b5659e15
Vincent Pelletier authored Apr 30, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@2043 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
b5659e15

28 Apr, 2010 8 commits

Handle answers after sending abort notifications (improving parallelism). · 743f14c4
Vincent Pelletier authored Apr 28, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@2042 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
743f14c4
Catch (and log) exceptions happening in packet handler in tpc_abort. · cd7677dc
Vincent Pelletier authored Apr 28, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@2041 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
cd7677dc

Avoid one unneeded union_update. · 366fa397

Vincent Pelletier authored Apr 28, 2010

git-svn-id: https://svn.erp5.org/repos/neo/trunk@2040 71dcc9de-d417-0410-9af5-da40c76e7ee4

366fa397

Factorise packet creation. · d4658bc6

Vincent Pelletier authored Apr 28, 2010

git-svn-id: https://svn.erp5.org/repos/neo/trunk@2039 71dcc9de-d417-0410-9af5-da40c76e7ee4

d4658bc6

Raise an exception when starting a transaction with unclean local_var. · 0ca4ff38
Vincent Pelletier authored Apr 28, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@2038 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
0ca4ff38
Lock connection before handling packet in _handlePacket. · c39c3478
Vincent Pelletier authored Apr 28, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@2037 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
c39c3478

Rework r2033: clear timeout before sending. · cf90e63e

Vincent Pelletier authored Apr 28, 2010

This simplifies code (and I should have done it this way from the
beginning).
Keep the lock check wrapper in MT subclass as it should have been added in
r2025 anyway.

git-svn-id: https://svn.erp5.org/repos/neo/trunk@2036 71dcc9de-d417-0410-9af5-da40c76e7ee4

cf90e63e

Allow a handler to send requests. · d7748d3c

Vincent Pelletier authored Apr 28, 2010

When a handler sends a request, always queue the response for handling
within the same handler, possibly delaying further a pending handler
switch.
This is for example required to properly complete identification between
master nodes, as the connecting master node might exit election phase
before receiving peer's AnswerPrimary when peer happens to be the primary.

git-svn-id: https://svn.erp5.org/repos/neo/trunk@2035 71dcc9de-d417-0410-9af5-da40c76e7ee4

d7748d3c