Commits · 8014153cd1b1caa3894144a95d7d0977a348efcb · nexedi / neoppod

26 Jan, 2010 15 commits

Bug fix: node variable was not assigned if None. · 8014153c
Grégory Wisniewski authored Jan 26, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1509 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
8014153c
Add a bug entry, race condition between admin, master and storage nodes. · 238084fe
Grégory Wisniewski authored Jan 26, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1508 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
238084fe

Set try/except block at the lowest level as possible. · 49fadeb1

Grégory Wisniewski authored Jan 26, 2010

- Avoid have a 'break' at the first level and the end of the 'wile True'
- Set try/except block around the only location where the exception can be raised.
- Reduce indentation
- Clarify that the loop purpose is to restart when an exception is raised.

git-svn-id: https://svn.erp5.org/repos/neo/trunk@1507 71dcc9de-d417-0410-9af5-da40c76e7ee4

49fadeb1

Move wait|announce primary code at the beginning of the related methods. · 968cd132
Grégory Wisniewski authored Jan 26, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1506 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
968cd132
Simplify a set intersection with only one element. · 14078395
Grégory Wisniewski authored Jan 26, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1505 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
14078395

Fix a typo in comment. · d880794d

Grégory Wisniewski authored Jan 26, 2010

git-svn-id: https://svn.erp5.org/repos/neo/trunk@1504 71dcc9de-d417-0410-9af5-da40c76e7ee4

d880794d

Reduce indentation. · a5c37f28

Grégory Wisniewski authored Jan 26, 2010

git-svn-id: https://svn.erp5.org/repos/neo/trunk@1503 71dcc9de-d417-0410-9af5-da40c76e7ee4

a5c37f28

Simply a condition on sets. · 18fb1a46

Grégory Wisniewski authored Jan 26, 2010

git-svn-id: https://svn.erp5.org/repos/neo/trunk@1502 71dcc9de-d417-0410-9af5-da40c76e7ee4

18fb1a46

Master's transaction manager must update the last TID with the supplied one. · 284dee7a
Grégory Wisniewski authored Jan 26, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1501 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
284dee7a
Hard kill processes after each test. · 789bd1b9
Grégory Wisniewski authored Jan 26, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1500 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
789bd1b9
Don't forget to kill NEO after any client functional test. · 3a255300
Grégory Wisniewski authored Jan 26, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1499 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
3a255300

Use ProtocolError instead of . · d3b8533a

Grégory Wisniewski authored Jan 26, 2010

UnexpectedPacketError should not be used for an invalid but expected packet type.

git-svn-id: https://svn.erp5.org/repos/neo/trunk@1498 71dcc9de-d417-0410-9af5-da40c76e7ee4

d3b8533a

Remove useless override of announcePrimary(). · b3e10426

Grégory Wisniewski authored Jan 26, 2010

UnexpectedPacketError is triggerred in BaseHandler.

git-svn-id: https://svn.erp5.org/repos/neo/trunk@1497 71dcc9de-d417-0410-9af5-da40c76e7ee4

b3e10426

Add a test module for client related features. · ca260161

Grégory Wisniewski authored Jan 26, 2010

Add a test for conflict resolution.

git-svn-id: https://svn.erp5.org/repos/neo/trunk@1496 71dcc9de-d417-0410-9af5-da40c76e7ee4

ca260161

Replace 'while 1' statements with 'while True'. · 40fc5505
Grégory Wisniewski authored Jan 26, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1495 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
40fc5505

22 Jan, 2010 25 commits

Fix test for finishTransaction(), partition table was not initialized. · 82f27499
Grégory Wisniewski authored Jan 22, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1494 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
82f27499
A little bit dirty but this avoid the special case 'None' and fix the test. · 8a9c18b4
Grégory Wisniewski authored Jan 22, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1493 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
8a9c18b4
Replace failUnless() with assertTrue() · 5cb770e5
Grégory Wisniewski authored Jan 22, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1492 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
5cb770e5
Storage node must never send this packet, even during recovery, so remove this test case. · af374f83
Grégory Wisniewski authored Jan 22, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1491 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
af374f83
Rename UnlockInformation to NotifyUnlockInformation. · f82331fc
Grégory Wisniewski authored Jan 22, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1490 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
f82331fc
Rename NotifyTransactionFinished to AnswerTransactionFinished as it's not a notification. · d3f3067e
Grégory Wisniewski authored Jan 22, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1489 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
d3f3067e
Rewrite and split of notifyInformationLocked test. · 0ffd912e
Grégory Wisniewski authored Jan 22, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1488 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
0ffd912e
Add missing helper function in test case. · ec5efd5b
Grégory Wisniewski authored Jan 22, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1487 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
ec5efd5b
Add helper methods to create nodes for testing purpose. · f61b7fd5
Grégory Wisniewski authored Jan 22, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1486 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
f61b7fd5

Fix packet kind in base test case. · 56bcf0c6

Grégory Wisniewski authored Jan 22, 2010

NotifyTransactionFinished is misspelled, it is an answer packet.
Similary, UnlockInformation is a notification, not a request.

git-svn-id: https://svn.erp5.org/repos/neo/trunk@1485 71dcc9de-d417-0410-9af5-da40c76e7ee4

56bcf0c6

Remove 'master_node_list' attribute on apps. · b7f4fbba

Grégory Wisniewski authored Jan 22, 2010

There is no need to store the master address list out of the node manager, any master found in configuration is loaded in the node manager and can be retreived by it if needed.
Remove redundant intialization code in test module, master nodes are created at app initialization.

git-svn-id: https://svn.erp5.org/repos/neo/trunk@1484 71dcc9de-d417-0410-9af5-da40c76e7ee4

b7f4fbba

The filter parameter is nor used neither implemented, remove it. · 6cdbf741
Grégory Wisniewski authored Jan 22, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1483 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
6cdbf741
This attribute no more exists in master's app since transaction manager creation. · 8f6bdebd
Grégory Wisniewski authored Jan 22, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1482 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
8f6bdebd
Fix NotifyNodeInformation docstring, only master node send this packet. · 6c192465
Grégory Wisniewski authored Jan 22, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1481 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
6c192465
The client never send this packet too. · efbd4da1
Grégory Wisniewski authored Jan 22, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1480 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
efbd4da1
Add an helper method to generate OIDs in test cases. · 821efe8d
Grégory Wisniewski authored Jan 22, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1479 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
821efe8d
This packet has been replaced by the (simpler) notifyReplicationDone (Test required). · c9619d9d
Grégory Wisniewski authored Jan 22, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1478 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
c9619d9d

A storage must never send this packet to the master node. The master has a... · ec3af08c

Grégory Wisniewski authored Jan 22, 2010

A storage must never send this packet to the master node. The master has a view of all nodes and detect itself any breakage.

git-svn-id: https://svn.erp5.org/repos/neo/trunk@1477 71dcc9de-d417-0410-9af5-da40c76e7ee4

ec3af08c

Fit better with the implementation, when a node is identified to the master,... · de257d64

Grégory Wisniewski authored Jan 22, 2010

Fit better with the implementation, when a node is identified to the master, it got an entry in the node manager.

git-svn-id: https://svn.erp5.org/repos/neo/trunk@1476 71dcc9de-d417-0410-9af5-da40c76e7ee4

de257d64

Master's now handle connection failures during recovery. · 809fce71

Grégory Wisniewski authored Jan 22, 2010

This behaviour was probably lost with the master's handler split and was found by fixing unit tests.
During recovery, if a node is lost it's state is updated but not propagated to other (storages) nodes because after the recovery they will all retreive the whole node list.

git-svn-id: https://svn.erp5.org/repos/neo/trunk@1475 71dcc9de-d417-0410-9af5-da40c76e7ee4

809fce71

Send an error to the storage node if the partition table sent is invalid... · 39544c84

Grégory Wisniewski authored Jan 22, 2010

Send an error to the storage node if the partition table sent is invalid instead of killing the master.

git-svn-id: https://svn.erp5.org/repos/neo/trunk@1474 71dcc9de-d417-0410-9af5-da40c76e7ee4

39544c84

Replace an assert with raise of IndexError exception when loading a partition with bad offsets. · 08d0e27f
Grégory Wisniewski authored Jan 22, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1473 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
08d0e27f
Nodes are initialy in unknown state since r1192, fix tests. · 2c0bf157
Grégory Wisniewski authored Jan 22, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1472 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
2c0bf157
Fix tests using broadcastNodeInformation, broken since r1451. · 60700d00
Grégory Wisniewski authored Jan 22, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1471 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
60700d00
Minor cosmetic changes in test runner. · 28182c79
Grégory Wisniewski authored Jan 22, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1470 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
28182c79