Commits · 8e199966aa0633db3a43b2ce0924add3658efdbe · nexedi / neoppod

22 May, 2009 7 commits

Improve storage bootstrap handler tests by introducing checkAskPacket(). It · 8e199966

Grégory Wisniewski authored May 22, 2009

might be better that all handlers tests classes inherits from a base class that
implements all those kind of common checks.

git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@518 71dcc9de-d417-0410-9af5-da40c76e7ee4

8e199966

Fix tests where _addPacket calls where check to zero time with calls to · 6984c60a

Grégory Wisniewski authored May 22, 2009

checkNoPacketSent that do the good job.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@517 71dcc9de-d417-0410-9af5-da40c76e7ee4

6984c60a

Fix tests with _addPacket instead of addPacket. · 22f00fe1

Grégory Wisniewski authored May 22, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@516 71dcc9de-d417-0410-9af5-da40c76e7ee4

22f00fe1

Fix test method checkNoPacketSent to follow migration from addPacket to · 421d5c65
Grégory Wisniewski authored May 22, 2009
```
notify/ask/answer.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@515 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
421d5c65

Remove checkCalledAbort method from tests since it's no more used because abort · 4d395a45

Grégory Wisniewski authored May 22, 2009

is now mainly called from neo/handler.py


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@514 71dcc9de-d417-0410-9af5-da40c76e7ee4

4d395a45

Replace a forgotten protocolError call by a raise of ProtocolError exception. · 3b6b372b
Grégory Wisniewski authored May 22, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@513 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
3b6b372b

Fix misspelled BrokenNodeDisallowedError name. · 2c0d04c7

Grégory Wisniewski authored May 22, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@512 71dcc9de-d417-0410-9af5-da40c76e7ee4

2c0d04c7

21 May, 2009 9 commits

Use differents databases between storage tests and ZODB to run them · 8c64c99e
Grégory Wisniewski authored May 21, 2009
```
simultaneously.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@511 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
8c64c99e

Handle ECONNRESET from socket level. · 9182462d

Grégory Wisniewski authored May 21, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@510 71dcc9de-d417-0410-9af5-da40c76e7ee4

9182462d

All-in-one commit : · 3d93441b

Grégory Wisniewski authored May 21, 2009

- Some private methods of Connection prefixed with '_'
- Thus those methods are no more overriden in MT* classes 
- Add description of notify/ask/answer methods and lockCheckWrapper
- Remove a forgotten addPacket from storage handler and another from master
service handler that requires to add an optional msg_id parameter to notify
- Update tests


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@509 71dcc9de-d417-0410-9af5-da40c76e7ee4

3d93441b

Last commit of exception-based error handling serie. Raise ProtocolError · ddb2d2bd

Grégory Wisniewski authored May 21, 2009

exception for all others errors.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@508 71dcc9de-d417-0410-9af5-da40c76e7ee4

ddb2d2bd

As for previous commits, raise notReadyError exception. All error send answer · 1b70a832

Grégory Wisniewski authored May 21, 2009

packets (with the id from the answered packet) when possible.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@507 71dcc9de-d417-0410-9af5-da40c76e7ee4

1b70a832

Raise an exception when a broken node send packet through a connection. Fix · eea5aff2

Grégory Wisniewski authored May 21, 2009

tests according to this changes and fix some others affected with previous
commits.

git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@506 71dcc9de-d417-0410-9af5-da40c76e7ee4

eea5aff2

Use decorators and UnexpectedPacketError exception instead of calls · aded81bc

Grégory Wisniewski authored May 21, 2009

handleUnexpectedPacket() in storage handlers.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@505 71dcc9de-d417-0410-9af5-da40c76e7ee4

aded81bc

In master handlers, replace calls to handleUnexpectedPacket() with raise of · 863a3207

Grégory Wisniewski authored May 21, 2009

UnexpectedPacketError exception or decorators previously commited.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@504 71dcc9de-d417-0410-9af5-da40c76e7ee4

863a3207

Add decorators that implements common patterns used in handlers methods. · def8b1ad
Grégory Wisniewski authored May 21, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@503 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
def8b1ad

20 May, 2009 18 commits

First part of replacement of handleUnexpectedPacket calls with raises of · 0d1ac173

Grégory Wisniewski authored May 20, 2009

UnexpectedPacketError exception. Update client (with tests) and admin nodes.
Those exceptions are now catched in dispatch() and redirect to
unexpectedPacket().

git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@502 71dcc9de-d417-0410-9af5-da40c76e7ee4

0d1ac173

Fix tests affected by commit #500. · 1ca2c441

Grégory Wisniewski authored May 20, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@501 71dcc9de-d417-0410-9af5-da40c76e7ee4

1ca2c441

Move packet decoding method at module level instead of Packet class as it was · 1be82862
Grégory Wisniewski authored May 20, 2009
```
done for encoding.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@500 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
1be82862

Remove packet argument from PacketMalformedError exception to move decode methods · d9b88d8b

Grégory Wisniewski authored May 20, 2009

from Packet class to protocol module in next commit as it was done for encoding.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@499 71dcc9de-d417-0410-9af5-da40c76e7ee4

d9b88d8b

Add PacketMalformedError exception that inherit from ProtocolError to replace · 79c6f0c0

Grégory Wisniewski authored May 20, 2009

the last one with decoding errors. New protocol exceptions will follows in next
commits.

git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@498 71dcc9de-d417-0410-9af5-da40c76e7ee4

79c6f0c0

Remove an unexpected and forgotten 'expectMessage' · 746fed5b
Grégory Wisniewski authored May 20, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@497 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
746fed5b

Factorize duplicate code that send informations about all nodes. · f340e457

Grégory Wisniewski authored May 20, 2009

Fix a bug where an empty packet could be sent.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@496 71dcc9de-d417-0410-9af5-da40c76e7ee4

f340e457

Factorize duplicate code that send the whole partition table. · 64fd593b
Grégory Wisniewski authored May 20, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@495 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
64fd593b

Remove all except statements that catch all exceptions in protocol.py, Catch · 65b73485

Grégory Wisniewski authored May 20, 2009

only struct.error exception since it's the wrapper class of struct module.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@494 71dcc9de-d417-0410-9af5-da40c76e7ee4

65b73485

Fix tests affected by previous commit. · a0a868d0

Grégory Wisniewski authored May 20, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@493 71dcc9de-d417-0410-9af5-da40c76e7ee4

a0a868d0

Remove except statements that catch all exceptions in connection.py and · b46d561c

Grégory Wisniewski authored May 20, 2009

connector.py by adding ConnectorException as base exception class and a 
ConnectorConnectionRefusedException raised in makeClientConnection() or 
recv(). All sockets error are wrapped in ConnectorException and special
(unknown) cases are not catched in connection.py


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@492 71dcc9de-d417-0410-9af5-da40c76e7ee4

b46d561c

Fix tests that fails since bug fix #490 (send renamed as notify) · e8db4fc3
Grégory Wisniewski authored May 20, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@491 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
e8db4fc3

Fix wrong method name. · aa81e97c

Grégory Wisniewski authored May 20, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@490 71dcc9de-d417-0410-9af5-da40c76e7ee4

aa81e97c

Fix bug introduced in replicator with commit #483. · 4242b047
Grégory Wisniewski authored May 20, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@489 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
4242b047

Factorize request/answer couples in client application by introducing · b551f6bf

Grégory Wisniewski authored May 20, 2009

_askStorage and _askPrimary methods.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@488 71dcc9de-d417-0410-9af5-da40c76e7ee4

b551f6bf

add missing import · deb19696

Aurel authored May 20, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@487 71dcc9de-d417-0410-9af5-da40c76e7ee4

deb19696

fix typo in comment · 35da0c34

Aurel authored May 20, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@486 71dcc9de-d417-0410-9af5-da40c76e7ee4

35da0c34

Enable SQL queries logging previously disabled by error. · fbee13ed
Grégory Wisniewski authored May 20, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@485 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
fbee13ed

19 May, 2009 6 commits

Update all tests according to previous commit. · 6fe1e76b

Grégory Wisniewski authored May 19, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@484 71dcc9de-d417-0410-9af5-da40c76e7ee4

6fe1e76b

When building a protocol packet, the ID is now added by the connection · 0d82139d

Grégory Wisniewski authored May 19, 2009

through notify(), ask() and answer() methods instead of addPacket directly.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@483 71dcc9de-d417-0410-9af5-da40c76e7ee4

0d82139d

Update tests affected with changes introduced with previous commit. · 7544eb06
Grégory Wisniewski authored May 19, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@482 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
7544eb06

First modification of packet management. Encoders are no more instance methods · f11bafed

Grégory Wisniewski authored May 19, 2009

but module methods that return Packet instances. Next operation is to set msg_id
related to connection only. Updated tests follow in next commit.

git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@481 71dcc9de-d417-0410-9af5-da40c76e7ee4

f11bafed

The ZODB test now successfull pass with 2 replicas / 3 nodes for an unknown · 58edc07e

Grégory Wisniewski authored May 19, 2009

reason, so the test configuration is updated to detect if this issue come back.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@480 71dcc9de-d417-0410-9af5-da40c76e7ee4

58edc07e

Update tests according to previous commit on transaction lock. · 25ff6bcd
Grégory Wisniewski authored May 19, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@479 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
25ff6bcd