Commits · 8f563d6afb0c9de03d395e547ca458ce274e07d5 · nexedi / neoppod

25 May, 2009 7 commits

Add tests for some methods of base handler. · 8f563d6a

Grégory Wisniewski authored May 25, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@529 71dcc9de-d417-0410-9af5-da40c76e7ee4

8f563d6a

Fix bugs around protocol exceptions handling : exception's arguments were not · 3213148a
Grégory Wisniewski authored May 25, 2009
```
handled propely.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@528 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
3213148a

Add tests for handlers decorators. · 729e3046

Grégory Wisniewski authored May 25, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@527 71dcc9de-d417-0410-9af5-da40c76e7ee4

729e3046

Use _clear_txn in __init__ to avoid code duplication. · 2b56bbbd
Grégory Wisniewski authored May 25, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@526 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
2b56bbbd

Factorize and clean master service. · 2f46a9cc

Grégory Wisniewski authored May 25, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@525 71dcc9de-d417-0410-9af5-da40c76e7ee4

2f46a9cc

Event test inherit from NeoTestBase · 581204e5

Grégory Wisniewski authored May 25, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@524 71dcc9de-d417-0410-9af5-da40c76e7ee4

581204e5

Use decorators in admin handler. · bc4b6b79

Grégory Wisniewski authored May 25, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@523 71dcc9de-d417-0410-9af5-da40c76e7ee4

bc4b6b79

22 May, 2009 11 commits

Update client tests. · ec6ddd6b

Grégory Wisniewski authored May 22, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@522 71dcc9de-d417-0410-9af5-da40c76e7ee4

ec6ddd6b

Unify packets checking in master and storage. · ed0cb88e

Grégory Wisniewski authored May 22, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@521 71dcc9de-d417-0410-9af5-da40c76e7ee4

ed0cb88e

Master and storage tests now inherit from neo.tests.base.NeoTestBase. · bdc2f9b5

Grégory Wisniewski authored May 22, 2009

Duplicate checks removed and unified. 


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@520 71dcc9de-d417-0410-9af5-da40c76e7ee4

bdc2f9b5

As suggested in previous commit, add base class for NEO related tests. · e443219f
Grégory Wisniewski authored May 22, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@519 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
e443219f

Improve storage bootstrap handler tests by introducing checkAskPacket(). It · 8e199966

Grégory Wisniewski authored May 22, 2009

might be better that all handlers tests classes inherits from a base class that
implements all those kind of common checks.

git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@518 71dcc9de-d417-0410-9af5-da40c76e7ee4

8e199966

Fix tests where _addPacket calls where check to zero time with calls to · 6984c60a

Grégory Wisniewski authored May 22, 2009

checkNoPacketSent that do the good job.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@517 71dcc9de-d417-0410-9af5-da40c76e7ee4

6984c60a

Fix tests with _addPacket instead of addPacket. · 22f00fe1

Grégory Wisniewski authored May 22, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@516 71dcc9de-d417-0410-9af5-da40c76e7ee4

22f00fe1

Fix test method checkNoPacketSent to follow migration from addPacket to · 421d5c65
Grégory Wisniewski authored May 22, 2009
```
notify/ask/answer.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@515 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
421d5c65

Remove checkCalledAbort method from tests since it's no more used because abort · 4d395a45

Grégory Wisniewski authored May 22, 2009

is now mainly called from neo/handler.py


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@514 71dcc9de-d417-0410-9af5-da40c76e7ee4

4d395a45

Replace a forgotten protocolError call by a raise of ProtocolError exception. · 3b6b372b
Grégory Wisniewski authored May 22, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@513 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
3b6b372b

Fix misspelled BrokenNodeDisallowedError name. · 2c0d04c7

Grégory Wisniewski authored May 22, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@512 71dcc9de-d417-0410-9af5-da40c76e7ee4

2c0d04c7

21 May, 2009 9 commits

Use differents databases between storage tests and ZODB to run them · 8c64c99e
Grégory Wisniewski authored May 21, 2009
```
simultaneously.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@511 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
8c64c99e

Handle ECONNRESET from socket level. · 9182462d

Grégory Wisniewski authored May 21, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@510 71dcc9de-d417-0410-9af5-da40c76e7ee4

9182462d

All-in-one commit : · 3d93441b

Grégory Wisniewski authored May 21, 2009

- Some private methods of Connection prefixed with '_'
- Thus those methods are no more overriden in MT* classes 
- Add description of notify/ask/answer methods and lockCheckWrapper
- Remove a forgotten addPacket from storage handler and another from master
service handler that requires to add an optional msg_id parameter to notify
- Update tests


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@509 71dcc9de-d417-0410-9af5-da40c76e7ee4

3d93441b

Last commit of exception-based error handling serie. Raise ProtocolError · ddb2d2bd

Grégory Wisniewski authored May 21, 2009

exception for all others errors.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@508 71dcc9de-d417-0410-9af5-da40c76e7ee4

ddb2d2bd

As for previous commits, raise notReadyError exception. All error send answer · 1b70a832

Grégory Wisniewski authored May 21, 2009

packets (with the id from the answered packet) when possible.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@507 71dcc9de-d417-0410-9af5-da40c76e7ee4

1b70a832

Raise an exception when a broken node send packet through a connection. Fix · eea5aff2

Grégory Wisniewski authored May 21, 2009

tests according to this changes and fix some others affected with previous
commits.

git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@506 71dcc9de-d417-0410-9af5-da40c76e7ee4

eea5aff2

Use decorators and UnexpectedPacketError exception instead of calls · aded81bc

Grégory Wisniewski authored May 21, 2009

handleUnexpectedPacket() in storage handlers.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@505 71dcc9de-d417-0410-9af5-da40c76e7ee4

aded81bc

In master handlers, replace calls to handleUnexpectedPacket() with raise of · 863a3207

Grégory Wisniewski authored May 21, 2009

UnexpectedPacketError exception or decorators previously commited.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@504 71dcc9de-d417-0410-9af5-da40c76e7ee4

863a3207

Add decorators that implements common patterns used in handlers methods. · def8b1ad
Grégory Wisniewski authored May 21, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@503 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
def8b1ad

20 May, 2009 13 commits

First part of replacement of handleUnexpectedPacket calls with raises of · 0d1ac173

Grégory Wisniewski authored May 20, 2009

UnexpectedPacketError exception. Update client (with tests) and admin nodes.
Those exceptions are now catched in dispatch() and redirect to
unexpectedPacket().

git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@502 71dcc9de-d417-0410-9af5-da40c76e7ee4

0d1ac173

Fix tests affected by commit #500. · 1ca2c441

Grégory Wisniewski authored May 20, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@501 71dcc9de-d417-0410-9af5-da40c76e7ee4

1ca2c441

Move packet decoding method at module level instead of Packet class as it was · 1be82862
Grégory Wisniewski authored May 20, 2009
```
done for encoding.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@500 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
1be82862

Remove packet argument from PacketMalformedError exception to move decode methods · d9b88d8b

Grégory Wisniewski authored May 20, 2009

from Packet class to protocol module in next commit as it was done for encoding.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@499 71dcc9de-d417-0410-9af5-da40c76e7ee4

d9b88d8b

Add PacketMalformedError exception that inherit from ProtocolError to replace · 79c6f0c0

Grégory Wisniewski authored May 20, 2009

the last one with decoding errors. New protocol exceptions will follows in next
commits.

git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@498 71dcc9de-d417-0410-9af5-da40c76e7ee4

79c6f0c0

Remove an unexpected and forgotten 'expectMessage' · 746fed5b
Grégory Wisniewski authored May 20, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@497 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
746fed5b

Factorize duplicate code that send informations about all nodes. · f340e457

Grégory Wisniewski authored May 20, 2009

Fix a bug where an empty packet could be sent.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@496 71dcc9de-d417-0410-9af5-da40c76e7ee4

f340e457

Factorize duplicate code that send the whole partition table. · 64fd593b
Grégory Wisniewski authored May 20, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@495 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
64fd593b

Remove all except statements that catch all exceptions in protocol.py, Catch · 65b73485

Grégory Wisniewski authored May 20, 2009

only struct.error exception since it's the wrapper class of struct module.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@494 71dcc9de-d417-0410-9af5-da40c76e7ee4

65b73485

Fix tests affected by previous commit. · a0a868d0

Grégory Wisniewski authored May 20, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@493 71dcc9de-d417-0410-9af5-da40c76e7ee4

a0a868d0

Remove except statements that catch all exceptions in connection.py and · b46d561c

Grégory Wisniewski authored May 20, 2009

connector.py by adding ConnectorException as base exception class and a 
ConnectorConnectionRefusedException raised in makeClientConnection() or 
recv(). All sockets error are wrapped in ConnectorException and special
(unknown) cases are not catched in connection.py


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@492 71dcc9de-d417-0410-9af5-da40c76e7ee4

b46d561c

Fix tests that fails since bug fix #490 (send renamed as notify) · e8db4fc3
Grégory Wisniewski authored May 20, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@491 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
e8db4fc3

Fix wrong method name. · aa81e97c

Grégory Wisniewski authored May 20, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@490 71dcc9de-d417-0410-9af5-da40c76e7ee4

aa81e97c