Commits · dab391471df23699fb30c4c5f99263087e85a813 · nexedi / neoppod

28 Jan, 2010 21 commits

Grégory Wisniewski authored Jan 28, 2010

- Nodes start in UNKNOWN state.
- Running and Unknown nodes are candidates during election.
- Set temporarily down if an established connection is lost.
- Keep in unknown state if a connection fails.

git-svn-id: https://svn.erp5.org/repos/neo/trunk@1541 71dcc9de-d417-0410-9af5-da40c76e7ee4

dab39147

Bug fix: Avoid open two connections to the same node. · 8fc436a8

Grégory Wisniewski authored Jan 28, 2010

After the AnswerPrimary was received, the unconnected_master_node_set was filled with the primary address, causing a new connection at the next iteration in the _doElection method.

git-svn-id: https://svn.erp5.org/repos/neo/trunk@1540 71dcc9de-d417-0410-9af5-da40c76e7ee4

8fc436a8

Add a test to ensure election success with many master nodes. · 761860a2
Grégory Wisniewski authored Jan 28, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1539 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
761860a2
Rename packet NO_ERROR error packet type to ACK as it's confusing. · c5f970c9
Grégory Wisniewski authored Jan 28, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1538 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
c5f970c9

Add missing helper method. · 0e4276ac

Grégory Wisniewski authored Jan 28, 2010

git-svn-id: https://svn.erp5.org/repos/neo/trunk@1537 71dcc9de-d417-0410-9af5-da40c76e7ee4

0e4276ac

Fix broken tests since getAssignedPartitionList() · 6535cb41
Grégory Wisniewski authored Jan 28, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1536 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
6535cb41

Simplify code pattern. · bbc7069f

Grégory Wisniewski authored Jan 28, 2010

git-svn-id: https://svn.erp5.org/repos/neo/trunk@1535 71dcc9de-d417-0410-9af5-da40c76e7ee4

bbc7069f

Remove useless if: no need to check the list before iterate over. · 171c6592
Grégory Wisniewski authored Jan 28, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1534 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
171c6592
Factorize gathering of assigned partitions. · 8f1fa695
Grégory Wisniewski authored Jan 28, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1533 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
8f1fa695
Redirect logs of applications running in test process to their own logfile. · 2dc227f8
Vincent Pelletier authored Jan 28, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1532 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
2dc227f8

Avoid handling events for a file descriptor more than once per _poll call. · 46a40237

Vincent Pelletier authored Jan 28, 2010

A single fd might be reported more than once per epoll call. This causes
the associated connection to be registered multiple times, which in turn
causes problems when the first connection registration gets emptied:
handling events of the second registration will raise an error when trying
to fetch a packet from an empty list.

git-svn-id: https://svn.erp5.org/repos/neo/trunk@1531 71dcc9de-d417-0410-9af5-da40c76e7ee4

46a40237

Remove trailing whitespaces. · 66cd62e9

Grégory Wisniewski authored Jan 28, 2010

git-svn-id: https://svn.erp5.org/repos/neo/trunk@1530 71dcc9de-d417-0410-9af5-da40c76e7ee4

66cd62e9

Set TCP_NODELAY on socket connections. · face448b
Grégory Wisniewski authored Jan 28, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1529 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
face448b
Increase a bit the size allowed for a node name. · 1b831534
Grégory Wisniewski authored Jan 28, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1528 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
1b831534
Add a TODO to implement restore() ZODB API method. · dd597f65
Grégory Wisniewski authored Jan 28, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1527 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
dd597f65
Add a TODO for caching previous object revisions. · 5daeb4de
Grégory Wisniewski authored Jan 28, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1526 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
5daeb4de
Add test for transaction isolation. · 08987a17
Grégory Wisniewski authored Jan 28, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1525 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
08987a17
Returns the connection instead of root object in makeTransaction. · 240922ef
Grégory Wisniewski authored Jan 28, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1524 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
240922ef
Handle 'broken pipe' errors as a connection closed. · b18bc173
Grégory Wisniewski authored Jan 28, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1523 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
b18bc173
Fix test: ProtocolError is raised instead of UnexpectedPackeError. · 0d67025e
Grégory Wisniewski authored Jan 28, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1522 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
0d67025e

Remove 'address' argument from AcceptIdentification packet. · c8dabbff

Grégory Wisniewski authored Jan 28, 2010

This argument is useless as the peer who receive this packet is the one who starts the connection, so it already knows the peer remote address.
Remove related (useless) checks and update unit tests.

git-svn-id: https://svn.erp5.org/repos/neo/trunk@1521 71dcc9de-d417-0410-9af5-da40c76e7ee4

c8dabbff

27 Jan, 2010 6 commits

Remove a logging message and the related try/finally block. · 6445101c
Grégory Wisniewski authored Jan 27, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1520 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
6445101c

Don't catch UnexpectedPacketError. · 3ac8eab4

Grégory Wisniewski authored Jan 27, 2010

Packet logger returns None is not implemented.

git-svn-id: https://svn.erp5.org/repos/neo/trunk@1519 71dcc9de-d417-0410-9af5-da40c76e7ee4

3ac8eab4

Update conflict resolution test. · 65d90cfd

Grégory Wisniewski authored Jan 27, 2010

Ensure that ConflictError is raised if _p_resolveConflict is not implemented.

git-svn-id: https://svn.erp5.org/repos/neo/trunk@1518 71dcc9de-d417-0410-9af5-da40c76e7ee4

65d90cfd

Fix test that were broken since r1498. · 80948fb7
Grégory Wisniewski authored Jan 27, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1517 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
80948fb7

Reduce indentation. · 73c42144

Grégory Wisniewski authored Jan 27, 2010

git-svn-id: https://svn.erp5.org/repos/neo/trunk@1516 71dcc9de-d417-0410-9af5-da40c76e7ee4

73c42144

Remove long-unused, bitrot and poorly scalable select event handler. · 1660dcbe
Vincent Pelletier authored Jan 27, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1515 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
1660dcbe

26 Jan, 2010 13 commits

Partial work on election handler tests rewrite. · eafd1f35
Grégory Wisniewski authored Jan 26, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1514 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
eafd1f35

Bug fix: If cell_list was greater than 10000 items, some connections would... · 6645329f

Grégory Wisniewski authored Jan 26, 2010

Bug fix: If cell_list was greater than 10000 items, some connections would receive a partial update.

As split big packets is under consideration, send all the cells in one packet for now.

git-svn-id: https://svn.erp5.org/repos/neo/trunk@1513 71dcc9de-d417-0410-9af5-da40c76e7ee4

6645329f

Join the two list before iterate over their content. · 52d2cee0
Grégory Wisniewski authored Jan 26, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1512 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
52d2cee0
Handle the --name application option (fix log). · fe38a6ca
Grégory Wisniewski authored Jan 26, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1511 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
fe38a6ca

Bug fix: Filter the client connection list with the primary's UUID. · 321ad941

Grégory Wisniewski authored Jan 26, 2010

As some client connections could have been established (but not accepted) during the previous poll(), the current client connection list can have more than one item.

git-svn-id: https://svn.erp5.org/repos/neo/trunk@1510 71dcc9de-d417-0410-9af5-da40c76e7ee4

321ad941

Bug fix: node variable was not assigned if None. · 8014153c
Grégory Wisniewski authored Jan 26, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1509 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
8014153c
Add a bug entry, race condition between admin, master and storage nodes. · 238084fe
Grégory Wisniewski authored Jan 26, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1508 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
238084fe

Set try/except block at the lowest level as possible. · 49fadeb1

Grégory Wisniewski authored Jan 26, 2010

- Avoid have a 'break' at the first level and the end of the 'wile True'
- Set try/except block around the only location where the exception can be raised.
- Reduce indentation
- Clarify that the loop purpose is to restart when an exception is raised.

git-svn-id: https://svn.erp5.org/repos/neo/trunk@1507 71dcc9de-d417-0410-9af5-da40c76e7ee4

49fadeb1

Move wait|announce primary code at the beginning of the related methods. · 968cd132
Grégory Wisniewski authored Jan 26, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1506 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
968cd132
Simplify a set intersection with only one element. · 14078395
Grégory Wisniewski authored Jan 26, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1505 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
14078395

Fix a typo in comment. · d880794d

Grégory Wisniewski authored Jan 26, 2010

git-svn-id: https://svn.erp5.org/repos/neo/trunk@1504 71dcc9de-d417-0410-9af5-da40c76e7ee4

d880794d

Reduce indentation. · a5c37f28

Grégory Wisniewski authored Jan 26, 2010

git-svn-id: https://svn.erp5.org/repos/neo/trunk@1503 71dcc9de-d417-0410-9af5-da40c76e7ee4

a5c37f28

Simply a condition on sets. · 18fb1a46

Grégory Wisniewski authored Jan 26, 2010

git-svn-id: https://svn.erp5.org/repos/neo/trunk@1502 71dcc9de-d417-0410-9af5-da40c76e7ee4

18fb1a46