Commits · ddb2d2bd2d44f23fe86b6eea6a627b991cea8383 · nexedi / neoppod

21 May, 2009 6 commits

Last commit of exception-based error handling serie. Raise ProtocolError · ddb2d2bd

Grégory Wisniewski authored May 21, 2009

exception for all others errors.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@508 71dcc9de-d417-0410-9af5-da40c76e7ee4

ddb2d2bd

As for previous commits, raise notReadyError exception. All error send answer · 1b70a832

Grégory Wisniewski authored May 21, 2009

packets (with the id from the answered packet) when possible.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@507 71dcc9de-d417-0410-9af5-da40c76e7ee4

1b70a832

Raise an exception when a broken node send packet through a connection. Fix · eea5aff2

Grégory Wisniewski authored May 21, 2009

tests according to this changes and fix some others affected with previous
commits.

git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@506 71dcc9de-d417-0410-9af5-da40c76e7ee4

eea5aff2

Use decorators and UnexpectedPacketError exception instead of calls · aded81bc

Grégory Wisniewski authored May 21, 2009

handleUnexpectedPacket() in storage handlers.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@505 71dcc9de-d417-0410-9af5-da40c76e7ee4

aded81bc

In master handlers, replace calls to handleUnexpectedPacket() with raise of · 863a3207

Grégory Wisniewski authored May 21, 2009

UnexpectedPacketError exception or decorators previously commited.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@504 71dcc9de-d417-0410-9af5-da40c76e7ee4

863a3207

Add decorators that implements common patterns used in handlers methods. · def8b1ad
Grégory Wisniewski authored May 21, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@503 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
def8b1ad

20 May, 2009 18 commits

First part of replacement of handleUnexpectedPacket calls with raises of · 0d1ac173

Grégory Wisniewski authored May 20, 2009

UnexpectedPacketError exception. Update client (with tests) and admin nodes.
Those exceptions are now catched in dispatch() and redirect to
unexpectedPacket().

git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@502 71dcc9de-d417-0410-9af5-da40c76e7ee4

0d1ac173

Fix tests affected by commit #500. · 1ca2c441

Grégory Wisniewski authored May 20, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@501 71dcc9de-d417-0410-9af5-da40c76e7ee4

1ca2c441

Move packet decoding method at module level instead of Packet class as it was · 1be82862
Grégory Wisniewski authored May 20, 2009
```
done for encoding.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@500 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
1be82862

Remove packet argument from PacketMalformedError exception to move decode methods · d9b88d8b

Grégory Wisniewski authored May 20, 2009

from Packet class to protocol module in next commit as it was done for encoding.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@499 71dcc9de-d417-0410-9af5-da40c76e7ee4

d9b88d8b

Add PacketMalformedError exception that inherit from ProtocolError to replace · 79c6f0c0

Grégory Wisniewski authored May 20, 2009

the last one with decoding errors. New protocol exceptions will follows in next
commits.

git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@498 71dcc9de-d417-0410-9af5-da40c76e7ee4

79c6f0c0

Remove an unexpected and forgotten 'expectMessage' · 746fed5b
Grégory Wisniewski authored May 20, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@497 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
746fed5b

Factorize duplicate code that send informations about all nodes. · f340e457

Grégory Wisniewski authored May 20, 2009

Fix a bug where an empty packet could be sent.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@496 71dcc9de-d417-0410-9af5-da40c76e7ee4

f340e457

Factorize duplicate code that send the whole partition table. · 64fd593b
Grégory Wisniewski authored May 20, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@495 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
64fd593b

Remove all except statements that catch all exceptions in protocol.py, Catch · 65b73485

Grégory Wisniewski authored May 20, 2009

only struct.error exception since it's the wrapper class of struct module.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@494 71dcc9de-d417-0410-9af5-da40c76e7ee4

65b73485

Fix tests affected by previous commit. · a0a868d0

Grégory Wisniewski authored May 20, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@493 71dcc9de-d417-0410-9af5-da40c76e7ee4

a0a868d0

Remove except statements that catch all exceptions in connection.py and · b46d561c

Grégory Wisniewski authored May 20, 2009

connector.py by adding ConnectorException as base exception class and a 
ConnectorConnectionRefusedException raised in makeClientConnection() or 
recv(). All sockets error are wrapped in ConnectorException and special
(unknown) cases are not catched in connection.py


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@492 71dcc9de-d417-0410-9af5-da40c76e7ee4

b46d561c

Fix tests that fails since bug fix #490 (send renamed as notify) · e8db4fc3
Grégory Wisniewski authored May 20, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@491 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
e8db4fc3

Fix wrong method name. · aa81e97c

Grégory Wisniewski authored May 20, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@490 71dcc9de-d417-0410-9af5-da40c76e7ee4

aa81e97c

Fix bug introduced in replicator with commit #483. · 4242b047
Grégory Wisniewski authored May 20, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@489 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
4242b047

Factorize request/answer couples in client application by introducing · b551f6bf

Grégory Wisniewski authored May 20, 2009

_askStorage and _askPrimary methods.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@488 71dcc9de-d417-0410-9af5-da40c76e7ee4

b551f6bf

add missing import · deb19696

Aurel authored May 20, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@487 71dcc9de-d417-0410-9af5-da40c76e7ee4

deb19696

fix typo in comment · 35da0c34

Aurel authored May 20, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@486 71dcc9de-d417-0410-9af5-da40c76e7ee4

35da0c34

Enable SQL queries logging previously disabled by error. · fbee13ed
Grégory Wisniewski authored May 20, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@485 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
fbee13ed

19 May, 2009 7 commits

Update all tests according to previous commit. · 6fe1e76b

Grégory Wisniewski authored May 19, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@484 71dcc9de-d417-0410-9af5-da40c76e7ee4

6fe1e76b

When building a protocol packet, the ID is now added by the connection · 0d82139d

Grégory Wisniewski authored May 19, 2009

through notify(), ask() and answer() methods instead of addPacket directly.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@483 71dcc9de-d417-0410-9af5-da40c76e7ee4

0d82139d

Update tests affected with changes introduced with previous commit. · 7544eb06
Grégory Wisniewski authored May 19, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@482 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
7544eb06

First modification of packet management. Encoders are no more instance methods · f11bafed

Grégory Wisniewski authored May 19, 2009

but module methods that return Packet instances. Next operation is to set msg_id
related to connection only. Updated tests follow in next commit.

git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@481 71dcc9de-d417-0410-9af5-da40c76e7ee4

f11bafed

The ZODB test now successfull pass with 2 replicas / 3 nodes for an unknown · 58edc07e

Grégory Wisniewski authored May 19, 2009

reason, so the test configuration is updated to detect if this issue come back.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@480 71dcc9de-d417-0410-9af5-da40c76e7ee4

58edc07e

Update tests according to previous commit on transaction lock. · 25ff6bcd
Grégory Wisniewski authored May 19, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@479 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
25ff6bcd

Remove client transaction lock. Set all transaction related variables as · 89c90374

Grégory Wisniewski authored May 19, 2009

thread-safe. Add two lock, one for the node manager, another for the partition
table to ensure exclusive access.

git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@478 71dcc9de-d417-0410-9af5-da40c76e7ee4

89c90374

18 May, 2009 3 commits

Update client application and handlers tests according to previous commit. Some · 5f4ba33b

Grégory Wisniewski authored May 18, 2009

checks added for changes included with previous commit, but it might be better
to split the test class too.

git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@477 71dcc9de-d417-0410-9af5-da40c76e7ee4

5f4ba33b

Split client handlers in four. Some bug fixes included and client no more add · d1226479

Grégory Wisniewski authored May 18, 2009

feeding nodes in the partition table. Updated tests will follow.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@476 71dcc9de-d417-0410-9af5-da40c76e7ee4

d1226479

Set log format and level on client to help debugging as in neomaster and neostorage. · d8ebfbb6
Grégory Wisniewski authored May 18, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@475 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
d8ebfbb6

15 May, 2009 3 commits

Display packet name instead of integer value in generic handler · dca42fc0
Grégory Wisniewski authored May 15, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@474 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
dca42fc0

forgot import · e2b49374

Aurel authored May 15, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@473 71dcc9de-d417-0410-9af5-da40c76e7ee4

e2b49374

reraise operation failure if we get one · 5e269b5e

Aurel authored May 15, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@472 71dcc9de-d417-0410-9af5-da40c76e7ee4

5e269b5e

14 May, 2009 3 commits

remove discarded node from partition table · 18028be2

Aurel authored May 14, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@471 71dcc9de-d417-0410-9af5-da40c76e7ee4

18028be2

if a SN is declaring itself up to date for a partition it has not been · aba0d60f

Aurel authored May 14, 2009

assigned to, tell it that it is in error


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@470 71dcc9de-d417-0410-9af5-da40c76e7ee4

aba0d60f

manage partitions to replicate using dictionnaries instead of lists · 1db68f81

Aurel authored May 14, 2009

thus the remove call can work and prevent from managing partitions which the
storage does not have been assigned to

git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@469 71dcc9de-d417-0410-9af5-da40c76e7ee4

1db68f81