Commits · f4d4452658761cf525437755da77fc950b1f9e52 · nexedi / neoppod

03 Aug, 2009 31 commits

Vincent Pelletier authored Aug 03, 2009

- Fix an inversion in killSecondaryMaster making it kill only primary nodes.
- Add DELAY_SAFETY_MARGIN to make explicit which part of a sleep delay is just here for safety, WRT the "mandatory" part of the delay.
- A disconnected secondary master node must be removed from NM, so its state becomes None.
- Add tests comparing the behaviour of a 2-masters and 3-masters cluster.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1158 71dcc9de-d417-0410-9af5-da40c76e7ee4

f4d44526

Remove an XXX, use of INVALID_OID with a valid OID value is not an issue because · ca187888

Grégory Wisniewski authored Aug 03, 2009

the INVALID_OID is never generated by getNewOIDList(). Moreover, we can't answer
with an error in the case where we have no last OID but a last PTID.

git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1157 71dcc9de-d417-0410-9af5-da40c76e7ee4

ca187888

Fix commit #1152. · fa52609d

Grégory Wisniewski authored Aug 03, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1156 71dcc9de-d417-0410-9af5-da40c76e7ee4

fa52609d

Improve node manager logging method to display node without UUIDs, but the sort · 7d1e8677
Grégory Wisniewski authored Aug 03, 2009
```
on UUIDs is lost.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1155 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
7d1e8677
Add missing definition for node manager log() method. · 00e286c8
Grégory Wisniewski authored Aug 03, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1154 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
00e286c8
Cast exception instance to string before give it to protocolError(). · 9af23e72
Grégory Wisniewski authored Aug 03, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1153 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
9af23e72

The neoctl API try to connect only one time to the admin node, if the connection · 7c42eaeb

Grégory Wisniewski authored Aug 03, 2009

fails, then it returns immediately.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1152 71dcc9de-d417-0410-9af5-da40c76e7ee4

7c42eaeb

Use connectionLost instead of handleNodeLost that is triggerred only in service · 632c4ef6
Grégory Wisniewski authored Aug 03, 2009
```
handlers.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1151 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
632c4ef6

Add a functionnal test for master node. · 6fc2afe7

Vincent Pelletier authored Aug 03, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1150 71dcc9de-d417-0410-9af5-da40c76e7ee4

6fc2afe7

Only make uuid an hex string when providing it as a parameter to the process. · bdeec552
Vincent Pelletier authored Aug 03, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1149 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
bdeec552

Rename handleConnectionLost to connectionLost for consistency. Add in the TODO · 2245bf19

Grégory Wisniewski authored Aug 03, 2009

list to think about a global rename of handler's methods.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1148 71dcc9de-d417-0410-9af5-da40c76e7ee4

2245bf19

Reorder handler.py module, switch some methods to private level, group handlers · 6b121f40

Grégory Wisniewski authored Aug 03, 2009

to help navigation through the code.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1147 71dcc9de-d417-0410-9af5-da40c76e7ee4

6b121f40

Remove unused imports. · 10b108f7

Vincent Pelletier authored Aug 03, 2009

Make it simpler to call NEOCluster.__newProcess.
Categorise process by node type, and add accessors to retrieve all nodes of a given type.
Generate node uuids in the test and implement accessors for this.

git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1146 71dcc9de-d417-0410-9af5-da40c76e7ee4

10b108f7

Factorize error handlers with handleConnectionLost() · 5367588c
Grégory Wisniewski authored Aug 03, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1145 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
5367588c

Remove commented-out lines. · 79c71851

Vincent Pelletier authored Aug 03, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1144 71dcc9de-d417-0410-9af5-da40c76e7ee4

79c71851

Add a forgotten import of neo.util.bin . · 74da1f6c

Vincent Pelletier authored Aug 03, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1143 71dcc9de-d417-0410-9af5-da40c76e7ee4

74da1f6c

Remove decorators used in shutdown handler, the handler implied those tests. · 13c848f9

Grégory Wisniewski authored Aug 03, 2009

Decorators defined in decorators.py are no more used in NEO, all extracted
patterns are now implied by the handlers.

git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1142 71dcc9de-d417-0410-9af5-da40c76e7ee4

13c848f9

Add the possibility to provide a UUID to a node upon startup. Mostly usefull... · 55ca6714

Vincent Pelletier authored Aug 03, 2009

Add the possibility to provide a UUID to a node upon startup. Mostly usefull in functional tests where we want to map a process to its UUID.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1141 71dcc9de-d417-0410-9af5-da40c76e7ee4

55ca6714

Remove unused definitions: · 631f2363

Grégory Wisniewski authored Aug 03, 2009

- SERIAL_NOT_FOUND is no more usefull.
- TIMEOUT_ERROR_CODE/handleTimeoutError is not used.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1140 71dcc9de-d417-0410-9af5-da40c76e7ee4

631f2363

Raise UnexpectedPacketError when receiving an error message, this is more · 6b79030c

Grégory Wisniewski authored Aug 03, 2009

consistent with other handler methods.
Remove the handleSerialNotFound method because it's never used.

git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1139 71dcc9de-d417-0410-9af5-da40c76e7ee4

6b79030c

Make getNewUUID a function so it can be reused without requiring to inherint from the whole class. · 6fb4c73e
Vincent Pelletier authored Aug 03, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1138 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
6fb4c73e
Move TODO items from README file and fix NEO Storage class name. · 5953febf
Grégory Wisniewski authored Aug 03, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1137 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
5953febf

Remove duplicate check. · 1fb45279

Grégory Wisniewski authored Aug 03, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1136 71dcc9de-d417-0410-9af5-da40c76e7ee4

1fb45279

Make it possible to request current primary master from neoctl (neoctl command... · d0ba0475

Vincent Pelletier authored Aug 03, 2009

Make it possible to request current primary master from neoctl (neoctl command support & API entry, admin node support).


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1135 71dcc9de-d417-0410-9af5-da40c76e7ee4

d0ba0475

Move a FIXME to the TODO list. · 3b9b7979

Grégory Wisniewski authored Aug 03, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1134 71dcc9de-d417-0410-9af5-da40c76e7ee4

3b9b7979

Factorise neoctl handler code. · ea3539cd

Vincent Pelletier authored Aug 03, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1133 71dcc9de-d417-0410-9af5-da40c76e7ee4

ea3539cd

Some changes in the TODO list. · d76037c9

Grégory Wisniewski authored Aug 03, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1132 71dcc9de-d417-0410-9af5-da40c76e7ee4

d76037c9

When a node detect that it is sending a too big message, this is a bug, so raise · 526c8ce0

Grégory Wisniewski authored Aug 03, 2009

instead of notify the peer of the error. 


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1131 71dcc9de-d417-0410-9af5-da40c76e7ee4

526c8ce0

Remove expiration mechanism of temporarily down nodes because it's the admin · b32e01b3

Grégory Wisniewski authored Aug 03, 2009

node that switch them in down state and notify the administrators.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1130 71dcc9de-d417-0410-9af5-da40c76e7ee4

b32e01b3

Assert the packet size and remove the related XXX. · 6d9ff4c2

Grégory Wisniewski authored Aug 03, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1129 71dcc9de-d417-0410-9af5-da40c76e7ee4

6d9ff4c2

Clean imports and check node properties in (un)register(Server|UUID). · 45c34b7b
Grégory Wisniewski authored Aug 03, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1128 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
45c34b7b

31 Jul, 2009 9 commits

Move all common test functions into a single class, making it more reusable between tests. · bb0141e2
Vincent Pelletier authored Jul 31, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1127 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
bb0141e2

Add a todo about reviewing hadnler split. · bacc91d9

Vincent Pelletier authored Jul 31, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1126 71dcc9de-d417-0410-9af5-da40c76e7ee4

bacc91d9

Fill the TODO list about the protocol module. · 1371f591

Grégory Wisniewski authored Jul 31, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1125 71dcc9de-d417-0410-9af5-da40c76e7ee4

1371f591

Client sleep a bit when no master are available, and a bit less when the master · 9232ec0a
Grégory Wisniewski authored Jul 31, 2009
```
found is not ready. 


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1124 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
9232ec0a
Client reuse Dispatcher.unregister() for storage connections. · 193b7bd3
Grégory Wisniewski authored Jul 31, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1123 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
193b7bd3

Update TODO list and removed some inlined XXXs about: · f80e4cdd

Grégory Wisniewski authored Jul 31, 2009

- split big packets
- gather multiple objects in one sql requests
- sql injection
- no more use notification packet to change a node state
- reduce duplicates


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1122 71dcc9de-d417-0410-9af5-da40c76e7ee4

f80e4cdd

When the primary lost a secondary, it have to set it in down state and broadcast · 3e440366

Grégory Wisniewski authored Jul 31, 2009

the information to others.
Remove an XXX: As for client node, a master don't leep its UUID, so it have to
be dropped from nodes managers.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1121 71dcc9de-d417-0410-9af5-da40c76e7ee4

3e440366

Allow create a new cluster with more than one storage node, this is controlled · 5912c7f7

Grégory Wisniewski authored Jul 31, 2009

by the REQUIRED_NODE_NUMBER definition, and keep the default with one node.
Add a XXX about broadcastNodeInformation possible improvement.

git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1120 71dcc9de-d417-0410-9af5-da40c76e7ee4

5912c7f7

Bug fix: ServerSocket was not set in non-blocking mode, causing the master wait · c31dc434

Grégory Wisniewski authored Jul 31, 2009

on the recv() until a ping was sent to it. Now the non-bloking state is defined
in the Connector __init__ to ensure all sockets will not block.

git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1118 71dcc9de-d417-0410-9af5-da40c76e7ee4

c31dc434