It never worked. It would have worked with recent pip.

See also https://hynek.me/articles/python-recursive-optional-dependencies/#pip-212-recursive-dependencies

This fixes a regression introduced in commit
4c3b6c4d:

  Traceback (most recent call last):
    File "neo/storage/app.py", line 196, in run
      self._run()
    File "neo/storage/app.py", line 228, in _run
      self.doOperation()
    File "neo/storage/app.py", line 305, in doOperation
      poll()
    File "neo/storage/app.py", line 147, in _poll
      self.em.poll(1)
    File "neo/lib/event.py", line 186, in poll
      self._poll(blocking)
    File "neo/lib/event.py", line 269, in _poll
      if conn.readable():
    File "neo/lib/connection.py", line 499, in readable
      self._closure()
    File "neo/lib/connection.py", line 557, in _closure
      self.close()
    File "neo/lib/connection.py", line 546, in close
      handler.connectionFailed(self)
    File "neo/storage/handlers/storage.py", line 67, in connectionFailed
      self.app.replicator.abort()
    File "neo/storage/replicator.py", line 460, in abort
      self._nextPartition()
    File "neo/storage/replicator.py", line 349, in _nextPartition
      self.fetchTransactions()
    File "neo/storage/replicator.py", line 395, in fetchTransactions
      FETCH_COUNT, offset)
    File "neo/storage/database/mysql.py", line 1009, in getReplicationTIDList
      '' if length is None else ' LIMIT %s' % length))
    File "neo/storage/database/mysql.py", line 89, in wrapper
      return wrapped(self, *args)
    File "neo/storage/database/mysql.py", line 224, in query
      assert self.lock._is_owned() or self.TEST_IDENT == thread.get_ident()
  AssertionError

This fixes a critical bug in the storage node that ignored read locks,
so transactions that have just been committed could be missing in the
results.

Because read locks are released by order of tid, a single storage node
never returned a list with holes (i.e. the missing transactions could
only be the last ones). However, holes could happen when merging
results from multiple storage nodes.

The change in the client node avoids extra RPC at the end:
it should speed up in most cases and it makes the new test clearer.

This applies only to an empty cluster and makes the cluster transition
from the initial state RECOVERING to BACKINGUP without passing through
state RUNNING:

(empty) -> RECOVERING -> VERIFYING -> STARTING_BACKUP -> BACKINGUP

This is the only way to reach BACKINGUP without having to pass through
RUNNING first and manually transitioning to STARTING_BACKUP. It is the
only way to reach state BACKINGUP fully automatically.

See merge request !25

Even if the user should have left backup mode before truncating
upstream, this change should help fixing his mistake and minimizing
the risk of data corruption.

The previous behaviour was to crash with:

  RuntimeError: upstream DB truncated

This led to 2 issues:

1. As long as upstream last tid remains older, it is impossible to
   start the backup cluster if it's able to connect to upstream:
   then to avoid another upstream downtime, it is required to fake
   a connection failure, e.g. with temporary firewall rules or
   different --upstream-* parameters, which is not practical.
2. Worse, if there's again new commits upstream with last tid newer
   than on backup, the user may miss to also truncate the backup
   cluster (even more if it's setup to restart automatically).

We had a case of a backup cluster that packed whereas --disable-pack
was passed. In fact, for some reasons, we had to hack to pass the
option so things aren't clear.

This is intended as a sanity check, so simple typos in neoctl truncate
command do not easily lead to the entire database being wiped.

See merge request !23

- do not notify about deleted oids, like ZEO
- exchange lists of partitions instead of oids when possible

Packing now requires the DB to be open RW.

The changes consist in:
- indenting many lines without exceeding 80 chars
- setting conn = None ASAP on ConnectionClosed
- adding a try..except clause

Starting from next commit, the exception can be POSException.ReadOnlyError.

Before this change, the only distinction between a timestamp and a TID was
the presence of the decimal separator, ".". As a result, a timestamp
mistakenly provided without a decimal separator would be interpreted as a
TID, which will be somewhere in January 1900 (as TIDs are 64bits with much
finer accuracy than timestamps). When used to truncate a database, and in
the absence of sanity checks, this would simply wipe the database.

So, instead of just relying on a decimal separator, require a longer
string. Make it a prefix for readability. Also, TIDs are more niche than
timestamp, require them to have a mark, and do not require anything from
timestamps.

The spaces are optional so it's cosmetics.

In practice, it may be only required for SQLite (because we don't force index)
on 'obj' (which as several indices).

This will be used by an external GC.

To be pushed upstream.

set_wakeup_fd only works in main thread.

See commit f47dd646.

Since the switch to msgpack, there's no more type checking at protocol level
and for example passing an integer would cause storage nodes to crash.

But as shown here, the type checking of the old protocol was not always
enough, because data structures at client side could anyway get wrong.

Else it leads to DB corruption and a crash of the master.

This fixes commit 0e43dd1f
("Fix signals not always being processed as soon as possible").

See commit b6f821a2.

Julien notes this is very likely unneeded:
!21 (diffs, comment 195929)

We had it like this since 01a01c8c (client: Add support for zodburi),
but I rechecked zodburi codebase now and it does not do any similar
lowering anywhere.

So drop support for case normalization in zurl options.

/cc @levin.zimmermann
/reviewed-by @jm
/reviewed-on !21

Unfortunately after creating SSL context it is not possible, or at least
I could not find how, to retrieve original credentials with which the
context was created. However wendelin.core needs to be able to take a
client storage, reconstruct zurl to refer to that particular storage,
and pass that zurl to wcfs, so that wcfs, in turn, could access the same
ZODB database.

Given a NEO client instance, it is already possible to retrieve
master_nodes, cluster name, and detect whether SSL is being in use.
However without being able to retrieve original SSL credentials,
reconstructed zurl will not be full and wcfs won't be able to use
exactly the same secrets as python part does.

-> Help wendelin.core by remembering which ca/cert/key were used to
build SSL context.

This information is used by zstor_2zurl in wendelin.core here:

https://lab.nexedi.com/nexedi/wendelin.core/blob/885b3556/lib/zodb.py#L390-418

/cc @levin.zimmermann
/reviewed-by @jm
/reviewed-on !21