1. 25 Sep, 2020 4 commits
    • Julien Muchembled's avatar
    • Julien Muchembled's avatar
      New algorithm for deadlock avoidance · 5e7f34d2
      Julien Muchembled authored
      The time complexity of previous one was too bad. With several tens of
      concurrent transactions, we saw commits take minutes to complete and
      the whole application looked frozen.
      This new algorithm is much simpler. Instead of asking the oldest
      transaction to somewhat restart (we used the "rebase" term because
      the concept was similar to what git-rebase does), the storage gives
      it priority and the newest is asked to relock (this request is ignored
      if vote already happened, which means there was actually no deadlock).
      testLocklessWriteDuringConflictResolution was initially more complex
      because Transaction.written (client) ignored KeyError (which is not the
      case anymore since commit 8ef1ddba).
    • Julien Muchembled's avatar
      qa: deindent code · d98b576c
      Julien Muchembled authored
    • Julien Muchembled's avatar
      Update comments · dbf128b7
      Julien Muchembled authored
  2. 10 Sep, 2020 3 commits
  3. 04 Sep, 2020 1 commit
  4. 21 Aug, 2020 1 commit
  5. 25 Jun, 2020 1 commit
  6. 24 Jun, 2020 1 commit
  7. 12 Jun, 2020 1 commit
    • Julien Muchembled's avatar
      qa: skip broken ZODB test · f4cb59d2
      Julien Muchembled authored
      FAIL: check_tid_ordering_w_commit (neo.tests.zodb.testBasic.BasicTests)
      Traceback (most recent call last):
        File "ZODB/tests/BasicStorage.py", line 397, in check_tid_ordering_w_commit
          self.assertEqual(results.pop('lastTransaction'), tids[1])
        File "neo/tests/__init__.py", line 301, in assertEqual
          return super(NeoTestBase, self).assertEqual(first, second, msg=msg)
      failureException: '\x03\xd8\x85H\xbffp\xbb' != '\x03\xd8\x85H\xbfs\x0b\xdd'
  8. 11 Jun, 2020 1 commit
  9. 29 May, 2020 3 commits
  10. 18 May, 2020 1 commit
    • Julien Muchembled's avatar
      admin: fix monitoring timer after 2 identical consecutive checks · c611c48f
      Julien Muchembled authored
      This fixes the bug that with only email notification, monitoring
      stopped checking whether backup clusters are lagging after status is
      unchanged since the last check (about lagging, what is compared is
      the set of lagging backups). Until another event wakes up monitoring.
      The code is also simplified in that there's no need for the moment to
      have a different timeout between the normal case and a smtp failure.
  11. 20 Mar, 2020 1 commit
  12. 16 Mar, 2020 2 commits
  13. 14 Feb, 2020 1 commit
    • Julien Muchembled's avatar
      master: fix tpc_finish possibly trying to kill too many nodes after client-storage failures · 82eea0cd
      Julien Muchembled authored
      When concurrent transactions fail with different storages (e.g. only network
      issues between C1-S2 and C2-S1), in such a way that each transaction can be
      committed but not both (or the cluster would be non-operational), and if the
      first transaction is aborted (between tpc_vote and tpc_finish), then the second
      wrongly failed with INCOMPLETE_TRANSACTION.
      And if both transactions could be committed (e.g. more than 1 replica),
      some nodes would be disconnected for nothing.
  14. 21 Jan, 2020 1 commit
    • Julien Muchembled's avatar
      admin: fix possible crash when monitoring a backup cluster that has just switch to BACKINGUP state · 5ee0b0a3
      Julien Muchembled authored
      This fixes:
        Traceback (most recent call last):
          File "neo/admin/handler.py", line 200, in answerLastTransaction
          File "neo/admin/app.py", line 380, in maybeNotify
          File "neo/admin/app.py", line 302, in _notify
            body += '', name, '    ' + backup.formatSummary(upstream)[1]
          File "neo/admin/app.py", line 74, in formatSummary
            tid = self.backup_tid if backup else self.ltid
        AttributeError: 'Backup' object has no attribute 'backup_tid'
  15. 10 Jan, 2020 1 commit
    • Julien Muchembled's avatar
      master: fix crash of backup master when disconnected from upstream while serving clients · 7e8ca9ec
      Julien Muchembled authored
      This fixes:
        Traceback (most recent call last):
          File "neo/master/app.py", line 172, in run
          File "neo/master/app.py", line 182, in _run
          File "neo/master/app.py", line 314, in playPrimaryRole
          File "neo/master/backup_app.py", line 101, in provideService
          File "neo/master/app.py", line 474, in changeClusterState
            ) or not node.isClient(), (state, node)
        AssertionError: (<EnumItem STARTING_BACKUP (4)>, <ClientNode(uuid=C1, state=RUNNING, connection=<ServerConnection(nid=C1, address=, handler=ClientReadOnlyServiceHandler, fd=59, on_close=onConnectionClosed, server) at 7f38f5628390>) at 7f38f5628ad0>)
  16. 07 Jan, 2020 1 commit
    • Julien Muchembled's avatar
      admin: fix handling of immediate connection failure to upstream admin · e2b11d54
      Julien Muchembled authored
      In such case, it didn't reconnect, but thought it was connected,
      which eventually led to crashes like:
        Traceback (most recent call last):
          File "neo/admin/handler.py", line 130, in answerClusterState
            self.app.updateMonitorInformation(None, cluster_state=state)
          File "neo/admin/app.py", line 274, in updateMonitorInformation
          File "neo/lib/connection.py", line 565, in send
            raise ConnectionClosed
  17. 26 Dec, 2019 2 commits
  18. 13 Nov, 2019 1 commit
    • Julien Muchembled's avatar
      admin: fix possible crash when connecting to upstream admin · d4603189
      Julien Muchembled authored
      This fixes:
        Traceback (most recent call last):
          File "neo/scripts/neoadmin.py", line 31, in main
          File "neo/admin/app.py", line 179, in run
          File "neo/admin/app.py", line 199, in _run
          File "neo/lib/event.py", line 155, in poll
          File "neo/lib/event.py", line 220, in _poll
            if conn.readable():
          File "neo/lib/connection.py", line 487, in readable
          File "neo/lib/connection.py", line 545, in _closure
          File "neo/lib/connection.py", line 534, in close
          File "neo/admin/handler.py", line 210, in connectionClosed
          File "neo/admin/app.py", line 230, in connectToUpstreamAdmin
            None, None, self.name, None, {}))
          File "neo/lib/connection.py", line 574, in ask
            raise ConnectionClosed
  19. 22 Oct, 2019 3 commits
  20. 17 Oct, 2019 3 commits
  21. 14 Oct, 2019 5 commits
  22. 16 Aug, 2019 2 commits