Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
N
neoppod
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 1
    • Issues 1
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 2
    • Merge Requests 2
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • nexedi
  • neoppod
  • Merge Requests
  • !7

Closed
Opened Sep 15, 2017 by Julien Muchembled@jm
  • Report abuse
Report abuse

WIP: Do not send invalidations for new oids, just like ZEO

It's only after I wrote this commit that I ran the whole test suite and then I realized that it breaks backup, because the backup master relies on invalidations to know which partition needs to be synced from upstream.

Even if this commit would reduce the impact of a memory leak, it does not avoid it completely, so it's just optimization. Is it worth, for example:

  • adding an RPC for the backup master to tell the upstream one that it's interested in invalidations for both modified and new oids ?
  • or rather stop using invalidations for that and send directly the list of partitions ?

The second option is actually an extra optimization.

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch origin
git checkout -b dont_invalidate_new origin/dont_invalidate_new

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout origin/master
git merge --no-ff dont_invalidate_new

Step 4. Push the result of the merge to GitLab

git push origin master

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

  • Discussion 7
  • Commits 1
  • Changes 6
Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
0
Labels
None
Assign labels
  • View project labels
Reference: nexedi/neoppod!7
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7