Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
N neoppod
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1
    • Issues 1
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge requests 2
    • Merge requests 2
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Incidents
    • Environments
  • Analytics
    • Analytics
    • CI/CD
    • Repository
    • Value Stream
  • Snippets
    • Snippets
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • nexedi
  • neoppod
  • Merge requests
  • !7

Closed
Created Sep 15, 2017 by Julien Muchembled@jmOwner
  • Report abuse
Report abuse

WIP: Do not send invalidations for new oids, just like ZEO

  • Overview 7
  • Commits 1
  • Changes 6

It's only after I wrote this commit that I ran the whole test suite and then I realized that it breaks backup, because the backup master relies on invalidations to know which partition needs to be synced from upstream.

Even if this commit would reduce the impact of a memory leak, it does not avoid it completely, so it's just optimization. Is it worth, for example:

  • adding an RPC for the backup master to tell the upstream one that it's interested in invalidations for both modified and new oids ?
  • or rather stop using invalidations for that and send directly the list of partitions ?

The second option is actually an extra optimization.

Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Source branch: dont_invalidate_new
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7