Adding RSVP#rethrow

Rethrow makes sure that any exception in your promise chain won't swallowed: getJSON('/posts.json') .then(handlePost) .fail(RSVP.rethrow) You can also to chain it further, like so: getJSON('/posts.json') .then(handlePost) .fail(RSVP.rethrow) .then(null, handleRejection)

Adding RSVP#rethrow
Rethrow makes sure that any exception in your promise chain won't swallowed: getJSON('/posts.json') .then(handlePost) .fail(RSVP.rethrow) You can also to chain it further, like so: getJSON('/posts.json') .then(handlePost) .fail(RSVP.rethrow) .then(null, handleRejection)
2e98c2d0 · Alex Navasardyan · 16f95c05 · 2e98c2d0 · 2e98c2d0 · 2e98c2d0
Commit 2e98c2d0 authored Aug 02, 2013 by Alex Navasardyan
6 changed files
--- a/README.md
+++ b/README.md
@@ -11,6 +11,7 @@ It works in node and the browser. You can get the browser build in
 ## downloads

 - [rsvp-latest](http://rsvpjs-builds.s3.amazonaws.com/rsvp-latest.js)
+- [rsvp-latest (amd)](http://rsvpjs-builds.s3.amazonaws.com/rsvp-latest.amd.js)

 ## Promises


--- a/lib/rsvp.js
+++ b/lib/rsvp.js
@@ -3,6 +3,7 @@ import { Promise } from "./rsvp/promise";
 import { denodeify } from "./rsvp/node";
 import { all } from "./rsvp/all";
 import { hash } from "./rsvp/hash";
+import { rethrow } from "./rsvp/rethrow";
 import { defer } from "./rsvp/defer";
 import { config } from "./rsvp/config";
 import { resolve } from "./rsvp/resolve";
@@ -12,4 +13,4 @@ function configure(name, value) {
  config[name] = value;
 }

-export { Promise, EventTarget, all, hash, defer, denodeify, configure, resolve, reject };
+export { Promise, EventTarget, all, hash, rethrow, defer, denodeify, configure, resolve, reject };
--- a/lib/rsvp/async.js
+++ b/lib/rsvp/async.js
@@ -51,7 +51,7 @@ function useMutationObserver() {

 function useSetTimeout() {
  return function(callback, arg) {
-    setTimeout(function() {
+    global.setTimeout(function() {
      callback(arg);
    }, 1);
  };

--- a/lib/rsvp/rethrow.js
+++ b/lib/rsvp/rethrow.js
+var local = (typeof global === "undefined") ? this : global;
+
+function rethrow(reason) {
+  local.setTimeout(function() {
+    throw reason;
+  });
+  throw reason;
+}
+
+export { rethrow };
--- a/test/index.html
+++ b/test/index.html
@@ -6,15 +6,15 @@
 </head>
 <body>
  <div id="mocha"></div>
-  <script src="../dist/rsvp-2.0.0.js"></script>
+  <script src="../dist/rsvp-2.0.1.js"></script>
  <script src="vendor/assert.js"></script>
  <script src="vendor/mocha.js"></script>
-  <script>mocha.setup({ ui: 'bdd', timeout: 200 })</script>
+  <script>mocha.setup({ ui: 'bdd', timeout: 200 }); mocha.globals(['setTimeout']);</script>
  <script src="../tmp/tests-bundle.js"></script>
  <script src="tests/extension_test.js"></script>
  <script>
    if (window.mochaPhantomJS) { mochaPhantomJS.run(); }
-    else { mocha.run(); }
+    else { mocha.globals(['setTimeout']); mocha.run(); }
  </script>
 </body>
 </html>
--- a/test/tests/extension_test.js
+++ b/test/tests/extension_test.js
 /*global describe, specify, it, assert */

+var local = (typeof global === "undefined") ? this : global;
+
 if (typeof Object.getPrototypeOf !== "function") {
  Object.getPrototypeOf = "".__proto__ === String.prototype
    ? function (object) {
@@ -724,6 +726,47 @@ describe("RSVP extensions", function() {
    });
  });

+  describe("RSVP.rethrow", function() {
+    var onerror, oldSetTimeout = global.setTimeout;
+
+    after(function() {
+      global.setTimeout = oldSetTimeout;
+    });
+
+    it("should exist", function() {
+      assert(RSVP.rethrow);
+    });
+
+    it("rethrows an error", function(done) {
+      var thrownError = new Error('I am an error.');
+
+      local.setTimeout = function (callback) {
+        done();
+        var errorWasThrown = false;
+
+        try {
+          callback.call(this, arguments);
+        } catch(e) {
+          errorWasThrown = true;
+        }
+        assert(errorWasThrown, 'expect that an error was thrown');
+      };
+
+      function expectRejection(reason) {
+        assertEqual(reason, thrownError);
+      }
+
+      function doNotExpectFulfillment(value) {
+        done();
+        assert(false, value);
+      }
+
+      RSVP.reject(thrownError).
+        fail(RSVP.rethrow).
+        then(doNotExpectFulfillment, expectRejection);
+    });
+  });
+
  describe("RSVP.resolve", function(){
    specify("it should exist", function(){
      assert(RSVP.resolve);