Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
S
slapos.buildout
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
6
Merge Requests
6
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
slapos.buildout
Commits
f61090bc
Commit
f61090bc
authored
May 18, 2020
by
Godefroid Chapelle
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Problem: missing error handling leads to IndexError
Solution: sys.exit when pip install fails
parent
2a57f192
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
3 additions
and
2 deletions
+3
-2
src/zc/buildout/easy_install.py
src/zc/buildout/easy_install.py
+3
-2
No files found.
src/zc/buildout/easy_install.py
View file @
f61090bc
...
@@ -1671,8 +1671,9 @@ def call_pip_install(spec, dest):
...
@@ -1671,8 +1671,9 @@ def call_pip_install(spec, dest):
logger
.
error
(
logger
.
error
(
"An error occurred when trying to install %s. "
"An error occurred when trying to install %s. "
"Look above this message for any errors that "
"Look above this message for any errors that "
"were output by
easy_
install."
,
"were output by
pip
install."
,
spec
)
spec
)
sys
.
exit
(
1
)
split_entries
=
[
os
.
path
.
splitext
(
entry
)
for
entry
in
os
.
listdir
(
dest
)]
split_entries
=
[
os
.
path
.
splitext
(
entry
)
for
entry
in
os
.
listdir
(
dest
)]
try
:
try
:
...
@@ -1681,7 +1682,7 @@ def call_pip_install(spec, dest):
...
@@ -1681,7 +1682,7 @@ def call_pip_install(spec, dest):
][
0
]
][
0
]
except
IndexError
:
except
IndexError
:
logger
.
error
(
logger
.
error
(
"No .dist-info directory after
installing
%s"
,
"No .dist-info directory after
successful pip install of
%s"
,
spec
)
spec
)
raise
raise
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment