Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
S slapos.buildout
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge requests 9
    • Merge requests 9
  • Operations
    • Operations
    • Incidents
  • Analytics
    • Analytics
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • nexedi
  • slapos.buildout
  • Merge requests
  • !23

Open
Created Jul 29, 2021 by Kirill Smelkov@kirrOwner
  • Report abuse
Report abuse

Accept both tarballs and pure-python wheels as sources

  • Overview 29
  • Commits 89
  • Changes 34

This redoes 0abf873d (Install egg from wheel only if explictly required), because that switch to install wheels only when explicitly requested broke things in several places[1,2]. We can avoid such breakage if instead of rejecting all wheels by default, we accept wheels, but allow only pure-python wheels to be installed.

As slapos!1026 (comment 138639) shows detecting whether a dist is pure-python wheel is just

(dist.precedence == WHL_DIST and dist.platform is None)

So let's use this and rework egg installer accordingly.

This patch is completely untested. However the way to check whether a wheel is source-only was tested at slapos!1026 (comment 138639).

If this patch is accepted and new slapos.buildout release is made, then all :whl usage in slapos.git can be dropped.

/cc @tomo, @jerome, @jm

[1] slapos!1026 (merged)
[2] slapos!1026 (comment 138590)

Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Source branch: x/allow-pure-py-wheels
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7