Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
S
slapos.core
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
20
Merge Requests
20
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Analytics
Analytics
CI / CD
Repository
Value Stream
Wiki
Wiki
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
nexedi
slapos.core
Commits
19f9102f
Commit
19f9102f
authored
Dec 14, 2018
by
Jérome Perrin
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
proxy: support for software destruction
parent
5d88e54e
Changes
5
Hide whitespace changes
Inline
Side-by-side
Showing
5 changed files
with
80 additions
and
29 deletions
+80
-29
slapos/cli/proxy_show.py
slapos/cli/proxy_show.py
+1
-1
slapos/proxy/schema.sql
slapos/proxy/schema.sql
+2
-1
slapos/proxy/views.py
slapos/proxy/views.py
+26
-7
slapos/slap/slap.py
slapos/slap/slap.py
+4
-3
slapos/tests/slapproxy/__init__.py
slapos/tests/slapproxy/__init__.py
+47
-17
No files found.
slapos/cli/proxy_show.py
View file @
19f9102f
...
...
@@ -166,7 +166,7 @@ def log_computer_table(logger, conn):
def
log_software_table
(
logger
,
conn
):
tbl_software
=
'software'
+
DB_VERSION
cur
=
conn
.
cursor
()
qry
=
cur
.
execute
(
"SELECT *, md5(url) as md5 FROM %s"
%
tbl_software
)
qry
=
cur
.
execute
(
"SELECT *, md5(url) as md5 FROM %s
where slap_state <> 'destroyed'
"
%
tbl_software
)
log_table
(
logger
,
qry
,
tbl_software
)
...
...
slapos/proxy/schema.sql
View file @
19f9102f
--version:1
1
--version:1
2
CREATE
TABLE
IF
NOT
EXISTS
software
%
(
version
)
s
(
url
VARCHAR
(
255
),
computer_reference
VARCHAR
(
255
)
DEFAULT
'%(computer)s'
,
slap_state
VARCHAR
(
255
)
DEFAULT
'available'
,
CONSTRAINT
uniq
PRIMARY
KEY
(
url
,
computer_reference
)
);
...
...
slapos/proxy/views.py
View file @
19f9102f
...
...
@@ -236,8 +236,12 @@ def getFullComputerInformation():
slap_computer
=
Computer
(
computer_id
)
slap_computer
.
_software_release_list
=
[]
for
sr
in
execute_db
(
'software'
,
'select * from %s WHERE computer_reference=?'
,
[
computer_id
]):
slap_computer
.
_software_release_list
.
append
(
SoftwareRelease
(
software_release
=
sr
[
'url'
],
computer_guid
=
computer_id
))
slap_computer
.
_software_release_list
.
append
(
SoftwareRelease
(
software_release
=
sr
[
'url'
],
computer_guid
=
computer_id
,
requested_state
=
sr
[
'slap_state'
]
))
slap_computer
.
_computer_partition_list
=
[]
for
partition
in
execute_db
(
'partition'
,
'SELECT * FROM %s WHERE computer_reference=?'
,
[
computer_id
]):
slap_computer
.
_computer_partition_list
.
append
(
partitiondict2partition
(
...
...
@@ -267,16 +271,25 @@ def setComputerPartitionConnectionXml():
@
app
.
route
(
'/buildingSoftwareRelease'
,
methods
=
[
'POST'
])
def
buildingSoftwareRelease
():
#raise ValueError("TODO ! mark building")
return
'Ignored'
@
app
.
route
(
'/destroyedSoftwareRelease'
,
methods
=
[
'POST'
])
def
destroyedSoftwareRelease
():
#raise ValueError("TODO ! mark destroyed")
return
'Ignored'
@
app
.
route
(
'/availableSoftwareRelease'
,
methods
=
[
'POST'
])
def
availableSoftwareRelease
():
#raise ValueError("TODO ! mark state available")
return
'Ignored'
@
app
.
route
(
'/softwareReleaseError'
,
methods
=
[
'POST'
])
def
softwareReleaseError
():
#raise ValueError("TODO ! mark state error")
return
'Ignored'
@
app
.
route
(
'/softwareInstanceError'
,
methods
=
[
'POST'
])
def
softwareInstanceError
():
return
'Ignored'
...
...
@@ -335,11 +348,17 @@ def registerComputerPartition():
def
supplySupply
():
url
=
request
.
form
[
'url'
]
computer_id
=
request
.
form
[
'computer_id'
]
if
request
.
form
[
'state'
]
==
'destroyed'
:
execute_db
(
'software'
,
'DELETE FROM %s WHERE url = ? AND computer_reference=?'
,
[
url
,
computer_id
])
else
:
execute_db
(
'software'
,
'INSERT OR REPLACE INTO %s VALUES(?, ?)'
,
[
url
,
computer_id
])
state
=
request
.
form
[
'state'
]
# TODO: only "available" and "requested" are valid states
# TODO: lifetime (available => requested) -> building -> available OR error
# TODO: lifetime (destroyed => destroy_requested) -> destroyed
# ( but check the names )
execute_db
(
'software'
,
'INSERT OR REPLACE INTO %s VALUES(?, ?, ?)'
,
[
url
,
computer_id
,
state
])
if
state
==
'destroyed'
:
return
'%r destroyed'
%
url
return
'%r added'
%
url
...
...
slapos/slap/slap.py
View file @
19f9102f
...
...
@@ -120,7 +120,7 @@ class SoftwareRelease(SlapDocument):
"""
zope
.
interface
.
implements
(
interface
.
ISoftwareRelease
)
def
__init__
(
self
,
software_release
=
None
,
computer_guid
=
None
,
**
kw
):
def
__init__
(
self
,
software_release
=
None
,
computer_guid
=
None
,
requested_state
=
'available'
,
**
kw
):
"""
Makes easy initialisation of class parameters
...
...
@@ -133,9 +133,10 @@ class SoftwareRelease(SlapDocument):
software_release
=
software_release
.
encode
(
'UTF-8'
)
self
.
_software_release
=
software_release
self
.
_computer_guid
=
computer_guid
self
.
_requested_state
=
requested_state
def
__getinitargs__
(
self
):
return
(
self
.
_software_release
,
self
.
_computer_guid
,
)
return
(
self
.
_software_release
,
self
.
_computer_guid
,
self
.
_requested_state
)
def
getComputerId
(
self
):
if
not
self
.
_computer_guid
:
...
...
@@ -175,7 +176,7 @@ class SoftwareRelease(SlapDocument):
'computer_id'
:
self
.
getComputerId
()})
def
getState
(
self
):
return
getattr
(
self
,
'_requested_state'
,
'available'
)
return
self
.
_requested_state
class
SoftwareProductCollection
(
object
):
...
...
slapos/tests/slapproxy/__init__.py
View file @
19f9102f
...
...
@@ -330,7 +330,7 @@ class MasterMixin(BasicMixin, unittest.TestCase):
computer_partition
.
__dict__
.
update
(
software_instance
.
__dict__
)
return
computer_partition
def
supply
(
self
,
url
,
computer_id
=
None
,
state
=
''
):
def
supply
(
self
,
url
,
computer_id
=
None
,
state
=
'
available
'
):
if
not
computer_id
:
computer_id
=
self
.
computer_id
request_dict
=
{
'url'
:
url
,
'computer_id'
:
computer_id
,
'state'
:
state
}
...
...
@@ -357,6 +357,18 @@ class MasterMixin(BasicMixin, unittest.TestCase):
return
instance
class
TestSoftwareInstallation
(
BasicMixin
,
unittest
.
TestCase
):
def
test_installation_success
(
self
):
# TODO: lifetime requested -> building -> available
self
.
fail
(
'TODO'
)
def
test_installation_failed
(
self
):
# TODO: lifetime requested -> building -> error
self
.
fail
(
'TODO'
)
def
test_destroyed
(
self
):
# TODO: lifetime available -> destroyed
self
.
fail
(
'TODO'
)
class
TestRequest
(
MasterMixin
):
"""
Set of tests for requests
...
...
@@ -705,6 +717,7 @@ class TestSlaveRequest(MasterMixin):
shared
=
True
,
filter_kw
=
dict
(
instance_guid
=
partition
.
_instance_guid
))
self
.
assertEqual
(
slave
.
_partition_id
,
partition
.
_partition_id
)
class
TestMultiNodeSupport
(
MasterMixin
):
def
test_multi_node_support_different_software_release_list
(
self
):
"""
...
...
@@ -778,17 +791,33 @@ class TestMultiNodeSupport(MasterMixin):
computer_0
=
loads
(
self
.
app
.
get
(
'/getFullComputerInformation?computer_id=COMP-0'
).
data
)
computer_1
=
loads
(
self
.
app
.
get
(
'/getFullComputerInformation?computer_id=COMP-1'
).
data
)
self
.
assertEqual
(
len
(
computer_0
.
_software_release_list
),
0
)
self
.
assertEqual
(
len
(
computer_1
.
_software_release_list
),
1
)
# at this point, software is requested to be destroyed on COMP-0
self
.
assertEqual
(
computer_0
.
_software_release_list
[
0
].
getURI
(),
software_release_url
)
self
.
assertEqual
(
computer_0
.
_software_release_list
[
0
].
getComputerId
(),
'COMP-0'
)
self
.
assertEqual
(
computer_0
.
_software_release_list
[
0
].
getState
(),
'destroyed'
)
# but is still requested for installation on COMP-1
self
.
assertEqual
(
computer_1
.
_software_release_list
[
0
].
_software_release
,
computer_1
.
_software_release_list
[
0
].
getURI
()
,
software_release_url
)
self
.
assertEqual
(
computer_1
.
_software_release_list
[
0
].
_computer_guid
,
computer_1
.
_software_release_list
[
0
].
getComputerId
()
,
'COMP-1'
)
self
.
assertEqual
(
computer_1
.
_software_release_list
[
0
].
getState
(),
'available'
# XXX it should be "requested" only at this point ?
)
def
test_multi_node_support_instance_default_computer
(
self
):
"""
...
...
@@ -977,6 +1006,7 @@ class TestMultiNodeSupport(MasterMixin):
except
slapos
.
slap
.
NotFoundError
:
self
.
fail
(
'Could not fetch informations for registered computer.'
)
class
TestMultiMasterSupport
(
MasterMixin
):
"""
Test multimaster support in slapproxy.
...
...
@@ -1264,23 +1294,23 @@ database_uri = %(tempdir)s/lib/external_proxy.db
# XXX: when testing new schema version,
# rename to "TestMigrateVersion10ToLatest" and test accordingly.
# Of course, also test version 1
1 to latest (should be 12
).
class
TestMigrateVersion10To1
1
(
TestInformation
,
TestRequest
,
TestSlaveRequest
,
TestMultiNodeSupport
):
# Of course, also test version 1
2 to latest (should be 13
).
class
TestMigrateVersion10To1
2
(
TestInformation
,
TestRequest
,
TestSlaveRequest
,
TestMultiNodeSupport
):
"""
Test that old database version are automatically migrated without failure
"""
def
setUp
(
self
):
super
(
TestMigrateVersion10To1
1
,
self
).
setUp
()
super
(
TestMigrateVersion10To1
2
,
self
).
setUp
()
schema
=
pkg_resources
.
resource_stream
(
'slapos.tests.slapproxy'
,
'database_dump_version_10.sql'
)
schema
=
schema
.
read
()
%
dict
(
version
=
'1
1
'
)
schema
=
schema
.
read
()
%
dict
(
version
=
'1
2
'
)
self
.
db
=
sqlite_connect
(
self
.
proxy_db
)
self
.
db
.
cursor
().
executescript
(
schema
)
self
.
db
.
commit
()
def
test_automatic_migration
(
self
):
table_list
=
(
'software1
1'
,
'computer11'
,
'partition11'
,
'slave11'
,
'partition_network11
'
)
table_list
=
(
'software1
2'
,
'computer12'
,
'partition12'
,
'slave12'
,
'partition_network12
'
)
for
table
in
table_list
:
self
.
assertRaises
(
sqlite3
.
OperationalError
,
self
.
db
.
execute
,
"SELECT name FROM computer1
1
"
)
self
.
assertRaises
(
sqlite3
.
OperationalError
,
self
.
db
.
execute
,
"SELECT name FROM computer1
2
"
)
# Run a dummy request to cause migration
self
.
app
.
get
(
'/getComputerInformation?computer_id=computer'
)
...
...
@@ -1291,31 +1321,31 @@ class TestMigrateVersion10To11(TestInformation, TestRequest, TestSlaveRequest, T
)
# Lower level tests
computer_list
=
self
.
db
.
execute
(
"SELECT * FROM computer1
1
"
).
fetchall
()
computer_list
=
self
.
db
.
execute
(
"SELECT * FROM computer1
2
"
).
fetchall
()
self
.
assertEqual
(
computer_list
,
[(
u'computer'
,
u'127.0.0.1'
,
u'255.255.255.255'
)]
)
software_list
=
self
.
db
.
execute
(
"SELECT * FROM software1
1
"
).
fetchall
()
software_list
=
self
.
db
.
execute
(
"SELECT * FROM software1
2
"
).
fetchall
()
self
.
assertEqual
(
software_list
,
[(
u'/srv/slapgrid//srv//runner/project//slapos/software.cfg'
,
u'computer'
)]
[(
u'/srv/slapgrid//srv//runner/project//slapos/software.cfg'
,
u'computer'
,
u'available'
)]
)
partition_list
=
self
.
db
.
execute
(
"select * from partition1
1
"
).
fetchall
()
partition_list
=
self
.
db
.
execute
(
"select * from partition1
2
"
).
fetchall
()
self
.
assertEqual
(
partition_list
,
[(
u'slappart0'
,
u'computer'
,
u'busy'
,
u'/srv/slapgrid//srv//runner/project//slapos/software.cfg'
,
u'<?xml version=
\
'
1.0
\
'
encoding=
\
'
utf-8
\
'
?>
\
n
<instance>
\
n
<parameter id="json">{
\
n
"site-id": "erp5"
\
n
}
\
n
}</parameter>
\
n
</instance>
\
n
'
,
None
,
None
,
u'production'
,
u'slapos'
,
None
,
u'started'
),
(
u'slappart1'
,
u'computer'
,
u'busy'
,
u'/srv/slapgrid//srv//runner/project//slapos/software.cfg'
,
u"<?xml version='1.0' encoding='utf-8'?>
\
n
<instance/>
\
n
"
,
u'<?xml version=
\
'
1.0
\
'
encoding=
\
'
utf-8
\
'
?>
\
n
<instance>
\
n
<parameter id="url">mysql://127.0.0.1:45678/erp5</parameter>
\
n
</instance>
\
n
'
,
None
,
u'mariadb'
,
u'MariaDB DataBase'
,
u'slappart0'
,
u'started'
),
(
u'slappart2'
,
u'computer'
,
u'busy'
,
u'/srv/slapgrid//srv//runner/project//slapos/software.cfg'
,
u'<?xml version=
\
'
1.0
\
'
encoding=
\
'
utf-8
\
'
?>
\
n
<instance>
\
n
<parameter id="cloudooo-json"></parameter>
\
n
</instance>
\
n
'
,
u'<?xml version=
\
'
1.0
\
'
encoding=
\
'
utf-8
\
'
?>
\
n
<instance>
\
n
<parameter id="url">cloudooo://127.0.0.1:23000/</parameter>
\
n
</instance>
\
n
'
,
None
,
u'cloudooo'
,
u'Cloudooo'
,
u'slappart0'
,
u'started'
),
(
u'slappart3'
,
u'computer'
,
u'busy'
,
u'/srv/slapgrid//srv//runner/project//slapos/software.cfg'
,
u"<?xml version='1.0' encoding='utf-8'?>
\
n
<instance/>
\
n
"
,
u'<?xml version=
\
'
1.0
\
'
encoding=
\
'
utf-8
\
'
?>
\
n
<instance>
\
n
<parameter id="url">memcached://127.0.0.1:11000/</parameter>
\
n
</instance>
\
n
'
,
None
,
u'memcached'
,
u'Memcached'
,
u'slappart0'
,
u'started'
),
(
u'slappart4'
,
u'computer'
,
u'busy'
,
u'/srv/slapgrid//srv//runner/project//slapos/software.cfg'
,
u"<?xml version='1.0' encoding='utf-8'?>
\
n
<instance/>
\
n
"
,
u'<?xml version=
\
'
1.0
\
'
encoding=
\
'
utf-8
\
'
?>
\
n
<instance>
\
n
<parameter id="url">memcached://127.0.0.1:13301/</parameter>
\
n
</instance>
\
n
'
,
None
,
u'kumofs'
,
u'KumoFS'
,
u'slappart0'
,
u'started'
),
(
u'slappart5'
,
u'computer'
,
u'busy'
,
u'/srv/slapgrid//srv//runner/project//slapos/software.cfg'
,
u'<?xml version=
\
'
1.0
\
'
encoding=
\
'
utf-8
\
'
?>
\
n
<instance>
\
n
<parameter id="kumofs-url">memcached://127.0.0.1:13301/</parameter>
\
n
<parameter id="memcached-url">memcached://127.0.0.1:11000/</parameter>
\
n
<parameter id="cloudooo-url">cloudooo://127.0.0.1:23000/</parameter>
\
n
</instance>
\
n
'
,
u'<?xml version=
\
'
1.0
\
'
encoding=
\
'
utf-8
\
'
?>
\
n
<instance>
\
n
<parameter id="url">https://[fc00::1]:10001</parameter>
\
n
</instance>
\
n
'
,
None
,
u'tidstorage'
,
u'TidStorage'
,
u'slappart0'
,
u'started'
),
(
u'slappart6'
,
u'computer'
,
u'free'
,
None
,
None
,
None
,
None
,
None
,
None
,
None
,
u'started'
),
(
u'slappart7'
,
u'computer'
,
u'free'
,
None
,
None
,
None
,
None
,
None
,
None
,
None
,
u'started'
),
(
u'slappart8'
,
u'computer'
,
u'free'
,
None
,
None
,
None
,
None
,
None
,
None
,
None
,
u'started'
),
(
u'slappart9'
,
u'computer'
,
u'free'
,
None
,
None
,
None
,
None
,
None
,
None
,
None
,
u'started'
)]
)
slave_list
=
self
.
db
.
execute
(
"select * from slave1
1
"
).
fetchall
()
slave_list
=
self
.
db
.
execute
(
"select * from slave1
2
"
).
fetchall
()
self
.
assertEqual
(
slave_list
,
[]
)
partition_network_list
=
self
.
db
.
execute
(
"select * from partition_network1
1
"
).
fetchall
()
partition_network_list
=
self
.
db
.
execute
(
"select * from partition_network1
2
"
).
fetchall
()
self
.
assertEqual
(
partition_network_list
,
[(
u'slappart0'
,
u'computer'
,
u'slappart0'
,
u'127.0.0.1'
,
u'255.255.255.255'
),
(
u'slappart0'
,
u'computer'
,
u'slappart0'
,
u'fc00::1'
,
u'ffff:ffff:ffff::'
),
(
u'slappart1'
,
u'computer'
,
u'slappart1'
,
u'127.0.0.1'
,
u'255.255.255.255'
),
(
u'slappart1'
,
u'computer'
,
u'slappart1'
,
u'fc00::1'
,
u'ffff:ffff:ffff::'
),
(
u'slappart2'
,
u'computer'
,
u'slappart2'
,
u'127.0.0.1'
,
u'255.255.255.255'
),
(
u'slappart2'
,
u'computer'
,
u'slappart2'
,
u'fc00::1'
,
u'ffff:ffff:ffff::'
),
(
u'slappart3'
,
u'computer'
,
u'slappart3'
,
u'127.0.0.1'
,
u'255.255.255.255'
),
(
u'slappart3'
,
u'computer'
,
u'slappart3'
,
u'fc00::1'
,
u'ffff:ffff:ffff::'
),
(
u'slappart4'
,
u'computer'
,
u'slappart4'
,
u'127.0.0.1'
,
u'255.255.255.255'
),
(
u'slappart4'
,
u'computer'
,
u'slappart4'
,
u'fc00::1'
,
u'ffff:ffff:ffff::'
),
(
u'slappart5'
,
u'computer'
,
u'slappart5'
,
u'127.0.0.1'
,
u'255.255.255.255'
),
(
u'slappart5'
,
u'computer'
,
u'slappart5'
,
u'fc00::1'
,
u'ffff:ffff:ffff::'
),
(
u'slappart6'
,
u'computer'
,
u'slappart6'
,
u'127.0.0.1'
,
u'255.255.255.255'
),
(
u'slappart6'
,
u'computer'
,
u'slappart6'
,
u'fc00::1'
,
u'ffff:ffff:ffff::'
),
(
u'slappart7'
,
u'computer'
,
u'slappart7'
,
u'127.0.0.1'
,
u'255.255.255.255'
),
(
u'slappart7'
,
u'computer'
,
u'slappart7'
,
u'fc00::1'
,
u'ffff:ffff:ffff::'
),
(
u'slappart8'
,
u'computer'
,
u'slappart8'
,
u'127.0.0.1'
,
u'255.255.255.255'
),
(
u'slappart8'
,
u'computer'
,
u'slappart8'
,
u'fc00::1'
,
u'ffff:ffff:ffff::'
),
(
u'slappart9'
,
u'computer'
,
u'slappart9'
,
u'127.0.0.1'
,
u'255.255.255.255'
),
(
u'slappart9'
,
u'computer'
,
u'slappart9'
,
u'fc00::1'
,
u'ffff:ffff:ffff::'
)]
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment