Skip to content

nexedi / slapos.core

Go to a project
Merge request !176 opened by  

proxy: Update timestamp partition on slave changes

Each time slave partition changes (it is added or updated) the master partition timestamp has to be recalculated.

{{ resolvedDiscussionCount }}/{{ discussionCount }} {{ resolvedCountText }} resolved
  • Łukasz Nowak @luke commented
    Master

    @tomo @rafael it seems important for development and also for our various tools.

    @Tyagov this is the thing which made deploy script unusable.

  • Rafael Monnerat @rafael commented
    Owner

    I didn't checked much, but just check if it don't cause "infinit" processing, where everything is processed over and over because timestamp changes all the time.

    Besides this, I see not problem on merging it

  • Łukasz Nowak @luke commented
    Master

    I didn't checked much, but just check if it don't cause "infinit" processing, where everything is processed over and over because timestamp changes all the time.

    Do we have a test showing this problem? If not, I am ok to write one, I'll extend also the test for this feature to show, that on no-op updates, nothing timestamp is not changed.

  • Łukasz Nowak @luke

    added 1 commit

    • 2c3f1ecf - proxy: Update timestamp partition on slave changes

    Compare with previous version

    added 1 commit

    • 2c3f1ecf - proxy: Update timestamp partition on slave changes

    Compare with previous version

    Toggle commit list
  • Łukasz Nowak
    @luke started a discussion on the diff
    Resolved by Łukasz Nowak
    slapos/tests/test_slapproxy.py
    902
    903 before_timestamp = after_timestamp
    904 time.sleep(0.1)
    905 self.request('http://sr//', None, 'MySecondSlave', shared=True, partition_parameter_kw={'a':'b'})
    906 after = getPartition()
    907 after_timestamp = getTimestamp(after)
    908 self.assertEqual(len(after._parameter_dict['slave_instance_list']), 2)
    909 self.assertLess(before_timestamp, after_timestamp, 'Updating any slave shall change the timestamp')
    910
    911 before_timestamp = after_timestamp
    912 time.sleep(0.1)
    913 self.request('http://sr//', None, 'MySecondSlave', shared=True, partition_parameter_kw={'a':'b'})
    914 after = getPartition()
    915 after_timestamp = getTimestamp(after)
    916 self.assertEqual(len(after._parameter_dict['slave_instance_list']), 2)
    917 self.assertEqual(before_timestamp, after_timestamp, 'No-op change of the slave shall not change the timestamp')
    • Łukasz Nowak @luke commented
      Master

      This test shows, that no-op changes of the slave won't result in updating the timestamp, and IMHO that's the protection against infinite processing !176 (comment 95875)

    Please register or sign in to reply
  • Łukasz Nowak @luke

    resolved all discussions

    resolved all discussions

    Toggle commit list
  • Łukasz Nowak @luke commented
    Master

    Tests are not bad for py3 and py2, merging.

  • Łukasz Nowak @luke

    mentioned in commit 4990aeaf

    mentioned in commit 4990aeaf

    Toggle commit list
  • Łukasz Nowak @luke

    merged

    merged

    Toggle commit list
  • Ivan Tyagov @Tyagov commented
    Developer

    Thanks!

Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or sign in to comment
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备14008524号