Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
S slapos.core
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Labels
    • Labels
  • Merge requests 26
    • Merge requests 26
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Environments
  • Analytics
    • Analytics
    • CI/CD
    • Repository
    • Value Stream
  • Members
    • Members
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • nexedi
  • slapos.core
  • Merge requests
  • !278

Merged
Created Jan 20, 2021 by Jérome Perrin@jeromeOwner

standalone: don't use --all in waitForSoftware / waitForInstance

  • Overview 20
  • Commits 1
  • Pipelines 6
  • Changes 2

Until now, standalone was running slapos node software/instance with --all flag which force installing software or processing software, unlike "normal" slapos node which no longer install on software once they are completed and only process instances when they are requested with different parameters or when they have failing promises.

We stop using the --all flag, to behave like a normal slapos node.

This reveal missing promises in some softwares, after this change, waitForInstance can return faster. This reveal test failures with some softwares where the instanciation step request other instances, but without having a promise to wait for their requests to have been sucessfully processed; in this case waitForInstance return too early.

We keep an "slapos node software --all" API to force reinstalling software, this can be useful for scenarios like erp5testnode, or software release development.

We also keep an hidden "slapos node instance --all" API, so that we can keep running tests for software releases with missing promises.

Edited Jul 07, 2021 by Jérome Perrin
Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Source branch: fix/standalone-all
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7