nexedi / slapos.core

Marked this merge request as a Work In Progress

mentioned in merge request slapos.recipe.cmmi!6

@rafael @xiaowu.zhang this MR is a placeholder for slapos node software part of slapos.recipe.cmmi!6 , as suggested in slapos.recipe.cmmi!6 (comment 60883)

I'm wondering if we should define one path or multiple paths to support the use case of webrunner (or testnode) using the cache of "parent" slapos.

In that case, slapos from webrunner or testnode would not be able to write to this cache (because no permission to write in that folder), but can still use softwares from this shared path.

One problem is that it would be harder to track which softwares are using the shared when we want to remove obsolete entries from the shared folder.

Also slapos.recipe.cmmi would be a bit more complex.

you can also include download-cache option too

In fact, I think here:

https://lab.nexedi.com/nexedi/slapos.core/blob/master/slapos/grid/SlapObject.py#L275

should generate something like:

[buildout]
extends = %(software_release)s

%(additional_options)s

I don't know why we append options on the command line, instead just write a buildout.cfg that actually works out of the box.

@rafael thanks for comments. I just realize you suggested in slapos.recipe.cmmi!6 (comment 60867) to name this option shared-part and here I used slapos-recipe-cmmi-shared-path name. I have no strong preference for either name. I started using slapos-recipe-cmmi-shared-path before noticing your suggestion.

That's a good point that we could generate a "ready to use" buildout in the first place. I just copied existing behaviour of passing options on command line, but it seems better to add this in generated buildout.

Added 1 commit:

• b9f401ba - [shared]: Rename slapos_recipe_cmmi_shared_path into shared_software_root

Added 1 commit:

• 9d9b3680 - wip: Create shared_software_root folders

@rafael I don't think we should use ',' as path separator. We could use os.pathsep but for consistency with other options in slapos.cfg ( for example download-from-binary-cache-url-blacklist ), why not be\n separated, one path per line ?

shared_software_root =
  /opt/slapgrid/shared/
  /srv/slapgrid/slappart0/srv/runner/software/shared/

sure, pathsep is better

how can i test this patch ? it seems i can't test in my webrunner. i changed slapos.core, but the one i changed is not used

Like everthing else related to egg "python setup.py test"

this patch is unfinished probably, as tests may fail (I may not finish myself, it is up to you to finish)

Added 1 commit:

• 65b4bfba - use \n for consistency with other options