nexedi / slapos.core

Maybe a bit more explanation about this test, because it was not easy.

This creates a partition using this script instead of buildout:

#!/bin/sh
mkdir -p etc/service &&
echo "#!/bin/sh" > etc/service/daemon &&
echo "touch launched
if [ -f ./crashed ]; then
while true; do echo Working; sleep 0.1; done
else
touch ./crashed; echo Failing; sleep 1; exit 111;
fi" >> etc/service/daemon &&
chmod 755 etc/service/daemon &&
touch worked

so when this buildout runs, it will:

• create etc/service/daemon with content (reformatted for readability)

#!/bin/sh
sleep 1 # (the fix was to add a delay here)
touch launched
if [ -f ./crashed ]; then
  while true; do
    echo Working;
    sleep 0.1;
  done
else
  touch ./crashed;
  echo Failing;
  sleep 1;
  exit 111;
fi

• make it executable
• touch a file worked which is a "proof" that buildout ran.

When daemon runs, it will:

• create a file launched which is a "proof" that daemon was started
• if a file crashed exists, print "Working" in an infinite loop
• otherwise create this crashed file and exit with error code.

---

Test on python2.7 and on python 3 does not have this specific failure.

@cedric.leninivin @rafael @alain.takoudjou @tomo I think it's OK, can you confirm ?

Seems fine to merge I think.

Yes it's very unlikely that this would have side effects, it's "test only" and this test is already failing.

mentioned in commit d4d89cce

merged