nexedi / slapos.core

added 1 commit

• 5429677f - Make IPv6 on tap optionnal (for IMT). Also put only 1 IPv6 address on the tap itself.

Compare with previous version

/cc @jm @guillaume.hervier

changed title from Make IPv6 on tap optionnal (for IMT). Also put only 1 IPv6 address on the tap itself. to Make IPv6 on tap optionnal. Also put only 1 IPv6 address on the tap itself.

added 1 commit

• d5f7f757 - Make IPv6 on tap optionnal. Also put only 1 IPv6 address on the tap itself.

Compare with previous version

added 11 commits

• d5f7f757...812d00c4 - 10 commits from branch master
• c000b130 - Make IPv6 on tap optionnal. Also put only 1 IPv6 address on the tap itself.

Compare with previous version

added 1 commit

• dae3c265 - Make IPv6 on tap optionnal and put only 1 IPv6 address on the tap itself.

Compare with previous version

better commit message for more info on why we chose to have only one IPv6 on the tap.

Shouldn't we move this long description to the slapos.cfg.sample and use a more concise description in change log ? for example something like (this is rst):

• format: new tap_iv6 configuration file option.

done

because this with_ipv6 variable is used only to build this message, maybe we could "inline" it ? making it a variable seems we are reusing it later.

How about this small change ?

      self.logger.info("Tap creation mode enabled (%s IPv6).", "with" if with_ipv6 else "without")

done

better commit message for more info on why we chose to have only one IPv6 on the tap.

Nice , just one warning about our "Apply patch" button. If we merge with this button, gitlab will rebase the commit on master and use the MR description as commit message ie. we would not have the commit message in the history of master branch, unless you also edit the MR description with the text from commit message.

added 1 commit

• 78c2558a - Make IPv6 on tap optionnal and put only 1 IPv6 address on the tap itself.

Compare with previous version

changed title from Make IPv6 on tap optionnal. Also put only 1 IPv6 address on the tap itself. to Make IPv6 on tap optionnal and put only 1 IPv6 address on the tap itself.

added 1 commit

• 34b9e202 - Make IPv6 on tap optionnal and put only 1 IPv6 address on the tap itself.

Compare with previous version

resolved all discussions

Thanks @jerome for your input. Indeed I would have been sad to lose the commit message I wrote to explain the issue clearly.

With this patch we will be able to get rid of re6st inside VMs as we will be able to use IPs from the host.

@rafael do you mind merging this ?

No objections for me after a quick read.

merged

mentioned in commit 40ee3280