Skip to content
  • This project
    • Loading...
  • Sign in

nexedi / slapos.core

Go to a project
Toggle navigation
Toggle navigation pinning
  • Projects
  • Groups
  • Snippets
  • Help
  • Project
  • Activity
  • Repository
  • Pipelines
  • Graphs
  • Issues 0
  • Merge Requests 15
  • Wiki
  • Network
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Merged
Merge Request !92 opened 2019-01-30 03:16:41 UTC by Jérome Perrin@jerome

tests: support running tests with py.test

  • rename test files as test_*.py, this is how tests are collected by py.test

  • take into account that test runner might disable log level and patch sys.stdout already

Edited 2019-01-31 06:20:42 UTC
Request to merge jerome:feat/test-pytest into master

Merged by Jérome Perrin 2019-01-31 06:20:42 UTC

The changes were merged into master. The source branch has been removed.

  • Discussion 5
  • Commits 1
  • Changes 19
  • {{ resolvedDiscussionCount }}/{{ discussionCount }} {{ resolvedCountText }} resolved
  • @jerome Jérome Perrin
    @jerome commented 2019-01-30 03:27:11 UTC
    Owner

    Because pytest test runner improve productivity in development phase ( supports invoking pdb on failures, easier to read error output, selecting tests to run, profiling, coverage etc) and this is still compatible with our current python setup.py test "official" way of running tests.

    I'm not at all suggesting to switch to pytest as a test framework, but just to make this test suite also compatible with pytest runner for those who like it.

    Note that I'm not 100% sure tests are all correct on pytest ( test_slapgrid seem to have failures - but not when running individual tests - I suspect pytest just reveal some test isolation or race condition problem ) and that I'm still waiting for tests results on our test infrastructure to confirm it does not introduce problems.

    /cc @tomo @rafael

    /alsocc @kirr and @luke who I believe are pytest users

    ( edit grammar mistake )

    Edited 2019-01-30 03:27:23 UTC
  • @rafael Rafael Monnerat
    @rafael commented 2019-01-30 03:38:25 UTC
    Owner

    No objects, pytest is nice, +1 to use it

  • @jerome Jérome Perrin
    @jerome commented 2019-01-30 06:27:53 UTC
    Owner

    slapos.core tests are OK on python 3 and python 2

  • @luke Łukasz Nowak
    @luke commented 2019-01-30 08:37:41 UTC
    Master

    +1

  • @jerome Jérome Perrin
    @jerome commented 2019-01-31 06:20:34 UTC
    Owner

    yes pytest is cool, let's merge this

  • @jerome Jérome Perrin
    @jerome

    mentioned in commit 531b3dbb

    2019-01-31 06:20:40 UTC

    mentioned in commit 531b3dbb

    Toggle commit list
  • @jerome Jérome Perrin
    @jerome

    merged

    2019-01-31 06:20:42 UTC

    merged

    Toggle commit list
  • Write
  • Preview
Styling with Markdown is supported
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
  • Please register or sign in to post a comment
Assignee
No assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
5
5 participants
Reference: nexedi/slapos.core!92
×

Revert this commit

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.
×

Cherry-pick this commit

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备14008524号