Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in / Register
  • S slapos.toolbox
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 0
    • Merge requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • nexedi
  • slapos.toolbox
  • Repository

Switch branch/tag
  • slapos.toolbox
  • slapos
  • promise
  • plugin
  • check_lopcomm_stats_log.py
Find file BlameHistoryPermalink
  • Kirill Smelkov's avatar
    promise/plugin/check_lopcomm_*: Skip all promises when testing=True · 48726608
    Kirill Smelkov authored Jan 17, 2024
    When testing is True we do not have hardware around and only check
    generated configuration files. Most lopcomm promises were already
    skipping themselves under testing=True environment, but
    check_lopcomm_config_log and check_lopcomm_stats_log were missing
    testing checks. This leads to test failures when trying to test
    ors-amarisoft with Lopcomm driver in my upcoming work via [1] e.g. as
    
        ================================================================================
        Error with promises for the following partitions:
          TestENB_Lopcomm4-0[enb]: Promise 'RU1-stats-log.py' failed with output: Not subscribed
    
    -> Fix it by making sure `testing==True` checks are present in all
       promises related to lopcomm.
    
    P.S. in current ors-amarisoft Lopcomm driver is not tested at all: even
    though we have testFDD-LOPCOMM.py there[2] `python unittest discover ...`
    does not pick up test files with dash in their name. This is also
    true for all other dashed test files. Currently only testTDD.py and
    testFDD.py are run during the tests there.
    
    [1] https://lab.nexedi.com/kirr/slapos/blob/5b8ec2b3/software/ors-amarisoft/test/test.py
    [2] https://lab.nexedi.com/nexedi/slapos/tree/15871bbf/software/ors-amarisoft/test
    
    /cc @lu.xu, @tomo, @xavier_thompson, @Daetalus
    /reviewed-by @jhuge
    /reviewed-on !129
    48726608

Replace check_lopcomm_stats_log.py

Attach a file by drag & drop or click to upload


Cancel
GitLab will create a branch in your fork and start a merge request.
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7