component/pcre: Update download url
The former ftp.pcre.org FTP site is no longer available, use sourceforge instead, see https://www.pcre.org/
-
MaintainerI am surprised with the need of this change. Isn't that source available in shacache?
-
Developer
ah... it is embarrassing to make such a stupid error... I fix it in a new commit.
Yes, we found the FTP pcre URL no longer available during the work of shacache.
Then we found in its official site https://www.pcre.org/, it said:
Note that the former ftp.pcre.org FTP site is no longer available. You will need to update any scripts that download PCRE source code to download via HTTPS, Git, or Subversion from the new home on GitHub instead.
The pcre repository on the GitHub only contains the version later than pcre2-10.00. So we have to get the older version from the sourceforge.
-
Maintainer
Note that the former ftp.pcre.org FTP site is no longer available. You will need to update any scripts that download PCRE source code to download via HTTPS, Git, or Subversion from the new home on GitHub instead.
The pcre repository on the GitHub only contains the version later than pcre2-10.00. So we have to get the older version from the sourceforge.
Still, the URL is in shacache. And shacache usage is a must, so such change is never needed in slapos profiles.
-
Maintainer
And anyway:
curl -o /dev/null -s -w '%{http_code}\n' https://download.sourceforge.net/pcre/pcre/8.45/pcre-8.45.tar.bz 404Please fully revert the change, we shall rely on shacache, and the package is there:
2022-03-21 11:38:04 slapos[3829936] INFO Installing pcre. 2022-03-21 11:38:04 slapos[3829936] INFO Downloading https://ftp.pcre.org/pub/pcre/pcre-8.45.tar.bz2 2022-03-21 11:38:04 slapos[3829936] INFO networkcache: Downloading slapos-buildout-7a69eb0196538266a02509f27e9caa7a... 2022-03-21 11:38:04 slapos[3829936] INFO Downloaded https://ftp.pcre.org/pub/pcre/pcre-8.45.tar.bz2 from network cache. -
Maintainer
I'd like to re-raise this problem.
In my opinion fixes f5a598dd and 916f695e are not what we expect from slapos repository.
As proven the original link is happy served from shacache, and this change is simply wrong by not using shacache, which was introduced especially for such case - missing original URL.
Therefore I still would like to have this fully reverted.
It seems I can't properly explain it, so I ping the problem you @tomo and @romain, what's your opinion?
-
Owner
I don't see any issue changing the URL if the previous one is not reachable anymore.
This does not impact previous software releases but only the future one.
We must then ensure the new URL is correctly uploaded to shacache. As for any new component version or for a new component.
-
Owner
Luke, we do want to fix broken URLs even if they're in shacache. The master branch must work without shacache. It must be possible to refill the cache for various reasons: shacache key change (rarely but that's the case here), shacache broken, signature not trusted anymore.
There's also the common case of a sensitive project that may only accept what is cached by devs of the project, and the devs have to reupload everything for their SR, ignoring what was previously cached by other Nexedi people. There can be more than 1 year between the moment an URL is committed to slapos.git/master and the project using this URL.
At last, downloading manually from shacache is not trivial. I think it's often too much for trainees to learn that.
-
Owner
FYI @luke, @Daetalus is currently working on testing our software releases with (nearly...) only shacache.
We are starting to get a first overview of the current status.
The next step will probably be to automatically upload missing content to shacache.
