Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
slapos slapos
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Labels
    • Labels
  • Merge requests 122
    • Merge requests 122
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Environments
  • Analytics
    • Analytics
    • CI/CD
    • Repository
    • Value Stream
  • Snippets
    • Snippets
  • Members
    • Members
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • nexedi
  • slaposslapos
  • Merge requests
  • !1387

Merged
Created Apr 24, 2023 by Levin Zimmermann@levin.zimmermannMaintainer

stack/erp5: Fix master node separation in NEO URI

  • Overview 2
  • Commits 1
  • Changes 4

Hello Kirill,

in 0cf70a6e we already migrated the NEO URI concatenation to the recent format used by WCFS. Unfortunately we missed separating the address (IPv6 + port) of the master nodes from each other. Without adding the separator , between them, WCFS doesn't work with NEO clusters which have multiple master nodes, because NEO/go can't split the different master node addresses.


This is necessary for kirr/neo!2 (merged).


Due to the reasons mentioned in !1308 we can't add automatic tests for this fix now. I therefore created a dedicated instance just to test this fix manually. A bit overkill for such a small fix, but anyway I could verify now that this fix works. If needed I can provide access data for this instance in private.

Best, Levin

/cc @kirr

Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Source branch: fix-neo-master-node-separation-for-wcfs
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7