Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
slapos slapos
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Labels
    • Labels
  • Merge requests 122
    • Merge requests 122
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Environments
  • Analytics
    • Analytics
    • CI/CD
    • Repository
    • Value Stream
  • Snippets
    • Snippets
  • Members
    • Members
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • nexedi
  • slaposslapos
  • Merge requests
  • !1398

Merged
Created May 30, 2023 by Xavier Thompson@xavier_thompsonOwner

stack/macros: Simplify pythonpath macro

  • Overview 4
  • Commits 2
  • Changes 2

Simplify macro.pythonpath.eggs and add a test in Jupyter to check that numpy can really be imported.

Background:

Macro macro.pythonpath.eggs was originally introduced to inject PYTHONPATH into a section holding environment variables for zc.recipe.egg:custom in order to make the cython egg available as a setup dependency for numpy (cython is needed to run numpy's setup.py).

Recently we looked at it with @lpgeneau, who has a similar use case to inject PYTHONPATH in slapos.recipe.cmmi environment. And we realised that macro.pythonpath.eggs was needlessly complicated and could be much simpler (and therefore understandable and maintainable). So we changed it, and to make sure this change didn't break numpy I wrote a jupyter test that actually imports numpy.

Edited May 30, 2023 by Xavier Thompson
Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Source branch: fix/simplify-pythonpath-macro
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7