Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
slapos slapos
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Labels
    • Labels
  • Merge requests 122
    • Merge requests 122
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Environments
  • Analytics
    • Analytics
    • CI/CD
    • Repository
    • Value Stream
  • Snippets
    • Snippets
  • Members
    • Members
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • nexedi
  • slaposslapos
  • Merge requests
  • !1400

You need to sign in or sign up before continuing.
Closed
Created Jun 02, 2023 by Levin Zimmermann@levin.zimmermannMaintainer
  • Report abuse
Report abuse

WIP: stack/erp5/instance-wcfs: Update NEO zurl

  • Overview 2
  • Commits 1
  • Changes 4

Hello @kirr,

this is the SlapOS part of kirr/neo!3 (closed) and the implementation of what we discussed at levin.zimmermann/neoppod@573514c6 (comment 184653).

I hope the commit message summarizes it correctly:

With kirr/neo!3 (closed) we changed the NEO scheme from

neo(s)://[credentials@]master1,master2,...,masterN/name?options

to

neo(s)://[credentials@]master1,master2,...,masterN/name?server_options#client_options

This change needs to be applied to the NEO URL constructor in SlapOS which parses the URL to wendelin.core. Furthermore this patch drops SlapOS NEO options, which don't belong to NEO API options (_ca, _key, _cert [1]), in order to stabilize WCFS.

[1] https://lab.nexedi.com/nexedi/slapos/blob/8e6f4101/software/neoppod/instance-neo-input-schema.json#L62

It's still WIP because I'm waiting for the last SlapOS integration test results.

It would be nice if we could wait for further process in neoppod!18 (closed) before applying this MR. If - for instance - we revert how SSL parameters are parsed currently, this could also be applied within the same MR and we wouldn't need to rework this SlapOS instance file again & again. But because it's not that complex to do this, I think it's also okay to apply this now.

Best, Levin

Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Source branch: updateneozurl
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7