Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Register
  • Sign in
  • slapos slapos
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Merge requests 134
    • Merge requests 134
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • nexedinexedi
  • slaposslapos
  • Merge requests
  • !1837

Draft: wendelin.core: v↑ 2.0.alpha4 -> 2.0.alpha4.1

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Levin Zimmermann requested to merge levin.zimmermann/slapos:fix-wcfs-promise into master Jun 09, 2025
  • Overview 28
  • Commits 6
  • Pipelines 0
  • Changes 8

Since wendelin.core@e751b02c WCFS CLI 'status' command spawns a subprocess to avoid hanging if WCFS is deadlocked. To ensure the subprocess can find all python modules, we need to utilize the 'pyprog' section. Even if WCFS xmultiprocessing implementation would auto-set 'sys.path', this is still a relevant change:

"wcfs is not only multiprocessing and there might be other places that depend on correct sys.path to be set in the spawned subinterpreters." [1]

[1] wendelin.core!40 (comment 237529)


This is semantically not exactly related to !1815 (merged), but is still needed there to let all tests pass. To only merge levin.zimmermann/slapos@74fae446 to current master (92bec259) doesn't really 'fix' something, because current 'wendelin.core' version is before wendelin.core@e751b02c. That's why I also added levin.zimmermann/slapos@9360ddd8.

/cc @kirr @jerome

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: fix-wcfs-promise
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7