Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
slapos slapos
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Labels
    • Labels
  • Merge requests 122
    • Merge requests 122
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Environments
  • Analytics
    • Analytics
    • CI/CD
    • Repository
    • Value Stream
  • Snippets
    • Snippets
  • Members
    • Members
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • nexedi
  • slaposslapos
  • Merge requests
  • !423

Closed
Created Oct 24, 2018 by Nicolas Wavrant@NicolasMaintainer
  • Report abuse
Report abuse

slaprunner: use the new python version of runner-exporter

  • Overview 2
  • Commits 1
  • Changes 5

Currently for most of the import/export scripts of resiliency we still use bash scripts, which are directly rendered by slapos using jinja2 templates. This is an extremely bad practice, as it makes writing tests for these scripts infinitely impractical. Also, bash is a language that very few people can use properly. For exemple, I already saw this kind of things :

- grep ...

if [ $? -eq 0 ] 

(if you don't understand, that proves my point).

This combined to the current lack of tests make the resiliency stack untrustable.

This MR has the purpose to put the first stone on the road of cleaning this situation, by replacing the runner-exorpter script in bash by python, a scripting language mastered by everyone in Nexedi, and by stopping using scripts rendered as jinja templates.

This MR depends on slapos.toolbox!44 (merged)

Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Source branch: runner-exporter-python
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7