Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
slapos slapos
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Labels
    • Labels
  • Merge requests 122
    • Merge requests 122
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Environments
  • Analytics
    • Analytics
    • CI/CD
    • Repository
    • Value Stream
  • Snippets
    • Snippets
  • Members
    • Members
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • nexedi
  • slaposslapos
  • Merge requests
  • !690

Merged
Created Jan 31, 2020 by Jérome Perrin@jeromeOwner

slapos.cookbook/testing: fix missing version pin for mock

  • Overview 5
  • Commits 1
  • Pipelines 2
  • Changes 3

Because we run egg tests with setup.py test, which installs missing eggs, if an egg was not installed by buildout, then it installed before running test. This was the case for mock, which is now python3 only ( https://pypi.org/project/mock/4.0.0b1/ ) and we started to see test failures.

To solve this issue, refactor the setup definition to use extra_requires, which seems to work fine in buildout now. Keep test_requires because it's the what python setup.py test uses.

Clean buildout profiles to install slapos.cookbook[test] for test instead of duplicating the content of test_requires.

Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Source branch: fix/missing_mock_pin_on_slapos_sr_test
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7