Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
slapos slapos
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Labels
    • Labels
  • Merge requests 122
    • Merge requests 122
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Environments
  • Analytics
    • Analytics
    • CI/CD
    • Repository
    • Value Stream
  • Snippets
    • Snippets
  • Members
    • Members
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • nexedi
  • slaposslapos
  • Merge requests
  • !833

Merged
Created Oct 09, 2020 by Jérome Perrin@jeromeOwner

More slaprunner promises

  • Overview 9
  • Commits 3
  • Pipelines 1
  • Changes 2

The supervisord uses by slapos instance for instances was not checked by promises, so if an error happened while starting it the first time, partition was not reprocessed (this is the problem we observed when updating)

There's also a slapos proxy which was not checked by promises.

This adds the two missing promises.

While doing this, I noticed that the ~/bin/slapos wrapper can behave unexpectedly when user has $SLAPOS_CONFIGURATION in their environment. While that's probably fine when using this command interactively, when this command is used to run service we don't want to be influenced by environment, so the service running supervisord was also updated to always use the expected config file, to prevent potential problem when slaprunner is started with $SLAPOS_CONFIGURATION pointing to another config file.

Edited Oct 12, 2020 by Jérome Perrin
Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Source branch: fix/slaprunner-promise
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7